Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] shadowsocks-libev: add connmarktos build option
Date: Tue, 20 Nov 2018 09:00:26 +0100	[thread overview]
Message-ID: <20181120090026.0091891c@windsurf.home> (raw)
In-Reply-To: <871s7jh1jd.fsf@tkos.co.il>

Hello,

On Sat, 17 Nov 2018 22:49:58 +0200, Baruch Siach wrote:

> > config BR2_PACKAGE_SHADOWSOCKS_LIBEV_CONNMARKTOS
> > - bool "enable connmarktos feature"
> > + bool "ss-server: enable connmarktos feature"
> >  depends on BR2_PACKAGE_SHADOWSOCKS_LIBEV
> >  select BR2_PACKAGE_LIBNETFILTER_CONNTRACK
> >  help
> > - Build with the connmark to TOS feature
> > + Build ss-server with the connmark to TOS feature.
> > + This feature require advanced tc, iptables and conntrac
> > + rules to perform QoS on the server side.
> > + if unsure say N.  
> 
> Sounds reasonable to me. Let's see what others think.

Yes, soon reasonable to me as well. Perhaps the option title should be:

	bool "conmarktos support in ss-server"

or

	bool "ss-server conmarktos support"

S?bastien, could you take into account the various comments received
from Baruch, and send an updated version ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-11-20  8:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 16:43 [Buildroot] [PATCH 1/1] shadowsocks-libev: add connmarktos build option DUPONCHEEL Sébastien
2018-11-15 18:24 ` Baruch Siach
     [not found]   ` <25f6955b-c3f1-28a1-2a51-6ad90f391c9c@corp.ovh.com>
2018-11-17 20:49     ` Baruch Siach
2018-11-20  8:00       ` Thomas Petazzoni [this message]
2018-11-20  9:59         ` DUPONCHEEL Sébastien
2018-11-20 13:56       ` DUPONCHEEL Sébastien
2018-11-20 19:36         ` Baruch Siach
2018-11-20 22:25         ` Arnout Vandecappelle
2018-11-21 10:59           ` DUPONCHEEL Sébastien
  -- strict thread matches above, loose matches on Subject: below --
2018-11-21 15:12 DUPONCHEEL Sébastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181120090026.0091891c@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox