* [Buildroot] [next] test_rust: use standard defconfig fragment style
@ 2018-11-16 22:21 Ricardo Martincoski
2018-11-17 1:19 ` Matthew Weber
2018-11-20 8:01 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Ricardo Martincoski @ 2018-11-16 22:21 UTC (permalink / raw)
To: buildroot
Since commit "2927f412be support/testing: standardize defconfig
fragments style" all other test cases use the same style for defconfig
fragments:
- start after a backslash;
- be declared as a multi-line string literal;
- be indented one level more than the variable that contains it.
Do the same here for consistency.
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Cc: Matt Weber <matthew.weber@rockwellcollins.com>
---
support/testing/tests/package/test_rust.py | 78 +++++++++++-----------
1 file changed, 39 insertions(+), 39 deletions(-)
diff --git a/support/testing/tests/package/test_rust.py b/support/testing/tests/package/test_rust.py
index 2dc814f99d..9854c3692e 100644
--- a/support/testing/tests/package/test_rust.py
+++ b/support/testing/tests/package/test_rust.py
@@ -57,25 +57,25 @@ class TestRustBase(infra.basetest.BRTest):
class TestRustBin(TestRustBase):
config = \
- """
- BR2_arm=y
- BR2_cortex_a9=y
- BR2_ARM_ENABLE_NEON=y
- BR2_ARM_ENABLE_VFP=y
- BR2_TOOLCHAIN_EXTERNAL=y
- BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
- BR2_SYSTEM_DHCP="eth0"
- BR2_LINUX_KERNEL=y
- BR2_LINUX_KERNEL_CUSTOM_VERSION=y
- BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.11.3"
- BR2_LINUX_KERNEL_DEFCONFIG="vexpress"
- BR2_LINUX_KERNEL_DTS_SUPPORT=y
- BR2_LINUX_KERNEL_INTREE_DTS_NAME="vexpress-v2p-ca9"
- BR2_TARGET_ROOTFS_CPIO=y
- # BR2_TARGET_ROOTFS_TAR is not set
- BR2_PACKAGE_HOST_CARGO=y
- BR2_PACKAGE_HOST_RUSTC=y
- """
+ """
+ BR2_arm=y
+ BR2_cortex_a9=y
+ BR2_ARM_ENABLE_NEON=y
+ BR2_ARM_ENABLE_VFP=y
+ BR2_TOOLCHAIN_EXTERNAL=y
+ BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
+ BR2_SYSTEM_DHCP="eth0"
+ BR2_LINUX_KERNEL=y
+ BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+ BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.11.3"
+ BR2_LINUX_KERNEL_DEFCONFIG="vexpress"
+ BR2_LINUX_KERNEL_DTS_SUPPORT=y
+ BR2_LINUX_KERNEL_INTREE_DTS_NAME="vexpress-v2p-ca9"
+ BR2_TARGET_ROOTFS_CPIO=y
+ # BR2_TARGET_ROOTFS_TAR is not set
+ BR2_PACKAGE_HOST_CARGO=y
+ BR2_PACKAGE_HOST_RUSTC=y
+ """
def test_run(self):
self.build_test_prog()
@@ -86,26 +86,26 @@ class TestRustBin(TestRustBase):
class TestRust(TestRustBase):
config = \
- """
- BR2_arm=y
- BR2_cortex_a9=y
- BR2_ARM_ENABLE_NEON=y
- BR2_ARM_ENABLE_VFP=y
- BR2_TOOLCHAIN_EXTERNAL=y
- BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
- BR2_SYSTEM_DHCP="eth0"
- BR2_LINUX_KERNEL=y
- BR2_LINUX_KERNEL_CUSTOM_VERSION=y
- BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.11.3"
- BR2_LINUX_KERNEL_DEFCONFIG="vexpress"
- BR2_LINUX_KERNEL_DTS_SUPPORT=y
- BR2_LINUX_KERNEL_INTREE_DTS_NAME="vexpress-v2p-ca9"
- BR2_TARGET_ROOTFS_CPIO=y
- # BR2_TARGET_ROOTFS_TAR is not set
- BR2_PACKAGE_HOST_CARGO=y
- BR2_PACKAGE_HOST_RUSTC=y
- BR2_PACKAGE_HOST_RUST=y
- """
+ """
+ BR2_arm=y
+ BR2_cortex_a9=y
+ BR2_ARM_ENABLE_NEON=y
+ BR2_ARM_ENABLE_VFP=y
+ BR2_TOOLCHAIN_EXTERNAL=y
+ BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
+ BR2_SYSTEM_DHCP="eth0"
+ BR2_LINUX_KERNEL=y
+ BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+ BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.11.3"
+ BR2_LINUX_KERNEL_DEFCONFIG="vexpress"
+ BR2_LINUX_KERNEL_DTS_SUPPORT=y
+ BR2_LINUX_KERNEL_INTREE_DTS_NAME="vexpress-v2p-ca9"
+ BR2_TARGET_ROOTFS_CPIO=y
+ # BR2_TARGET_ROOTFS_TAR is not set
+ BR2_PACKAGE_HOST_CARGO=y
+ BR2_PACKAGE_HOST_RUSTC=y
+ BR2_PACKAGE_HOST_RUST=y
+ """
def test_run(self):
self.build_test_prog()
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Buildroot] [next] test_rust: use standard defconfig fragment style
2018-11-16 22:21 [Buildroot] [next] test_rust: use standard defconfig fragment style Ricardo Martincoski
@ 2018-11-17 1:19 ` Matthew Weber
2018-11-20 8:01 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Weber @ 2018-11-17 1:19 UTC (permalink / raw)
To: buildroot
Ricardo,
On Fri, Nov 16, 2018 at 4:22 PM Ricardo Martincoski
<ricardo.martincoski@gmail.com> wrote:
>
> Since commit "2927f412be support/testing: standardize defconfig
> fragments style" all other test cases use the same style for defconfig
> fragments:
> - start after a backslash;
> - be declared as a multi-line string literal;
> - be indented one level more than the variable that contains it.
>
> Do the same here for consistency.
>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Matt Weber <matthew.weber@rockwellcollins.com>
Reviewed-by: Matt Weber <matthew.weber@rockwellcollins.com>
> ---
> support/testing/tests/package/test_rust.py | 78 +++++++++++-----------
> 1 file changed, 39 insertions(+), 39 deletions(-)
>
> diff --git a/support/testing/tests/package/test_rust.py b/support/testing/tests/package/test_rust.py
> index 2dc814f99d..9854c3692e 100644
> --- a/support/testing/tests/package/test_rust.py
> +++ b/support/testing/tests/package/test_rust.py
> @@ -57,25 +57,25 @@ class TestRustBase(infra.basetest.BRTest):
>
> class TestRustBin(TestRustBase):
> config = \
> - """
> - BR2_arm=y
> - BR2_cortex_a9=y
> - BR2_ARM_ENABLE_NEON=y
> - BR2_ARM_ENABLE_VFP=y
> - BR2_TOOLCHAIN_EXTERNAL=y
> - BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
> - BR2_SYSTEM_DHCP="eth0"
> - BR2_LINUX_KERNEL=y
> - BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> - BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.11.3"
> - BR2_LINUX_KERNEL_DEFCONFIG="vexpress"
> - BR2_LINUX_KERNEL_DTS_SUPPORT=y
> - BR2_LINUX_KERNEL_INTREE_DTS_NAME="vexpress-v2p-ca9"
> - BR2_TARGET_ROOTFS_CPIO=y
> - # BR2_TARGET_ROOTFS_TAR is not set
> - BR2_PACKAGE_HOST_CARGO=y
> - BR2_PACKAGE_HOST_RUSTC=y
> - """
> + """
> + BR2_arm=y
> + BR2_cortex_a9=y
> + BR2_ARM_ENABLE_NEON=y
> + BR2_ARM_ENABLE_VFP=y
> + BR2_TOOLCHAIN_EXTERNAL=y
> + BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
> + BR2_SYSTEM_DHCP="eth0"
> + BR2_LINUX_KERNEL=y
> + BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> + BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.11.3"
> + BR2_LINUX_KERNEL_DEFCONFIG="vexpress"
> + BR2_LINUX_KERNEL_DTS_SUPPORT=y
> + BR2_LINUX_KERNEL_INTREE_DTS_NAME="vexpress-v2p-ca9"
> + BR2_TARGET_ROOTFS_CPIO=y
> + # BR2_TARGET_ROOTFS_TAR is not set
> + BR2_PACKAGE_HOST_CARGO=y
> + BR2_PACKAGE_HOST_RUSTC=y
> + """
>
> def test_run(self):
> self.build_test_prog()
> @@ -86,26 +86,26 @@ class TestRustBin(TestRustBase):
>
> class TestRust(TestRustBase):
> config = \
> - """
> - BR2_arm=y
> - BR2_cortex_a9=y
> - BR2_ARM_ENABLE_NEON=y
> - BR2_ARM_ENABLE_VFP=y
> - BR2_TOOLCHAIN_EXTERNAL=y
> - BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
> - BR2_SYSTEM_DHCP="eth0"
> - BR2_LINUX_KERNEL=y
> - BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> - BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.11.3"
> - BR2_LINUX_KERNEL_DEFCONFIG="vexpress"
> - BR2_LINUX_KERNEL_DTS_SUPPORT=y
> - BR2_LINUX_KERNEL_INTREE_DTS_NAME="vexpress-v2p-ca9"
> - BR2_TARGET_ROOTFS_CPIO=y
> - # BR2_TARGET_ROOTFS_TAR is not set
> - BR2_PACKAGE_HOST_CARGO=y
> - BR2_PACKAGE_HOST_RUSTC=y
> - BR2_PACKAGE_HOST_RUST=y
> - """
> + """
> + BR2_arm=y
> + BR2_cortex_a9=y
> + BR2_ARM_ENABLE_NEON=y
> + BR2_ARM_ENABLE_VFP=y
> + BR2_TOOLCHAIN_EXTERNAL=y
> + BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
> + BR2_SYSTEM_DHCP="eth0"
> + BR2_LINUX_KERNEL=y
> + BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> + BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.11.3"
> + BR2_LINUX_KERNEL_DEFCONFIG="vexpress"
> + BR2_LINUX_KERNEL_DTS_SUPPORT=y
> + BR2_LINUX_KERNEL_INTREE_DTS_NAME="vexpress-v2p-ca9"
> + BR2_TARGET_ROOTFS_CPIO=y
> + # BR2_TARGET_ROOTFS_TAR is not set
> + BR2_PACKAGE_HOST_CARGO=y
> + BR2_PACKAGE_HOST_RUSTC=y
> + BR2_PACKAGE_HOST_RUST=y
> + """
>
> def test_run(self):
> self.build_test_prog()
> --
> 2.17.1
>
--
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / RC Linux Secure Platforms
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
www.rockwellcollins.com
Note: Any Export License Required Information and License Restricted
Third Party Intellectual Property (TPIP) content must be encrypted and
sent to matthew.weber at corp.rockwellcollins.com.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [next] test_rust: use standard defconfig fragment style
2018-11-16 22:21 [Buildroot] [next] test_rust: use standard defconfig fragment style Ricardo Martincoski
2018-11-17 1:19 ` Matthew Weber
@ 2018-11-20 8:01 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-11-20 8:01 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 16 Nov 2018 20:21:47 -0200, Ricardo Martincoski wrote:
> Since commit "2927f412be support/testing: standardize defconfig
> fragments style" all other test cases use the same style for defconfig
> fragments:
> - start after a backslash;
> - be declared as a multi-line string literal;
> - be indented one level more than the variable that contains it.
>
> Do the same here for consistency.
>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Matt Weber <matthew.weber@rockwellcollins.com>
> ---
> support/testing/tests/package/test_rust.py | 78 +++++++++++-----------
> 1 file changed, 39 insertions(+), 39 deletions(-)
Applied to next, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-20 8:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-16 22:21 [Buildroot] [next] test_rust: use standard defconfig fragment style Ricardo Martincoski
2018-11-17 1:19 ` Matthew Weber
2018-11-20 8:01 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox