[Buildroot] [PATCH 1/1] mtd: fix build on riscv

[Buildroot] [PATCH 1/1] mtd: fix build on riscv

[Fabrice Fontaine]

Define _REENTRANT otherwise pthread detection will fail

Fixes:
 - http://autobuild.buildroot.org/results/b0e7978a997a2aae383161455b5d898b8c28e2e1

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/mtd/mtd.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk
index 13e501fc33..2d627ffa3d 100644
--- a/package/mtd/mtd.mk
+++ b/package/mtd/mtd.mk
@@ -11,6 +11,13 @@ MTD_LICENSE = GPL-2.0
 MTD_LICENSE_FILES = COPYING
 MTD_INSTALL_STAGING = YES
 
+# gcc on riscv doesn't define _REENTRANT when -pthread is passed while
+# it should. Compensate this deficiency here otherwise mtd configure
+# script doesn't find that thread support is enabled.
+ifeq ($(BR2_TOOLCHAIN_HAS_THREADS):$(BR2_riscv),y:y)
+MTD_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D_REENTRANT"
+endif
+
 ifeq ($(BR2_PACKAGE_MTD_JFFS_UTILS),y)
 MTD_DEPENDENCIES += zlib lzo host-pkgconf
 MTD_CONF_OPTS += --with-jffs
-- 
2.14.1

[Buildroot] [PATCH 1/1] mtd: fix build on riscv

[Arnout Vandecappelle]

On 20/11/2018 19:52, Fabrice Fontaine wrote:
> Define _REENTRANT otherwise pthread detection will fail
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/b0e7978a997a2aae383161455b5d898b8c28e2e1
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/mtd/mtd.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk
> index 13e501fc33..2d627ffa3d 100644
> --- a/package/mtd/mtd.mk
> +++ b/package/mtd/mtd.mk
> @@ -11,6 +11,13 @@ MTD_LICENSE = GPL-2.0
>  MTD_LICENSE_FILES = COPYING
>  MTD_INSTALL_STAGING = YES
>  
> +# gcc on riscv doesn't define _REENTRANT when -pthread is passed while
> +# it should. Compensate this deficiency here otherwise mtd configure
> +# script doesn't find that thread support is enabled.
> +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS):$(BR2_riscv),y:y)
> +MTD_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D_REENTRANT"

 Patching gcc sounds more and more attractive...

 Regards,
 Arnout

> +endif
> +
>  ifeq ($(BR2_PACKAGE_MTD_JFFS_UTILS),y)
>  MTD_DEPENDENCIES += zlib lzo host-pkgconf
>  MTD_CONF_OPTS += --with-jffs
> 

[Buildroot] [PATCH 1/1] mtd: fix build on riscv

[Thomas Petazzoni]

Hello,

On Wed, 21 Nov 2018 00:34:30 +0100, Arnout Vandecappelle wrote:

> > +# gcc on riscv doesn't define _REENTRANT when -pthread is passed while
> > +# it should. Compensate this deficiency here otherwise mtd configure
> > +# script doesn't find that thread support is enabled.
> > +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS):$(BR2_riscv),y:y)
> > +MTD_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D_REENTRANT"  
> 
>  Patching gcc sounds more and more attractive...

Yes, definitely. We should do that.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] mtd: fix build on riscv

[Thomas Petazzoni]

Hello,

On Tue, 20 Nov 2018 19:52:37 +0100, Fabrice Fontaine wrote:
> Define _REENTRANT otherwise pthread detection will fail
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/b0e7978a997a2aae383161455b5d898b8c28e2e1
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/mtd/mtd.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com