[Buildroot] [PATCH 1/2] dante: disable pam

[Buildroot] [PATCH 1/2] dante: disable pam

[Fabrice Fontaine]

Fixes:
 - http://autobuild.buildroot.org/results/5222592f2052e18c184fae42214c112e7f39be6e

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/dante/dante.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/dante/dante.mk b/package/dante/dante.mk
index 687567e100..a147aa36dc 100644
--- a/package/dante/dante.mk
+++ b/package/dante/dante.mk
@@ -12,7 +12,7 @@ DANTE_LICENSE_FILES = LICENSE
 # Dante uses a *VERY* old configure.ac
 DANTE_LIBTOOL_PATCH = NO
 
-DANTE_CONF_OPTS += --disable-client --disable-preload
+DANTE_CONF_OPTS += --disable-client --disable-preload --without-pam
 
 define DANTE_INSTALL_CONFIG_FILE
 	$(INSTALL) -D -m 644 $(@D)/example/sockd.conf \
-- 
2.14.1

[Buildroot] [PATCH/next 2/2] dante: add linux-pam optional dependency

[Fabrice Fontaine]

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/dante/dante.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/package/dante/dante.mk b/package/dante/dante.mk
index a147aa36dc..9666ec54fd 100644
--- a/package/dante/dante.mk
+++ b/package/dante/dante.mk
@@ -12,7 +12,14 @@ DANTE_LICENSE_FILES = LICENSE
 # Dante uses a *VERY* old configure.ac
 DANTE_LIBTOOL_PATCH = NO
 
-DANTE_CONF_OPTS += --disable-client --disable-preload --without-pam
+DANTE_CONF_OPTS += --disable-client --disable-preload
+
+ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
+DANTE_DEPENDENCIES += linux-pam
+DANTE_CONF_OPTS += --with-pam
+else
+DANTE_CONF_OPTS += --without-pam
+endif
 
 define DANTE_INSTALL_CONFIG_FILE
 	$(INSTALL) -D -m 644 $(@D)/example/sockd.conf \
-- 
2.14.1

[Buildroot] [PATCH 1/2] dante: disable pam

[Thomas Petazzoni]

Hello,

On Thu, 22 Nov 2018 18:49:13 +0100, Fabrice Fontaine wrote:
> Fixes:
>  - http://autobuild.buildroot.org/results/5222592f2052e18c184fae42214c112e7f39be6e
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/dante/dante.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH/next 2/2] dante: add linux-pam optional dependency

[Thomas Petazzoni]

Hello,

On Thu, 22 Nov 2018 18:49:14 +0100, Fabrice Fontaine wrote:
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/dante/dante.mk | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)

Applied to next after cherry-picking PATCH 1/2 from master to next.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/2] dante: disable pam

[Thomas Petazzoni]

Hello Fabrice,

On Thu, 22 Nov 2018 18:49:13 +0100, Fabrice Fontaine wrote:
> Fixes:
>  - http://autobuild.buildroot.org/results/5222592f2052e18c184fae42214c112e7f39be6e

It seems like it doesn't fix the problem. The following build result:

  http://autobuild.buildroot.net/results/e37e61bae1d81a7956e2843be70fea84b0bbb64b/

has been built from the master branch at commit
d81870ae8129389a62df80c9c8c9165d334b6921, which includes your fix, and
still the same libpam related failure happened.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/2] dante: disable pam

[Fabrice Fontaine]

Dear Thomas,

Le lun. 26 nov. 2018 ? 08:49, Thomas Petazzoni <thomas.petazzoni@bootlin.com>
a ?crit :

> Hello Fabrice,
>
> On Thu, 22 Nov 2018 18:49:13 +0100, Fabrice Fontaine wrote:
> > Fixes:
> >  -
> http://autobuild.buildroot.org/results/5222592f2052e18c184fae42214c112e7f39be6e
>
> It seems like it doesn't fix the problem. The following build result:
>
>
> http://autobuild.buildroot.net/results/e37e61bae1d81a7956e2843be70fea84b0bbb64b/
>
> has been built from the master branch at commit
> d81870ae8129389a62df80c9c8c9165d334b6921, which includes your fix, and
> still the same libpam related failure happened.
>
Yes, I saw it.I have an other patch to fix this issue in one of the dante's
m4 file but Yann's patch on autoreconf must be applied first.

>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Best Regards,

Fabrice

>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181126/f2b8627b/attachment.html>

[Buildroot] [PATCH 1/2] dante: disable pam

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fixes:
 >  - http://autobuild.buildroot.org/results/5222592f2052e18c184fae42214c112e7f39be6e

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2018.02.x and 2018.08.x, thanks.

-- 
Bye, Peter Korsgaard