* [Buildroot] [PATCH 1/1] botan: fix install directory
@ 2018-11-23 14:27 DUPONCHEEL Sébastien
2018-11-23 14:50 ` Thomas Petazzoni
2018-11-23 20:48 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: DUPONCHEEL Sébastien @ 2018-11-23 14:27 UTC (permalink / raw)
To: buildroot
Signed-off-by: DUPONCHEEL S?bastien <sebastien.duponcheel@corp.ovh.com>
---
package/botan/botan.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/botan/botan.mk b/package/botan/botan.mk
index 7f0bbb6..e07b786 100644
--- a/package/botan/botan.mk
+++ b/package/botan/botan.mk
@@ -92,11 +92,11 @@ define BOTAN_BUILD_CMDS
endef
define BOTAN_INSTALL_STAGING_CMDS
- $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(STAGING_DIR)/usr" install
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(STAGING_DIR)" install
endef
define BOTAN_INSTALL_TARGET_CMDS
- $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)/usr" install
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(TARGET_DIR)" install
endef
$(eval $(generic-package))
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] botan: fix install directory
2018-11-23 14:27 [Buildroot] [PATCH 1/1] botan: fix install directory DUPONCHEEL Sébastien
@ 2018-11-23 14:50 ` Thomas Petazzoni
2018-11-23 14:54 ` DUPONCHEEL Sébastien
2018-11-23 20:48 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2018-11-23 14:50 UTC (permalink / raw)
To: buildroot
Hello,
Thanks for your contribution!
On Fri, 23 Nov 2018 15:27:39 +0100, DUPONCHEEL S?bastien wrote:
> Signed-off-by: DUPONCHEEL S?bastien <sebastien.duponcheel@corp.ovh.com>
It would be nice to have a bit more details in the commit log here, so
that we understand exactly what it is fixing, and whether this fix
should be pushed to the master branch or the next branch.
Is it that with the current DESTDIR value, botan gets installed in
STAGING_DIR/usr/usr ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] botan: fix install directory
2018-11-23 14:50 ` Thomas Petazzoni
@ 2018-11-23 14:54 ` DUPONCHEEL Sébastien
0 siblings, 0 replies; 4+ messages in thread
From: DUPONCHEEL Sébastien @ 2018-11-23 14:54 UTC (permalink / raw)
To: buildroot
Hi thomas,
Yes that is.
While i was working on a kea-dhcp package that depends on botan.
I see something weird with the botan install directory.
Before my patch :
output/target/usr/usr/lib/libbotan-2.so
output/target/usr/usr/lib/pkgconfig/botan-2.pc
output/target/usr/usr/lib/python2.7/site-packages/botan2.py
output/target/usr/usr/lib/libbotan-2.so.8.8.0
output/target/usr/usr/lib/libbotan-2.so.8
output/target/usr/usr/bin/botan
After my patch :
./output/target/usr/lib/libbotan-2.so
./output/target/usr/lib/python2.7/site-packages/botan2.py
./output/target/usr/lib/libbotan-2.so.8.8.0
./output/target/usr/lib/libbotan-2.so.8
./output/target/usr/bin/botan
Best regards,
DUPONCHEEL S?bastien
Le 23/11/2018 ? 15:50, Thomas Petazzoni a ?crit?:
> Hello,
>
> Thanks for your contribution!
>
> On Fri, 23 Nov 2018 15:27:39 +0100, DUPONCHEEL S?bastien wrote:
>> Signed-off-by: DUPONCHEEL S?bastien <sebastien.duponcheel@corp.ovh.com>
> It would be nice to have a bit more details in the commit log here, so
> that we understand exactly what it is fixing, and whether this fix
> should be pushed to the master branch or the next branch.
>
> Is it that with the current DESTDIR value, botan gets installed in
> STAGING_DIR/usr/usr ?
>
> Thanks,
>
> Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] botan: fix install directory
2018-11-23 14:27 [Buildroot] [PATCH 1/1] botan: fix install directory DUPONCHEEL Sébastien
2018-11-23 14:50 ` Thomas Petazzoni
@ 2018-11-23 20:48 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-11-23 20:48 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 23 Nov 2018 15:27:39 +0100, DUPONCHEEL S?bastien wrote:
> Signed-off-by: DUPONCHEEL S?bastien <sebastien.duponcheel@corp.ovh.com>
> ---
> package/botan/botan.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master with an extended commit log. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-23 20:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-23 14:27 [Buildroot] [PATCH 1/1] botan: fix install directory DUPONCHEEL Sébastien
2018-11-23 14:50 ` Thomas Petazzoni
2018-11-23 14:54 ` DUPONCHEEL Sébastien
2018-11-23 20:48 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox