[Buildroot] [PATCH 0/2] package/qt5base: disable for toolchains with binutils bug 20765 (branch yem/fixes)

[Buildroot] [PATCH 0/2] package/qt5base: disable for toolchains with binutils bug 20765 (branch yem/fixes)

[Yann E. MORIN]

Hello All!

This two-patch series is a porposal to disable the build of qt5 for
those toolchains that have binutils bug 20765.

Regards,
Yann E. MORIN.


The following changes since commit ba015cdf04a2ee33615f346448ac2e92aac3865a

  package/pkg-generic: use readlink instead of realpath (2018-12-02 11:22:11 +0100)


are available in the git repository at:

  git://git.buildroot.org/~ymorin/git/buildroot.git

for you to fetch changes up to acc8229480af3087d4df4da9b306ddc8e76be1ef

  package/qt5: hide for toolchains with binutils bug 20765 (2018-12-02 14:49:24 +0100)


----------------------------------------------------------------
Yann E. MORIN (2):
      toolchain: add binutils bug 20765 to linaro Aarch64be
      package/qt5: hide for toolchains with binutils bug 20765

 package/pinentry/Config.in                                           | 1 +
 package/qt5/Config.in                                                | 1 +
 toolchain/Config.in                                                  | 5 +++++
 .../toolchain-external-linaro-aarch64-be/Config.in                   | 1 +
 4 files changed, 8 insertions(+)

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/2] toolchain: add binutils bug 20765 to linaro Aarch64be

[Yann E. MORIN]

This bug has been fixed on the 2.29 branch, but not 2.29 release has
been made since then, so consider only 2.30 to have the fix from our
point of view.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 toolchain/Config.in                                                  | 5 +++++
 .../toolchain-external-linaro-aarch64-be/Config.in                   | 1 +
 2 files changed, 6 insertions(+)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index bf8ed5bf5b..e6c0e51bcd 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -74,6 +74,11 @@ config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_19615
 config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_20006
 	bool
 
+# https://sourceware.org/bugzilla/show_bug.cgi?id=20765
+# Affect toolchains built with binutils 2.26..2.29 (fixed in binutils 2.30).
+config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_20765
+	bool
+
 # Atomic types can be:
 #  - never lock-free
 #  - sometimes lock-free
diff --git a/toolchain/toolchain-external/toolchain-external-linaro-aarch64-be/Config.in b/toolchain/toolchain-external/toolchain-external-linaro-aarch64-be/Config.in
index 9e7d2a6233..72d33140da 100644
--- a/toolchain/toolchain-external/toolchain-external-linaro-aarch64-be/Config.in
+++ b/toolchain/toolchain-external/toolchain-external-linaro-aarch64-be/Config.in
@@ -10,6 +10,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_BE
 	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_10
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_7
 	select BR2_TOOLCHAIN_HAS_FORTRAN
+	select BR2_TOOLCHAIN_HAS_BINUTILS_BUG_20765
 	help
 	  Toolchain for the AArch64 Big Endian architecture, from
 	  http://www.linaro.org/engineering/armv8/
-- 
2.14.1

[Buildroot] [PATCH 2/2] package/qt5: hide for toolchains with binutils bug 20765

[Yann E. MORIN]

Fixes:
    http://autobuild.buildroot.org/results/5b9/5b9ef3c4bc5640b1c7e38a941e343fba75bf4742/
    http://autobuild.buildroot.org/results/df0/df0dab779213cf1ec3e511360bcc84f8856576b2/
    [...]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/pinentry/Config.in | 1 +
 package/qt5/Config.in      | 1 +
 2 files changed, 2 insertions(+)

diff --git a/package/pinentry/Config.in b/package/pinentry/Config.in
index 5f2cb58fbb..97702f032f 100644
--- a/package/pinentry/Config.in
+++ b/package/pinentry/Config.in
@@ -64,6 +64,7 @@ config BR2_PACKAGE_PINENTRY_QT5
 	depends on !BR2_STATIC_LIBS
 	depends on !BR2_PACKAGE_PINENTRY_QT4
 	depends on !BR2_PACKAGE_QT
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_20765 # qt5
 	select BR2_PACKAGE_QT5
 	select BR2_PACKAGE_QT5BASE_GUI
 	select BR2_PACKAGE_QT5BASE_WIDGETS
diff --git a/package/qt5/Config.in b/package/qt5/Config.in
index 735824402e..f1436deff0 100644
--- a/package/qt5/Config.in
+++ b/package/qt5/Config.in
@@ -22,6 +22,7 @@ menuconfig BR2_PACKAGE_QT5
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on !BR2_STATIC_LIBS
 	depends on !BR2_PACKAGE_QT
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_20765
 	select BR2_PACKAGE_QT5BASE
 	help
 	  This option enables the Qt5 framework. Sub-options allow to
-- 
2.14.1

[Buildroot] [PATCH 1/2] toolchain: add binutils bug 20765 to linaro Aarch64be

[Thomas Petazzoni]

Hello,

On Sun,  2 Dec 2018 15:04:16 +0100, Yann E. MORIN wrote:

> diff --git a/toolchain/toolchain-external/toolchain-external-linaro-aarch64-be/Config.in b/toolchain/toolchain-external/toolchain-external-linaro-aarch64-be/Config.in
> index 9e7d2a6233..72d33140da 100644
> --- a/toolchain/toolchain-external/toolchain-external-linaro-aarch64-be/Config.in
> +++ b/toolchain/toolchain-external/toolchain-external-linaro-aarch64-be/Config.in
> @@ -10,6 +10,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_BE
>  	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_10
>  	select BR2_TOOLCHAIN_GCC_AT_LEAST_7
>  	select BR2_TOOLCHAIN_HAS_FORTRAN
> +	select BR2_TOOLCHAIN_HAS_BINUTILS_BUG_20765

Any idea why the aarch64-be toolchain is affected, but not the aarch64
toolchain ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/2] toolchain: add binutils bug 20765 to linaro Aarch64be

[Yann E. MORIN]

Thomas, All,

On 2018-12-02 17:27 +0100, Thomas Petazzoni spake thusly:
> On Sun,  2 Dec 2018 15:04:16 +0100, Yann E. MORIN wrote:
> > diff --git a/toolchain/toolchain-external/toolchain-external-linaro-aarch64-be/Config.in b/toolchain/toolchain-external/toolchain-external-linaro-aarch64-be/Config.in
> > index 9e7d2a6233..72d33140da 100644
> > --- a/toolchain/toolchain-external/toolchain-external-linaro-aarch64-be/Config.in
> > +++ b/toolchain/toolchain-external/toolchain-external-linaro-aarch64-be/Config.in
> > @@ -10,6 +10,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_BE
> >  	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_10
> >  	select BR2_TOOLCHAIN_GCC_AT_LEAST_7
> >  	select BR2_TOOLCHAIN_HAS_FORTRAN
> > +	select BR2_TOOLCHAIN_HAS_BINUTILS_BUG_20765
> Any idea why the aarch64-be toolchain is affected, but not the aarch64
> toolchain ?

I was expecting that question, so I did my homework first, to get ready
to answer it:

    I have no clue about that.

There, that was all I could dig up as a reason. ;-)

But more seriously, I think I'll take that patch back, because the
uopstream BZ is about aarch64, not aarch64be...

Regards,
Yann E. MORIN.

> Thanks,
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'