Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libbsd: fix display of comment
Date: Mon, 3 Dec 2018 09:14:35 +0100	[thread overview]
Message-ID: <20181203091435.2fc5051a@windsurf.home> (raw)
In-Reply-To: <20181202102551.18249-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Sun,  2 Dec 2018 11:25:51 +0100, Fabrice Fontaine wrote:
> Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added
> depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
> to display the comment "libbsd needs a toolchain w/ threads, wchar"
> 
> Set the correct dependency:
> depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Instead of this (and the related minizip change), what about moving the:

	depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)

to BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS ?

Since we don't display a comment about it, it is effectively treated
like an architecture dependency, and it kind of is, since anyway the
only C library that supports noMMU systems is uClibc (yes, musl
supports noMMU on SH2, but we don't support that in Buildroot).

Having this dependency directly in BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
avoid the need to replicate it to all reverse dependencies of libbsd
(and therefore the reverse dependencies should be changed as well).

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-12-03  8:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-02 10:25 [Buildroot] [PATCH 1/1] libbsd: fix display of comment Fabrice Fontaine
2018-12-03  8:14 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181203091435.2fc5051a@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox