[Buildroot] [PATCH 1/1] libbsd: fix display of comment

[Buildroot] [PATCH 1/1] libbsd: fix display of comment

[Fabrice Fontaine]

Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added
depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
to display the comment "libbsd needs a toolchain w/ threads, wchar"

Set the correct dependency:
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libbsd/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libbsd/Config.in b/package/libbsd/Config.in
index ba5e5cbcfa..ce50ec37de 100644
--- a/package/libbsd/Config.in
+++ b/package/libbsd/Config.in
@@ -24,5 +24,5 @@ config BR2_PACKAGE_LIBBSD
 
 comment "libbsd needs a toolchain w/ threads, wchar"
 	depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
-	depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
+	depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
-- 
2.17.1

[Buildroot] [PATCH 1/1] libbsd: fix display of comment

[Thomas Petazzoni]

Hello Fabrice,

On Sun,  2 Dec 2018 11:25:51 +0100, Fabrice Fontaine wrote:
> Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added
> depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
> to display the comment "libbsd needs a toolchain w/ threads, wchar"
> 
> Set the correct dependency:
> depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Instead of this (and the related minizip change), what about moving the:

	depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)

to BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS ?

Since we don't display a comment about it, it is effectively treated
like an architecture dependency, and it kind of is, since anyway the
only C library that supports noMMU systems is uClibc (yes, musl
supports noMMU on SH2, but we don't support that in Buildroot).

Having this dependency directly in BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
avoid the need to replicate it to all reverse dependencies of libbsd
(and therefore the reverse dependencies should be changed as well).

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com