Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] Submodule granularity instead of LIB_GIT_SUBMODULES
Date: Thu, 6 Dec 2018 09:32:45 +0100	[thread overview]
Message-ID: <20181206083245.GC2561@scaer> (raw)
In-Reply-To: <8f33142c-71ad-24c6-bad4-deea26f05ce6@mind.be>

Arnout, All,

On 2018-12-03 17:40 +0100, Arnout Vandecappelle spake thusly:
> On 28/11/2018 16:28, lpdev at cordier.org wrote:
> > I have a repository that have few submodules:
> > - myLib
> > ? -> submodule1 (~10MB)
> > ? -> submodule2 (8GB)
> > 
> > Actually I don't need to initialize submodule2 because myLib does not request it
> > while compiling for my buildroot distro.
> > 
> > The option xxx_GIT_SUBMODULES is doing a recursive init on all submodules of the
> > project. As I am using Buildroot 2018.02, there is no support for the latest git
> > patches that improve the overall space overhead and avoid compressing the repo.
> > 
> > Each time I am updating the git hash of my package, buildroot is cloning the
> > repo, getting the subodules (from scratch), compress tar it, and then start the
> > compilation. I was wondering if there is a way to specify _GIT_SUBMODULES to no,
> > but still get the submodule1, without breaking buildroot's download philosophy.
> 
>  No, there's no simple way to do that. And adding the infrastructure to do that
> would lead us way too far.

Actually, it would be rather easy, as 'git submodule init' accepts a
list of paths to initialise (it has accepted that since submodules were
introduced in 2007).

See (totally untested):
    https://git.buildroot.org/~ymorin/git/buildroot/commit/?h=yem/git-submodules&id=6a4f7c504e04dfe8dd6d5f8540a6cbc81e3758ae

Arnout, like you, I am not sure we would want such a feature. However,
I don't have a strong opinion against it either, as it's pretty easy to
do...

If you really believe we should not have it, then I'll drop my patch.
Otherwise, if you think it's worth pursuing, I'll refine it before
properly submitting it.

Regards,
Yann E. MORIN.

>  However, what you can do is to leave _GIT_SUBMODULES to NO, add submodule1 as
> <PKG>_EXTRA_DOWNLOADS and extract it in a <PKG>_POST_EXTRACT_HOOK.  This does
> mean you have to manually
> 
>  Unfortunately, I'm not sure if it is possible to use the git download method
> for extra downloads. You can add git+ in front of the URL, but I don't think
> there's a way to specify the ref to check out... So perhaps you'll instead have
> to define a post-download hook that calls dl-wrapper directly...
> 
>  Regards,
>  Arnout
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2018-12-06  8:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 15:28 [Buildroot] Submodule granularity instead of LIB_GIT_SUBMODULES lpdev at cordier.org
2018-12-03 16:40 ` Arnout Vandecappelle
2018-12-04 22:51   ` LP C
2018-12-06  8:32   ` Yann E. MORIN [this message]
2018-12-07 20:53     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181206083245.GC2561@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox