Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] Submodule granularity instead of LIB_GIT_SUBMODULES
Date: Fri, 7 Dec 2018 21:53:53 +0100	[thread overview]
Message-ID: <20181207205353.GK2561@scaer> (raw)
In-Reply-To: <20181206083245.GC2561@scaer>

Louis-Paul, Arnout, All,

On 2018-12-06 09:32 +0100, Yann E. MORIN spake thusly:
> On 2018-12-03 17:40 +0100, Arnout Vandecappelle spake thusly:
> > On 28/11/2018 16:28, lpdev at cordier.org wrote:
> > > compilation. I was wondering if there is a way to specify _GIT_SUBMODULES to no,
> > > but still get the submodule1, without breaking buildroot's download philosophy.
> >  No, there's no simple way to do that. And adding the infrastructure to do that
> > would lead us way too far.
> Actually, it would be rather easy, as 'git submodule init' accepts a
> list of paths to initialise (it has accepted that since submodules were
> introduced in 2007).
> See (totally untested):
>     https://git.buildroot.org/~ymorin/git/buildroot/commit/?h=yem/git-submodules&id=6a4f7c504e04dfe8dd6d5f8540a6cbc81e3758ae
> Arnout, like you, I am not sure we would want such a feature. However,
> I don't have a strong opinion against it either, as it's pretty easy to
> do...

Well, I take that back. It is not easy, in fact.

My proposal only accounts for first-level submodules, and doers not
works for sub-submodules and below. Handling them would not be trivial.

So, I side with Arnout: we can't support that, as that would lead us way
too far, especially since our git wrapper is already complex...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2018-12-07 20:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 15:28 [Buildroot] Submodule granularity instead of LIB_GIT_SUBMODULES lpdev at cordier.org
2018-12-03 16:40 ` Arnout Vandecappelle
2018-12-04 22:51   ` LP C
2018-12-06  8:32   ` Yann E. MORIN
2018-12-07 20:53     ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181207205353.GK2561@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox