[Buildroot] [PATCH] package/libiscsi: fix build due to warnings

[Buildroot] [PATCH] package/libiscsi: fix build due to warnings

[Yann E. MORIN]

Fixes:
    http://autobuild.buildroot.org/results/55b/55bf50fc7dcd465b71b5757434887dd3d0b25abc/
    http://autobuild.buildroot.org/results/98d/98dcfe5c9fc3babd5c8d3116d5128d437715c44e/

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/libiscsi/libiscsi.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/libiscsi/libiscsi.mk b/package/libiscsi/libiscsi.mk
index 6c8600829c..c492865c51 100644
--- a/package/libiscsi/libiscsi.mk
+++ b/package/libiscsi/libiscsi.mk
@@ -11,6 +11,8 @@ LIBISCSI_LICENSE_FILES = COPYING LICENCE-GPL-2.txt LICENCE-LGPL-2.1.txt
 LIBISCSI_INSTALL_STAGING = YES
 LIBISCSI_AUTORECONF = YES
 
+LIBISCSI_CONF_OPTS = --disable-werror
+
 # We need to create the m4 directory to make autoreconf work properly.
 define LIBISCSI_CREATE_M4_DIR
 	mkdir -p $(@D)/m4
-- 
2.14.1

[Buildroot] [PATCH] package/libiscsi: do not built the manpages

[Yann E. MORIN]

The pre-rendered, bundled ones are still installed, though, but they
get removed in target-finalize anyway.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/libiscsi/libiscsi.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libiscsi/libiscsi.mk b/package/libiscsi/libiscsi.mk
index c492865c51..a34069d7bf 100644
--- a/package/libiscsi/libiscsi.mk
+++ b/package/libiscsi/libiscsi.mk
@@ -11,7 +11,7 @@ LIBISCSI_LICENSE_FILES = COPYING LICENCE-GPL-2.txt LICENCE-LGPL-2.1.txt
 LIBISCSI_INSTALL_STAGING = YES
 LIBISCSI_AUTORECONF = YES
 
-LIBISCSI_CONF_OPTS = --disable-werror
+LIBISCSI_CONF_OPTS = --disable-werror --disable-manpages
 
 # We need to create the m4 directory to make autoreconf work properly.
 define LIBISCSI_CREATE_M4_DIR
-- 
2.14.1

[Buildroot] [PATCH] package/libiscsi: add optional dependency to cunit

[Yann E. MORIN]

libiscsi uses cunit for its test suite, and autodetexcts its presence.

Usually, we just try to disable tests altogether, but there is no way to
do so. So, ensure proper ordering.

Note: there is an ac_cv_have_cunit variable, but it is not a true
ac_cv* cache variable, and the value provided on the command line or
environment is properly ignored.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

---
Note: for the interesting parties, I've sent a bunch of enhacements to
the configure script upstream:
    https://github.com/sahlberg/libiscsi/pull/283
---
 package/libiscsi/libiscsi.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/libiscsi/libiscsi.mk b/package/libiscsi/libiscsi.mk
index a34069d7bf..2b26a1427c 100644
--- a/package/libiscsi/libiscsi.mk
+++ b/package/libiscsi/libiscsi.mk
@@ -11,6 +11,10 @@ LIBISCSI_LICENSE_FILES = COPYING LICENCE-GPL-2.txt LICENCE-LGPL-2.1.txt
 LIBISCSI_INSTALL_STAGING = YES
 LIBISCSI_AUTORECONF = YES
 
+ifeq ($(BR2_PACKAGE_CUNIT),y)
+LIBISCSI_DEPENDENCIES += cunit
+endif
+
 LIBISCSI_CONF_OPTS = --disable-werror --disable-manpages
 
 # We need to create the m4 directory to make autoreconf work properly.
-- 
2.14.1

[Buildroot] [PATCH] package/libiscsi: fix build due to warnings

[Thomas Petazzoni]

Hello,

On Tue,  4 Dec 2018 10:31:52 +0100, Yann E. MORIN wrote:
> Fixes:
>     http://autobuild.buildroot.org/results/55b/55bf50fc7dcd465b71b5757434887dd3d0b25abc/
>     http://autobuild.buildroot.org/results/98d/98dcfe5c9fc3babd5c8d3116d5128d437715c44e/
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  package/libiscsi/libiscsi.mk | 2 ++
>  1 file changed, 2 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] package/libiscsi: do not built the manpages

[Thomas Petazzoni]

Hello,

On Tue,  4 Dec 2018 10:57:12 +0100, Yann E. MORIN wrote:
> The pre-rendered, bundled ones are still installed, though, but they
> get removed in target-finalize anyway.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  package/libiscsi/libiscsi.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] package/libiscsi: add optional dependency to cunit

[Thomas Petazzoni]

Hello,

On Tue,  4 Dec 2018 11:25:00 +0100, Yann E. MORIN wrote:
> libiscsi uses cunit for its test suite, and autodetexcts its presence.
> 
> Usually, we just try to disable tests altogether, but there is no way to
> do so. So, ensure proper ordering.
> 
> Note: there is an ac_cv_have_cunit variable, but it is not a true
> ac_cv* cache variable, and the value provided on the command line or
> environment is properly ignored.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> ---
> Note: for the interesting parties, I've sent a bunch of enhacements to
> the configure script upstream:
>     https://github.com/sahlberg/libiscsi/pull/283
> ---
>  package/libiscsi/libiscsi.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] package/libiscsi: fix build due to warnings

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Fixes:
 >     http://autobuild.buildroot.org/results/55b/55bf50fc7dcd465b71b5757434887dd3d0b25abc/
 >     http://autobuild.buildroot.org/results/98d/98dcfe5c9fc3babd5c8d3116d5128d437715c44e/

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Committed to 2018.02.x, 2018.08.x and 2018.11.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] package/libiscsi: do not built the manpages

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > The pre-rendered, bundled ones are still installed, though, but they
 > get removed in target-finalize anyway.

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Committed to 2018.02.x, 2018.08.x and 2018.11.x, thanks.

-- 
Bye, Peter Korsgaard