* [Buildroot] [PATCH] scanpypi: import third party modules after the standard ones
@ 2018-12-07 9:40 yegorslists at googlemail.com
2018-12-09 15:51 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: yegorslists at googlemail.com @ 2018-12-07 9:40 UTC (permalink / raw)
To: buildroot
From: Yegor Yefremov <yegorslists@googlemail.com>
Move imports from six package after the standard modules. Resolves
pylint warnings.
---
utils/scanpypi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/utils/scanpypi b/utils/scanpypi
index 3d3e604435..9335bedee4 100755
--- a/utils/scanpypi
+++ b/utils/scanpypi
@@ -10,9 +10,6 @@ from __future__ import print_function
from __future__ import absolute_import
import argparse
import json
-import six.moves.urllib.request
-import six.moves.urllib.error
-import six.moves.urllib.parse
import sys
import os
import shutil
@@ -25,6 +22,9 @@ import textwrap
import tempfile
import imp
from functools import wraps
+import six.moves.urllib.request
+import six.moves.urllib.error
+import six.moves.urllib.parse
from six.moves import map
from six.moves import zip
from six.moves import input
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] scanpypi: import third party modules after the standard ones
2018-12-07 9:40 [Buildroot] [PATCH] scanpypi: import third party modules after the standard ones yegorslists at googlemail.com
@ 2018-12-09 15:51 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-12-09 15:51 UTC (permalink / raw)
To: buildroot
Hello Yegor,
On Fri, 7 Dec 2018 10:40:41 +0100, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> Move imports from six package after the standard modules. Resolves
> pylint warnings.
Thanks, but your SoB is missing here :-/
Also, when resending, you can adjust the commit title prefix to
utils/scanpypi.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-09 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-07 9:40 [Buildroot] [PATCH] scanpypi: import third party modules after the standard ones yegorslists at googlemail.com
2018-12-09 15:51 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox