Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] Building cargo with per-package directories
Date: Thu, 13 Dec 2018 21:04:59 +0100	[thread overview]
Message-ID: <20181213210459.78bc90ce@windsurf> (raw)
In-Reply-To: <20181212225041.GA15035@itchy>

Hello Eric,

On Wed, 12 Dec 2018 23:50:41 +0100, Eric Le Bihan wrote:

> The build ended as expected.
> 
> ```
>   = note: /usr/bin/ld: cannot find -lhttp_parser
>           collect2: error: ld returned 1 exit status
> ```
> 
> The library libhttp_parser.so is required by one of the dependencies of
> cargo: libgit2-sys, which provides the Rust interface to libgit2.
> 
> There is trick in vendor/libgit2-sys/build.rs to handle
> libhttp_parser.so: if the pkgconfig file of libgit2 contains -lhttp_parser,
> then pass it to rustc via "cargo:rustc-link-lib=http_parser".
> 
> See "Outputs of the Build Script" in Cargo Book [1] for details.
> 
> We want to use per-package/host-cargo/host/lib/libhttp_parser.so. Adding
> "-Clink-arg=-L$(HOST_DIR)/lib" to the RUSTFLAGS environment variable
> solves the issue on my system:
> 
> ```
> diff --git a/package/cargo/cargo.mk b/package/cargo/cargo.mk
> index 1b1053ba41..891901578e 100644
> --- a/package/cargo/cargo.mk
> +++ b/package/cargo/cargo.mk
> @@ -70,7 +70,7 @@ HOST_CARGO_SNAP_OPTS = \
>  	$(if $(VERBOSE),--verbose)
> 
>  HOST_CARGO_ENV = \
> -	RUSTFLAGS="-Clink-arg=-Wl,-rpath,$(HOST_DIR)/lib" \
> +	RUSTFLAGS="-Clink-arg=-Wl,-rpath,$(HOST_DIR)/lib -Clink-arg=-L$(HOST_DIR)/lib" \
>  	CARGO_HOME=$(HOST_CARGO_HOME)

Thanks a lot for this investigation and solution. I will definitely
have a look and see how it goes. Many, many thanks!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-12-13 20:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 16:12 [Buildroot] Building cargo with per-package directories Thomas Petazzoni
2018-12-11 21:27 ` Eric Le Bihan
2018-12-12 22:50   ` Eric Le Bihan
2018-12-13 20:04     ` Thomas Petazzoni [this message]
2018-12-26 14:49     ` Thomas Petazzoni
2018-12-27 20:50       ` Eric Le Bihan
2018-12-28  9:21         ` Thomas Petazzoni
2018-12-28 11:49           ` Eric Le Bihan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181213210459.78bc90ce@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox