From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] Building cargo with per-package directories
Date: Wed, 26 Dec 2018 15:49:59 +0100 [thread overview]
Message-ID: <20181226154959.6a793c8d@windsurf.home> (raw)
In-Reply-To: <20181212225041.GA15035@itchy>
Hello Eric,
On Wed, 12 Dec 2018 23:50:41 +0100, Eric Le Bihan wrote:
> diff --git a/package/cargo/cargo.mk b/package/cargo/cargo.mk
> index 1b1053ba41..891901578e 100644
> --- a/package/cargo/cargo.mk
> +++ b/package/cargo/cargo.mk
> @@ -70,7 +70,7 @@ HOST_CARGO_SNAP_OPTS = \
> $(if $(VERBOSE),--verbose)
>
> HOST_CARGO_ENV = \
> - RUSTFLAGS="-Clink-arg=-Wl,-rpath,$(HOST_DIR)/lib" \
> + RUSTFLAGS="-Clink-arg=-Wl,-rpath,$(HOST_DIR)/lib -Clink-arg=-L$(HOST_DIR)/lib" \
> CARGO_HOME=$(HOST_CARGO_HOME)
>
> define HOST_CARGO_BUILD_CMDS
> ```
>
> [1] https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script
Thanks a lot, I was finally able to test this, and confirm it works
fine.
I propose to change it to:
RUSTFLAGS="$(addprefix -Clink-arg=,$(HOST_LDFLAGS))"
so that if we ever change HOST_LDFLAGS in the future, it will continue
to work. What do you think ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-12-26 14:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 16:12 [Buildroot] Building cargo with per-package directories Thomas Petazzoni
2018-12-11 21:27 ` Eric Le Bihan
2018-12-12 22:50 ` Eric Le Bihan
2018-12-13 20:04 ` Thomas Petazzoni
2018-12-26 14:49 ` Thomas Petazzoni [this message]
2018-12-27 20:50 ` Eric Le Bihan
2018-12-28 9:21 ` Thomas Petazzoni
2018-12-28 11:49 ` Eric Le Bihan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181226154959.6a793c8d@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox