* [Buildroot] [PATCH 1/1] acsccid: fix build with pkgconf 1.5.3
@ 2018-12-12 19:52 Fabrice Fontaine
2018-12-13 20:21 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2018-12-12 19:52 UTC (permalink / raw)
To: buildroot
Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute
paths found in the .pc file. This is correct when the paths refer to
something in STAGING_DIR (e.g. libdir, includedir), but not when it
refers to something used for the target.
acsccid uses the usbdropdir variable from libpcsclite.pc to decide where
to install things. Since DESTDIR is prepended to the install
destination, this will end up in the wrong location.
Until a better solution is found in pkgconf, pass the usbdropdir to use
explicitly instead of relying on libpcsclite.pc.
Fixes:
- http://autobuild.buildroot.org/results/9dc76478d81ea2469900a4b4aab0e31fee9c4032
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/acsccid/acsccid.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/acsccid/acsccid.mk b/package/acsccid/acsccid.mk
index 06a04185e2..a59a16d76f 100644
--- a/package/acsccid/acsccid.mk
+++ b/package/acsccid/acsccid.mk
@@ -11,5 +11,6 @@ ACSCCID_LICENSE = LGPL-2.1+
ACSCCID_LICENSE_FILES = COPYING
ACSCCID_INSTALL_STAGING = YES
ACSCCID_DEPENDENCIES = pcsc-lite host-flex host-pkgconf libusb
+ACSCCID_CONF_OPTS = --enable-usbdropdir=/usr/lib/pcsc/drivers
$(eval $(autotools-package))
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] acsccid: fix build with pkgconf 1.5.3
2018-12-12 19:52 [Buildroot] [PATCH 1/1] acsccid: fix build with pkgconf 1.5.3 Fabrice Fontaine
@ 2018-12-13 20:21 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-12-13 20:21 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 12 Dec 2018 20:52:56 +0100, Fabrice Fontaine wrote:
> Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute
> paths found in the .pc file. This is correct when the paths refer to
> something in STAGING_DIR (e.g. libdir, includedir), but not when it
> refers to something used for the target.
>
> acsccid uses the usbdropdir variable from libpcsclite.pc to decide where
> to install things. Since DESTDIR is prepended to the install
> destination, this will end up in the wrong location.
>
> Until a better solution is found in pkgconf, pass the usbdropdir to use
> explicitly instead of relying on libpcsclite.pc.
>
> Fixes:
> - http://autobuild.buildroot.org/results/9dc76478d81ea2469900a4b4aab0e31fee9c4032
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/acsccid/acsccid.mk | 1 +
> 1 file changed, 1 insertion(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-13 20:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-12 19:52 [Buildroot] [PATCH 1/1] acsccid: fix build with pkgconf 1.5.3 Fabrice Fontaine
2018-12-13 20:21 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox