* [Buildroot] [PATCH 1/1] iwd: fix dbus build with pkgconf 1.5.3
@ 2018-12-12 20:13 Fabrice Fontaine
2018-12-13 20:30 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2018-12-12 20:13 UTC (permalink / raw)
To: buildroot
Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute
paths found in the .pc file. This is correct when the paths refer to
something in STAGING_DIR (e.g. libdir, includedir), but not when it
refers to something used for the target.
iwd uses the datadir variable from dbus-1.pc to decide where to install
things. Since DESTDIR is prepended to the install destination, this will
end up in the wrong location.
Until a better solution is found in pkgconf, pass the usbdropdir to use
explicitly instead of relying on dbus-1.pc.
Fixes:
- http://autobuild.buildroot.org/results/2b9e28264248f073cc9973bd4c7a89363ec9c0c3
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/iwd/iwd.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/iwd/iwd.mk b/package/iwd/iwd.mk
index 2ff8f88cf8..1cfc05be41 100644
--- a/package/iwd/iwd.mk
+++ b/package/iwd/iwd.mk
@@ -22,7 +22,7 @@ endef
IWD_POST_PATCH_HOOKS += IWD_MKDIR_BUILD_AUX
ifeq ($(BR2_PACKAGE_DBUS),y)
-IWD_CONF_OPTS += --enable-dbus-policy
+IWD_CONF_OPTS += --enable-dbus-policy --with-dbus-datadir=/usr/share
IWD_DEPENDENCIES += dbus
else
IWD_CONF_OPTS += --disable-dbus-policy
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] iwd: fix dbus build with pkgconf 1.5.3
2018-12-12 20:13 [Buildroot] [PATCH 1/1] iwd: fix dbus build with pkgconf 1.5.3 Fabrice Fontaine
@ 2018-12-13 20:30 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-12-13 20:30 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 12 Dec 2018 21:13:08 +0100, Fabrice Fontaine wrote:
> Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute
> paths found in the .pc file. This is correct when the paths refer to
> something in STAGING_DIR (e.g. libdir, includedir), but not when it
> refers to something used for the target.
>
> iwd uses the datadir variable from dbus-1.pc to decide where to install
> things. Since DESTDIR is prepended to the install destination, this will
> end up in the wrong location.
>
> Until a better solution is found in pkgconf, pass the usbdropdir to use
> explicitly instead of relying on dbus-1.pc.
>
> Fixes:
> - http://autobuild.buildroot.org/results/2b9e28264248f073cc9973bd4c7a89363ec9c0c3
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/iwd/iwd.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-13 20:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-12 20:13 [Buildroot] [PATCH 1/1] iwd: fix dbus build with pkgconf 1.5.3 Fabrice Fontaine
2018-12-13 20:30 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox