* [Buildroot] [PATCH] package/lldpd: fix readline dependency
@ 2018-12-10 15:48 Thomas Petazzoni
2018-12-13 21:26 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2018-12-10 15:48 UTC (permalink / raw)
To: buildroot
lldpd can optionally depend on readline, but readline is never added
to LLDPD_DEPENDENCIES, which this commit fixes.
This was detected using per-package directories.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/lldpd/lldpd.mk | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/package/lldpd/lldpd.mk b/package/lldpd/lldpd.mk
index 939cd128fa..6a520448da 100644
--- a/package/lldpd/lldpd.mk
+++ b/package/lldpd/lldpd.mk
@@ -36,7 +36,6 @@ LLDPD_CONF_OPTS = \
--without-libbsd \
--disable-hardening \
--disable-privsep \
- $(if $(BR2_PACKAGE_READLINE),--with-readline,--without-readline) \
$(if $(BR2_PACKAGE_LLDPD_CDP),--enable-cdp,--disable-cdp) \
$(if $(BR2_PACKAGE_LLDPD_FDP),--enable-fdp,--disable-fdp) \
$(if $(BR2_PACKAGE_LLDPD_EDP),--enable-edp,--disable-edp) \
@@ -46,6 +45,13 @@ LLDPD_CONF_OPTS = \
$(if $(BR2_PACKAGE_LLDPD_DOT3),--enable-dot3,--disable-dot3) \
$(if $(BR2_PACKAGE_LLDPD_CUSTOM_TLV),--enable-custom,--disable-custom)
+ifeq ($(BR2_PACKAGE_READLINE),y)
+LLDPD_CONF_OPTS += --with-readline
+LLDPD_DEPENDENCIES += readline
+else
+LLDPD_CONF_OPTS += --without-readline
+endif
+
define LLDPD_INSTALL_INIT_SYSV
$(INSTALL) -D -m 0755 package/lldpd/S60lldpd \
$(TARGET_DIR)/etc/init.d/S60lldpd
--
2.19.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] package/lldpd: fix readline dependency
2018-12-10 15:48 [Buildroot] [PATCH] package/lldpd: fix readline dependency Thomas Petazzoni
@ 2018-12-13 21:26 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-12-13 21:26 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 10 Dec 2018 16:48:22 +0100, Thomas Petazzoni wrote:
> lldpd can optionally depend on readline, but readline is never added
> to LLDPD_DEPENDENCIES, which this commit fixes.
>
> This was detected using per-package directories.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/lldpd/lldpd.mk | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-13 21:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-10 15:48 [Buildroot] [PATCH] package/lldpd: fix readline dependency Thomas Petazzoni
2018-12-13 21:26 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox