Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/1] package/mesa3d: bump to version 18.3.1
@ 2018-12-15  8:10 james.hilliard1 at gmail.com
  2018-12-15  8:26 ` Bernd Kuhls
  2018-12-15 10:39 ` Yann E. MORIN
  0 siblings, 2 replies; 7+ messages in thread
From: james.hilliard1 at gmail.com @ 2018-12-15  8:10 UTC (permalink / raw)
  To: buildroot

From: James Hilliard <james.hilliard1@gmail.com>

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 ...d-missing-include-stddef.h-in-egldevice.h.patch | 45 ++++++++++++++++++++++
 package/mesa3d/mesa3d.hash                         | 10 ++---
 package/mesa3d/mesa3d.mk                           |  2 +-
 3 files changed, 51 insertions(+), 6 deletions(-)
 create mode 100644 package/mesa3d/0004-egl-add-missing-include-stddef.h-in-egldevice.h.patch

diff --git a/package/mesa3d/0004-egl-add-missing-include-stddef.h-in-egldevice.h.patch b/package/mesa3d/0004-egl-add-missing-include-stddef.h-in-egldevice.h.patch
new file mode 100644
index 0000000..b47a642
--- /dev/null
+++ b/package/mesa3d/0004-egl-add-missing-include-stddef.h-in-egldevice.h.patch
@@ -0,0 +1,45 @@
+From eb44c36cf1729e7e200b77cf8ea755dff72d1639 Mon Sep 17 00:00:00 2001
+From: Gurchetan Singh <gurchetansingh@chromium.org>
+Date: Wed, 28 Nov 2018 08:39:34 -0800
+Subject: [PATCH] egl: add missing #include <stddef.h> in egldevice.h
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Otherwise, I get this error:
+
+main/egldevice.h:54:13: error: ?NULL? undeclared (first use in this function)
+       dev = NULL;
+             ^~~~
+with this config:
+
+./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless' --disable-glx
+             --with-dri-drivers="i965" --with-gallium-drivers="" --enable-gbm
+
+v3: Use stddef.h (Matt)
+v4: Modify commit message (Eric)
+
+Reviewed-by: Matt Turner <mattst88@gmail.com>
+Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
+---
+ src/egl/main/egldevice.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/egl/main/egldevice.h b/src/egl/main/egldevice.h
+index ddcdcd1..83a47d5 100644
+--- a/src/egl/main/egldevice.h
++++ b/src/egl/main/egldevice.h
+@@ -31,9 +31,9 @@
+ 
+ 
+ #include <stdbool.h>
++#include <stddef.h>
+ #include "egltypedefs.h"
+ 
+-
+ #ifdef __cplusplus
+ extern "C" {
+ #endif
+-- 
+2.7.4
+
diff --git a/package/mesa3d/mesa3d.hash b/package/mesa3d/mesa3d.hash
index 563ac62..68ec1ec 100644
--- a/package/mesa3d/mesa3d.hash
+++ b/package/mesa3d/mesa3d.hash
@@ -1,7 +1,7 @@
-# From https://lists.freedesktop.org/archives/mesa-announce/2018-December/000482.html
-md5 2d69eff8fe0c6e89bb793d4fd69b750d  mesa-18.3.0.tar.xz
-sha1 d4ddc4e7aa8e11a41d35b5d51476f867e81056ca  mesa-18.3.0.tar.xz
-sha256 b63f947e735d6ef3dfaa30c789a9adfbae18aea671191eaacde95a18c17fc38a  mesa-18.3.0.tar.xz
-sha512 6643d8a100c50efee7178fe950e7cccad24c3a98538d3a13c7c6570add30a56776b4e5f279e2b0a20c4038e682e9461ca5a4fd4ac23a7f60d2f4a0c972525c42  mesa-18.3.0.tar.xz
+# From https://lists.freedesktop.org/archives/mesa-announce/2018-December/000484.html
+md5 d60828056d77bfdbae0970f9b15fb1be  mesa-18.3.1.tar.xz
+sha1 50ba2d37647fea77ea19416e8a6ffed34c313330  mesa-18.3.1.tar.xz
+sha256 5b1f827d28684a25f6657289f8b7d47ac56395988c7ac23e0ec9a62b644bdc63  mesa-18.3.1.tar.xz
+sha512 a68d39158cf1e868d70730d0641a0cfe4c6e5b3cd1bc0c47f54022402aca03503933084f6ddc722bf88c9b6d1281ba5c847ec4fed8092a9b33f90527d08e12db  mesa-18.3.1.tar.xz
 # License
 sha256 630e75b4fdeb75ee2bf9e55db54dd1e3ff7353d52d9314ca8512bfd460f8e24c  docs/license.html
diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
index f3ee69b..2fe46bd 100644
--- a/package/mesa3d/mesa3d.mk
+++ b/package/mesa3d/mesa3d.mk
@@ -5,7 +5,7 @@
 ################################################################################
 
 # When updating the version, please also update mesa3d-headers
-MESA3D_VERSION = 18.3.0
+MESA3D_VERSION = 18.3.1
 MESA3D_SOURCE = mesa-$(MESA3D_VERSION).tar.xz
 MESA3D_SITE = https://mesa.freedesktop.org/archive
 MESA3D_LICENSE = MIT, SGI, Khronos
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/mesa3d: bump to version 18.3.1
  2018-12-15  8:10 [Buildroot] [PATCH v2 1/1] package/mesa3d: bump to version 18.3.1 james.hilliard1 at gmail.com
@ 2018-12-15  8:26 ` Bernd Kuhls
  2018-12-15 10:39 ` Yann E. MORIN
  1 sibling, 0 replies; 7+ messages in thread
From: Bernd Kuhls @ 2018-12-15  8:26 UTC (permalink / raw)
  To: buildroot

Am Sat, 15 Dec 2018 16:10:38 +0800 schrieb
james.hilliard1-Re5JQEeQqe8AvxtiuMwx3w:

> From: James Hilliard <james.hilliard1@gmail.com>
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Hi,

you need to update package/mesa3d-headers as well.

Regards, Bernd

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/mesa3d: bump to version 18.3.1
  2018-12-15  8:10 [Buildroot] [PATCH v2 1/1] package/mesa3d: bump to version 18.3.1 james.hilliard1 at gmail.com
  2018-12-15  8:26 ` Bernd Kuhls
@ 2018-12-15 10:39 ` Yann E. MORIN
  2018-12-15 10:56   ` James Hilliard
  1 sibling, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2018-12-15 10:39 UTC (permalink / raw)
  To: buildroot

James, All,

On 2018-12-15 16:10 +0800, james.hilliard1 at gmail.com spake thusly:
> From: James Hilliard <james.hilliard1@gmail.com>

You need to provide a commit log that explains a bit the change,
especially since it is not a simple bumnp (you add a new patch).

More comment below...

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---

When you send an updated patch (a v2, v3...), please add a revision
changelog here, see:

https://buildroot.org/downloads/manual/manual.html#_patch_revision_changelog

>  ...d-missing-include-stddef.h-in-egldevice.h.patch | 45 ++++++++++++++++++++++
>  package/mesa3d/mesa3d.hash                         | 10 ++---
>  package/mesa3d/mesa3d.mk                           |  2 +-
>  3 files changed, 51 insertions(+), 6 deletions(-)
>  create mode 100644 package/mesa3d/0004-egl-add-missing-include-stddef.h-in-egldevice.h.patch
> 
> diff --git a/package/mesa3d/0004-egl-add-missing-include-stddef.h-in-egldevice.h.patch b/package/mesa3d/0004-egl-add-missing-include-stddef.h-in-egldevice.h.patch
> new file mode 100644
> index 0000000..b47a642
> --- /dev/null
> +++ b/package/mesa3d/0004-egl-add-missing-include-stddef.h-in-egldevice.h.patch
> @@ -0,0 +1,45 @@
> +From eb44c36cf1729e7e200b77cf8ea755dff72d1639 Mon Sep 17 00:00:00 2001
> +From: Gurchetan Singh <gurchetansingh@chromium.org>
> +Date: Wed, 28 Nov 2018 08:39:34 -0800
> +Subject: [PATCH] egl: add missing #include <stddef.h> in egldevice.h
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +Otherwise, I get this error:
> +
> +main/egldevice.h:54:13: error: ?NULL? undeclared (first use in this function)
> +       dev = NULL;
> +             ^~~~
> +with this config:
> +
> +./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless' --disable-glx
> +             --with-dri-drivers="i965" --with-gallium-drivers="" --enable-gbm
> +
> +v3: Use stddef.h (Matt)
> +v4: Modify commit message (Eric)
> +
> +Reviewed-by: Matt Turner <mattst88@gmail.com>
> +Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>

Here, you should also add your own Signed-off-by tag, and a note stating
that this is backported from upstream or is grabbed from a ML thread or
whatever, so that we know whether to remove it on next bump for example;

    [james.hilliard1 at gmail.com: backport from upstream commit]
    Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
https://buildroot.org/downloads/manual/manual.html#_integrating_patches_found_on_the_web

[--SNIP--]
> diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
> index f3ee69b..2fe46bd 100644
> --- a/package/mesa3d/mesa3d.mk
> +++ b/package/mesa3d/mesa3d.mk
> @@ -5,7 +5,7 @@
>  ################################################################################
>  
>  # When updating the version, please also update mesa3d-headers
> -MESA3D_VERSION = 18.3.0
> +MESA3D_VERSION = 18.3.1

As Bernd already pointed out, you need to also update mesa3d-headers
too. What made you miss the notice just above? Do you have a suggestion
so that the next one who bumps either mesa3d or mesa3d-headers does not
miss it next time?

Regards,
Yann E. MORIN.

>  MESA3D_SOURCE = mesa-$(MESA3D_VERSION).tar.xz
>  MESA3D_SITE = https://mesa.freedesktop.org/archive
>  MESA3D_LICENSE = MIT, SGI, Khronos
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/mesa3d: bump to version 18.3.1
  2018-12-15 10:39 ` Yann E. MORIN
@ 2018-12-15 10:56   ` James Hilliard
  2018-12-15 11:04     ` Yann E. MORIN
  0 siblings, 1 reply; 7+ messages in thread
From: James Hilliard @ 2018-12-15 10:56 UTC (permalink / raw)
  To: buildroot

On Sat, Dec 15, 2018 at 3:39 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> James, All,
>
> On 2018-12-15 16:10 +0800, james.hilliard1 at gmail.com spake thusly:
> > From: James Hilliard <james.hilliard1@gmail.com>
>
> You need to provide a commit log that explains a bit the change,
> especially since it is not a simple bumnp (you add a new patch).
>
> More comment below...
>
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
>
> When you send an updated patch (a v2, v3...), please add a revision
> changelog here, see:
>
> https://buildroot.org/downloads/manual/manual.html#_patch_revision_changelog
>
> >  ...d-missing-include-stddef.h-in-egldevice.h.patch | 45 ++++++++++++++++++++++
> >  package/mesa3d/mesa3d.hash                         | 10 ++---
> >  package/mesa3d/mesa3d.mk                           |  2 +-
> >  3 files changed, 51 insertions(+), 6 deletions(-)
> >  create mode 100644 package/mesa3d/0004-egl-add-missing-include-stddef.h-in-egldevice.h.patch
> >
> > diff --git a/package/mesa3d/0004-egl-add-missing-include-stddef.h-in-egldevice.h.patch b/package/mesa3d/0004-egl-add-missing-include-stddef.h-in-egldevice.h.patch
> > new file mode 100644
> > index 0000000..b47a642
> > --- /dev/null
> > +++ b/package/mesa3d/0004-egl-add-missing-include-stddef.h-in-egldevice.h.patch
> > @@ -0,0 +1,45 @@
> > +From eb44c36cf1729e7e200b77cf8ea755dff72d1639 Mon Sep 17 00:00:00 2001
> > +From: Gurchetan Singh <gurchetansingh@chromium.org>
> > +Date: Wed, 28 Nov 2018 08:39:34 -0800
> > +Subject: [PATCH] egl: add missing #include <stddef.h> in egldevice.h
> > +MIME-Version: 1.0
> > +Content-Type: text/plain; charset=UTF-8
> > +Content-Transfer-Encoding: 8bit
> > +
> > +Otherwise, I get this error:
> > +
> > +main/egldevice.h:54:13: error: ?NULL? undeclared (first use in this function)
> > +       dev = NULL;
> > +             ^~~~
> > +with this config:
> > +
> > +./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless' --disable-glx
> > +             --with-dri-drivers="i965" --with-gallium-drivers="" --enable-gbm
> > +
> > +v3: Use stddef.h (Matt)
> > +v4: Modify commit message (Eric)
> > +
> > +Reviewed-by: Matt Turner <mattst88@gmail.com>
> > +Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
>
> Here, you should also add your own Signed-off-by tag, and a note stating
> that this is backported from upstream or is grabbed from a ML thread or
> whatever, so that we know whether to remove it on next bump for example;
will add for next version, it's a backport from upstream
>
>     [james.hilliard1 at gmail.com: backport from upstream commit]
>     Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>
> https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
> https://buildroot.org/downloads/manual/manual.html#_integrating_patches_found_on_the_web
>
> [--SNIP--]
> > diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
> > index f3ee69b..2fe46bd 100644
> > --- a/package/mesa3d/mesa3d.mk
> > +++ b/package/mesa3d/mesa3d.mk
> > @@ -5,7 +5,7 @@
> >  ################################################################################
> >
> >  # When updating the version, please also update mesa3d-headers
> > -MESA3D_VERSION = 18.3.0
> > +MESA3D_VERSION = 18.3.1
>
> As Bernd already pointed out, you need to also update mesa3d-headers
> too. What made you miss the notice just above? Do you have a suggestion
> so that the next one who bumps either mesa3d or mesa3d-headers does not
> miss it next time?
It was 1am when I sent this and literally only looked for the version
number to bump it when debugging a build failure. Wouldn't it make
sense to have mesa3d and mesa3d-headers share the same package version
so that only one needs to be bumped?
>
> Regards,
> Yann E. MORIN.
>
> >  MESA3D_SOURCE = mesa-$(MESA3D_VERSION).tar.xz
> >  MESA3D_SITE = https://mesa.freedesktop.org/archive
> >  MESA3D_LICENSE = MIT, SGI, Khronos
> > --
> > 2.7.4
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/mesa3d: bump to version 18.3.1
  2018-12-15 10:56   ` James Hilliard
@ 2018-12-15 11:04     ` Yann E. MORIN
  2018-12-15 11:15       ` James Hilliard
  0 siblings, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2018-12-15 11:04 UTC (permalink / raw)
  To: buildroot

James, All,

On 2018-12-15 03:56 -0700, James Hilliard spake thusly:
> On Sat, Dec 15, 2018 at 3:39 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
[--SNIP--]
> > > diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
> > > index f3ee69b..2fe46bd 100644
> > > --- a/package/mesa3d/mesa3d.mk
> > > +++ b/package/mesa3d/mesa3d.mk
> > > @@ -5,7 +5,7 @@
> > >  ################################################################################
> > >
> > >  # When updating the version, please also update mesa3d-headers
> > > -MESA3D_VERSION = 18.3.0
> > > +MESA3D_VERSION = 18.3.1
> >
> > As Bernd already pointed out, you need to also update mesa3d-headers
> > too. What made you miss the notice just above? Do you have a suggestion
> > so that the next one who bumps either mesa3d or mesa3d-headers does not
> > miss it next time?
> It was 1am when I sent this

Aha! :-)

> and literally only looked for the version
> number to bump it when debugging a build failure. Wouldn't it make
> sense to have mesa3d and mesa3d-headers share the same package version
> so that only one needs to be bumped?

That's unfortunately not possible, see the comment in mesa3d-headers...

Regards,
Yann E. MORIN.

> > Regards,
> > Yann E. MORIN.
> >
> > >  MESA3D_SOURCE = mesa-$(MESA3D_VERSION).tar.xz
> > >  MESA3D_SITE = https://mesa.freedesktop.org/archive
> > >  MESA3D_LICENSE = MIT, SGI, Khronos
> > > --
> > > 2.7.4
> > >
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot at busybox.net
> > > http://lists.busybox.net/mailman/listinfo/buildroot
> >
> > --
> > .-----------------.--------------------.------------------.--------------------.
> > |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> > | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> > | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> > '------------------------------^-------^------------------^--------------------'

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/mesa3d: bump to version 18.3.1
  2018-12-15 11:04     ` Yann E. MORIN
@ 2018-12-15 11:15       ` James Hilliard
  2018-12-15 13:40         ` Yann E. MORIN
  0 siblings, 1 reply; 7+ messages in thread
From: James Hilliard @ 2018-12-15 11:15 UTC (permalink / raw)
  To: buildroot

On Sat, Dec 15, 2018 at 4:04 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> James, All,
>
> On 2018-12-15 03:56 -0700, James Hilliard spake thusly:
> > On Sat, Dec 15, 2018 at 3:39 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> [--SNIP--]
> > > > diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
> > > > index f3ee69b..2fe46bd 100644
> > > > --- a/package/mesa3d/mesa3d.mk
> > > > +++ b/package/mesa3d/mesa3d.mk
> > > > @@ -5,7 +5,7 @@
> > > >  ################################################################################
> > > >
> > > >  # When updating the version, please also update mesa3d-headers
> > > > -MESA3D_VERSION = 18.3.0
> > > > +MESA3D_VERSION = 18.3.1
> > >
> > > As Bernd already pointed out, you need to also update mesa3d-headers
> > > too. What made you miss the notice just above? Do you have a suggestion
> > > so that the next one who bumps either mesa3d or mesa3d-headers does not
> > > miss it next time?
> > It was 1am when I sent this
>
> Aha! :-)
>
> > and literally only looked for the version
> > number to bump it when debugging a build failure. Wouldn't it make
> > sense to have mesa3d and mesa3d-headers share the same package version
> > so that only one needs to be bumped?
>
> That's unfortunately not possible, see the comment in mesa3d-headers...
I think you could turn mesa3d-headers into a virtual/fake package
similar to how I did it with my systemd-boot patch. Then you wouldn't
have to refer to variables in mesa3d.
>
> Regards,
> Yann E. MORIN.
>
> > > Regards,
> > > Yann E. MORIN.
> > >
> > > >  MESA3D_SOURCE = mesa-$(MESA3D_VERSION).tar.xz
> > > >  MESA3D_SITE = https://mesa.freedesktop.org/archive
> > > >  MESA3D_LICENSE = MIT, SGI, Khronos
> > > > --
> > > > 2.7.4
> > > >
> > > > _______________________________________________
> > > > buildroot mailing list
> > > > buildroot at busybox.net
> > > > http://lists.busybox.net/mailman/listinfo/buildroot
> > >
> > > --
> > > .-----------------.--------------------.------------------.--------------------.
> > > |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> > > | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> > > | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> > > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> > > '------------------------------^-------^------------------^--------------------'
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/mesa3d: bump to version 18.3.1
  2018-12-15 11:15       ` James Hilliard
@ 2018-12-15 13:40         ` Yann E. MORIN
  0 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2018-12-15 13:40 UTC (permalink / raw)
  To: buildroot

James, All,

On 2018-12-15 04:15 -0700, James Hilliard spake thusly:
> On Sat, Dec 15, 2018 at 4:04 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2018-12-15 03:56 -0700, James Hilliard spake thusly:
> > > Wouldn't it make
> > > sense to have mesa3d and mesa3d-headers share the same package version
> > > so that only one needs to be bumped?
> > That's unfortunately not possible, see the comment in mesa3d-headers...
> I think you could turn mesa3d-headers into a virtual/fake package
> similar to how I did it with my systemd-boot patch. Then you wouldn't
> have to refer to variables in mesa3d.

No, because that would make mesa3d more complex, for little benefit, see
the commit log of 8138a36018 (package/mesa3d-headers: new package), in
which there is an blurb about that.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-12-15 13:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-15  8:10 [Buildroot] [PATCH v2 1/1] package/mesa3d: bump to version 18.3.1 james.hilliard1 at gmail.com
2018-12-15  8:26 ` Bernd Kuhls
2018-12-15 10:39 ` Yann E. MORIN
2018-12-15 10:56   ` James Hilliard
2018-12-15 11:04     ` Yann E. MORIN
2018-12-15 11:15       ` James Hilliard
2018-12-15 13:40         ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox