From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/4] skeleton: use BR2_SYSTEM_DEFAULT_PATH as default PATH
Date: Tue, 18 Dec 2018 20:33:39 +0100 [thread overview]
Message-ID: <20181218193339.GD24194@scaer> (raw)
In-Reply-To: <20181218005116.17435-3-mmayer@broadcom.com>
Markus, All,
On 2018-12-17 16:51 -0800, Markus Mayer spake thusly:
> We substitute the path specified in system/skeleton/etc/profile with
> the path specified in the configuration varialbe
> BR2_SYSTEM_DEFAULT_PATH.
You forgot to state in the commit log that $(BR2_SYSTEM_DEFAULT_PATH) is
a kconfig string, so it is already quoted, and that's what we want it to
be in the file.
Regards,
Yann E. MORIN.
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
> package/skeleton-init-common/skeleton-init-common.mk | 3 +++
> system/skeleton/etc/profile | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/package/skeleton-init-common/skeleton-init-common.mk b/package/skeleton-init-common/skeleton-init-common.mk
> index e8a052205268..358336599389 100644
> --- a/package/skeleton-init-common/skeleton-init-common.mk
> +++ b/package/skeleton-init-common/skeleton-init-common.mk
> @@ -22,6 +22,9 @@ define SKELETON_INIT_COMMON_INSTALL_TARGET_CMDS
> $(call SYSTEM_LIB_SYMLINK,$(TARGET_DIR))
> $(INSTALL) -m 0644 support/misc/target-dir-warning.txt \
> $(TARGET_DIR_WARNING_FILE)
> + $(SED) '/.*the PATH below may be replaced.*/d' $(TARGET_DIR)/etc/profile
> + $(SED) 's|PATH=.*|PATH=$(BR2_SYSTEM_DEFAULT_PATH)|' \
> + $(TARGET_DIR)/etc/profile
> endef
>
> # We don't care much about what goes in staging, as long as it is
> diff --git a/system/skeleton/etc/profile b/system/skeleton/etc/profile
> index 1255d23ff40d..5ed47743d8f4 100644
> --- a/system/skeleton/etc/profile
> +++ b/system/skeleton/etc/profile
> @@ -1,3 +1,4 @@
> +# At install, the PATH below may be replaced with BR2_SYSTEM_DEFAULT_PATH.
> export PATH=/bin:/sbin:/usr/bin:/usr/sbin
>
> if [ "$PS1" ]; then
> --
> 2.17.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-12-18 19:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 0:51 [Buildroot] [PATCH 0/4] Allow customization of system default PATH Markus Mayer
2018-12-18 0:51 ` [Buildroot] [PATCH 1/4] system cfg: introduce option BR2_SYSTEM_DEFAULT_PATH Markus Mayer
2018-12-18 19:27 ` Yann E. MORIN
2018-12-18 21:22 ` Markus Mayer
2018-12-18 0:51 ` [Buildroot] [PATCH 2/4] skeleton: use BR2_SYSTEM_DEFAULT_PATH as default PATH Markus Mayer
2018-12-18 19:32 ` Yann E. MORIN
2018-12-18 19:33 ` Yann E. MORIN [this message]
2018-12-18 0:51 ` [Buildroot] [PATCH 3/4] openssh: " Markus Mayer
2018-12-18 19:38 ` Yann E. MORIN
2018-12-18 0:51 ` [Buildroot] [PATCH 4/4] dropbear: " Markus Mayer
2018-12-18 19:47 ` Yann E. MORIN
[not found] ` <CAGt4E5uXpteKpCCt_XmKG2HONQ3PQQADHjSyjeBKRPhphxhWhQ@mail.gmail.com>
2018-12-18 23:16 ` Markus Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218193339.GD24194@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox