* [Buildroot] [PATCH 1/2] webkitgtk: remove an old workaround
@ 2018-12-25 8:00 Francois Perrad
2018-12-25 8:00 ` [Buildroot] [PATCH 2/2] webkitgtk: fix host dependencies Francois Perrad
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Francois Perrad @ 2018-12-25 8:00 UTC (permalink / raw)
To: buildroot
fixed upstream by https://trac.webkit.org/changeset/220007/webkit
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
package/webkitgtk/webkitgtk.mk | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index 4cfddd1eb..e03fd969e 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -39,13 +39,9 @@ WEBKITGTK_CONF_OPTS += \
-DENABLE_WEB_AUDIO=ON
WEBKITGTK_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
else
-# ENABLE_MEDIA_STREAM has to be explicitly disabled because there is a missing
-# feature dependency in the WebKitGTK+ CMake files. This can be removed once
-# https://bugs.webkit.org/show_bug.cgi?id=174940 makes it into a release.
WEBKITGTK_CONF_OPTS += \
-DENABLE_VIDEO=OFF \
- -DENABLE_WEB_AUDIO=OFF \
- -DENABLE_MEDIA_STREAM=OFF
+ -DENABLE_WEB_AUDIO=OFF
endif
ifeq ($(BR2_PACKAGE_WEBKITGTK_WEBDRIVER),y)
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH 2/2] webkitgtk: fix host dependencies
2018-12-25 8:00 [Buildroot] [PATCH 1/2] webkitgtk: remove an old workaround Francois Perrad
@ 2018-12-25 8:00 ` Francois Perrad
2018-12-25 17:57 ` Adrian Perez de Castro
2019-01-01 16:00 ` Peter Korsgaard
2018-12-25 17:46 ` [Buildroot] [PATCH 1/2] webkitgtk: remove an old workaround Adrian Perez de Castro
` (2 subsequent siblings)
3 siblings, 2 replies; 7+ messages in thread
From: Francois Perrad @ 2018-12-25 8:00 UTC (permalink / raw)
To: buildroot
python 2.7 is required by the cmake stuff.
bison & flex are not used in the webkitgtk tree.
Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
package/webkitgtk/webkitgtk.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index e03fd969e..80daadd15 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -12,7 +12,7 @@ WEBKITGTK_LICENSE = LGPL-2.1+, BSD-2-Clause
WEBKITGTK_LICENSE_FILES = \
Source/WebCore/LICENSE-APPLE \
Source/WebCore/LICENSE-LGPL-2.1
-WEBKITGTK_DEPENDENCIES = host-ruby host-flex host-bison host-gperf \
+WEBKITGTK_DEPENDENCIES = host-ruby host-python host-gperf \
enchant harfbuzz icu jpeg libgcrypt libgtk3 libsecret libsoup \
libtasn1 libxml2 libxslt sqlite webp woff2
WEBKITGTK_CONF_OPTS = \
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH 2/2] webkitgtk: fix host dependencies
2018-12-25 8:00 ` [Buildroot] [PATCH 2/2] webkitgtk: fix host dependencies Francois Perrad
@ 2018-12-25 17:57 ` Adrian Perez de Castro
2019-01-01 16:00 ` Peter Korsgaard
1 sibling, 0 replies; 7+ messages in thread
From: Adrian Perez de Castro @ 2018-12-25 17:57 UTC (permalink / raw)
To: buildroot
Hello Fran?ois,
Thanks for seding these cleanups, they look good to me.
On Tue, 25 Dec 2018 09:00:09 +0100, Francois Perrad <fperrad@gmail.com> wrote:
> python 2.7 is required by the cmake stuff.
> bison & flex are not used in the webkitgtk tree.
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
Acked-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> package/webkitgtk/webkitgtk.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> index e03fd969e..80daadd15 100644
> --- a/package/webkitgtk/webkitgtk.mk
> +++ b/package/webkitgtk/webkitgtk.mk
> @@ -12,7 +12,7 @@ WEBKITGTK_LICENSE = LGPL-2.1+, BSD-2-Clause
> WEBKITGTK_LICENSE_FILES = \
> Source/WebCore/LICENSE-APPLE \
> Source/WebCore/LICENSE-LGPL-2.1
> -WEBKITGTK_DEPENDENCIES = host-ruby host-flex host-bison host-gperf \
> +WEBKITGTK_DEPENDENCIES = host-ruby host-python host-gperf \
> enchant harfbuzz icu jpeg libgcrypt libgtk3 libsecret libsoup \
> libtasn1 libxml2 libxslt sqlite webp woff2
> WEBKITGTK_CONF_OPTS = \
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181225/9f4c5606/attachment.asc>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] webkitgtk: fix host dependencies
2018-12-25 8:00 ` [Buildroot] [PATCH 2/2] webkitgtk: fix host dependencies Francois Perrad
2018-12-25 17:57 ` Adrian Perez de Castro
@ 2019-01-01 16:00 ` Peter Korsgaard
1 sibling, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2019-01-01 16:00 UTC (permalink / raw)
To: buildroot
>>>>> "Francois" == Francois Perrad <fperrad@gmail.com> writes:
> python 2.7 is required by the cmake stuff.
> bison & flex are not used in the webkitgtk tree.
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
Committed to 2018.02.x and 2018.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] webkitgtk: remove an old workaround
2018-12-25 8:00 [Buildroot] [PATCH 1/2] webkitgtk: remove an old workaround Francois Perrad
2018-12-25 8:00 ` [Buildroot] [PATCH 2/2] webkitgtk: fix host dependencies Francois Perrad
@ 2018-12-25 17:46 ` Adrian Perez de Castro
2018-12-26 14:11 ` Thomas Petazzoni
2019-01-01 16:00 ` Peter Korsgaard
3 siblings, 0 replies; 7+ messages in thread
From: Adrian Perez de Castro @ 2018-12-25 17:46 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 25 Dec 2018 09:00:08 +0100, Francois Perrad <fperrad@gmail.com> wrote:
> fixed upstream by https://trac.webkit.org/changeset/220007/webkit
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
Acked-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
> package/webkitgtk/webkitgtk.mk | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> index 4cfddd1eb..e03fd969e 100644
> --- a/package/webkitgtk/webkitgtk.mk
> +++ b/package/webkitgtk/webkitgtk.mk
> @@ -39,13 +39,9 @@ WEBKITGTK_CONF_OPTS += \
> -DENABLE_WEB_AUDIO=ON
> WEBKITGTK_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
> else
> -# ENABLE_MEDIA_STREAM has to be explicitly disabled because there is a missing
> -# feature dependency in the WebKitGTK+ CMake files. This can be removed once
> -# https://bugs.webkit.org/show_bug.cgi?id=174940 makes it into a release.
> WEBKITGTK_CONF_OPTS += \
> -DENABLE_VIDEO=OFF \
> - -DENABLE_WEB_AUDIO=OFF \
> - -DENABLE_MEDIA_STREAM=OFF
> + -DENABLE_WEB_AUDIO=OFF
> endif
>
> ifeq ($(BR2_PACKAGE_WEBKITGTK_WEBDRIVER),y)
> --
> 2.17.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181225/8e37bbb1/attachment.asc>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] webkitgtk: remove an old workaround
2018-12-25 8:00 [Buildroot] [PATCH 1/2] webkitgtk: remove an old workaround Francois Perrad
2018-12-25 8:00 ` [Buildroot] [PATCH 2/2] webkitgtk: fix host dependencies Francois Perrad
2018-12-25 17:46 ` [Buildroot] [PATCH 1/2] webkitgtk: remove an old workaround Adrian Perez de Castro
@ 2018-12-26 14:11 ` Thomas Petazzoni
2019-01-01 16:00 ` Peter Korsgaard
3 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2018-12-26 14:11 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 25 Dec 2018 09:00:08 +0100, Francois Perrad wrote:
> fixed upstream by https://trac.webkit.org/changeset/220007/webkit
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/webkitgtk/webkitgtk.mk | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Thanks, both patches applied, with Adrian Acked-by. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] webkitgtk: remove an old workaround
2018-12-25 8:00 [Buildroot] [PATCH 1/2] webkitgtk: remove an old workaround Francois Perrad
` (2 preceding siblings ...)
2018-12-26 14:11 ` Thomas Petazzoni
@ 2019-01-01 16:00 ` Peter Korsgaard
3 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2019-01-01 16:00 UTC (permalink / raw)
To: buildroot
>>>>> "Francois" == Francois Perrad <fperrad@gmail.com> writes:
> fixed upstream by https://trac.webkit.org/changeset/220007/webkit
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
Committed to 2018.02.x and 2018.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-01-01 16:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-25 8:00 [Buildroot] [PATCH 1/2] webkitgtk: remove an old workaround Francois Perrad
2018-12-25 8:00 ` [Buildroot] [PATCH 2/2] webkitgtk: fix host dependencies Francois Perrad
2018-12-25 17:57 ` Adrian Perez de Castro
2019-01-01 16:00 ` Peter Korsgaard
2018-12-25 17:46 ` [Buildroot] [PATCH 1/2] webkitgtk: remove an old workaround Adrian Perez de Castro
2018-12-26 14:11 ` Thomas Petazzoni
2019-01-01 16:00 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox