[Buildroot] [PATCH 1/1] apache: enable support for nghttp2

[Buildroot] [PATCH 1/1] apache: enable support for nghttp2

[Ryan Coe]

Signed-off-by: Ryan Coe <bluemrp9@gmail.com>
---
 package/apache/apache.mk | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/package/apache/apache.mk b/package/apache/apache.mk
index 283c3cbd50..a95ac69f31 100644
--- a/package/apache/apache.mk
+++ b/package/apache/apache.mk
@@ -63,6 +63,15 @@ else
 APACHE_CONF_OPTS += --disable-lua
 endif
 
+ifeq ($(BR2_PACKAGE_NGHTTP2),y)
+APACHE_CONF_OPTS += \
+	--enable-http2 \
+	--with-nghttp2=$(STAGING_DIR)/usr
+APACHE_DEPENDENCIES += nghttp2
+else
+APACHE_CONF_OPTS += --disable-http2
+endif
+
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 APACHE_DEPENDENCIES += openssl
 APACHE_CONF_OPTS += \
-- 
2.20.1

[Buildroot] [PATCH 1/1] apache: enable support for nghttp2

[Thomas Petazzoni]

Hello,

(Also a question for Bernd below)

On Fri, 28 Dec 2018 17:39:09 -0800, Ryan Coe wrote:
> Signed-off-by: Ryan Coe <bluemrp9@gmail.com>
> ---
>  package/apache/apache.mk | 9 +++++++++
>  1 file changed, 9 insertions(+)

Applied to master, thanks. I just noticed that Apache modules are
installed in $(TARGET_DIR)/usr/modules/. It's not a really great path,
as it's not apache specific. Can we make this
$(TARGET_DIR)/usr/lib/apache/modules/ or something like that ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] apache: enable support for nghttp2

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello,
 > (Also a question for Bernd below)

 > On Fri, 28 Dec 2018 17:39:09 -0800, Ryan Coe wrote:
 >> Signed-off-by: Ryan Coe <bluemrp9@gmail.com>
 >> ---
 >> package/apache/apache.mk | 9 +++++++++
 >> 1 file changed, 9 insertions(+)

 > Applied to master, thanks. I just noticed that Apache modules are
 > installed in $(TARGET_DIR)/usr/modules/. It's not a really great path,
 > as it's not apache specific. Can we make this
 > $(TARGET_DIR)/usr/lib/apache/modules/ or something like that ?

FYI, Debian installs into /usr/lib/apache2/modules/ (but that is
presumably for legacy reasons with apache 1.x).

-- 
Bye, Peter Korsgaard