[Buildroot] [PATCH 1/1] scanpypi: write _SOURCE only when needed

[Buildroot] [PATCH 1/1] scanpypi: write _SOURCE only when needed

[Asaf Kahlon]

For some packages, there's no need to add the _SOURCE variable,
since the name of the source file is the same as the name of the package
(like python-engineio).
Hence, we'll add it to the .mk file only if needed.

Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
---
 utils/scanpypi | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/utils/scanpypi b/utils/scanpypi
index 9335bedee4..a75d696222 100755
--- a/utils/scanpypi
+++ b/utils/scanpypi
@@ -354,13 +354,14 @@ class BuildrootPackage():
             version=self.version)
         lines.append(version_line)
 
-        targz = self.filename.replace(
-            self.version,
-            '$({name}_VERSION)'.format(name=self.mk_name))
-        targz_line = '{name}_SOURCE = {filename}\n'.format(
-            name=self.mk_name,
-            filename=targz)
-        lines.append(targz_line)
+        if self.buildroot_name != self.real_name:
+            targz = self.filename.replace(
+                self.version,
+                '$({name}_VERSION)'.format(name=self.mk_name))
+            targz_line = '{name}_SOURCE = {filename}\n'.format(
+                name=self.mk_name,
+                filename=targz)
+            lines.append(targz_line)
 
         if self.filename not in self.url:
             # Sometimes the filename is in the url, sometimes it's not
-- 
2.19.1

[Buildroot] [PATCH 1/1] scanpypi: write _SOURCE only when needed

[Yegor Yefremov]

On Sat, Dec 22, 2018 at 7:15 PM Asaf Kahlon <asafka7@gmail.com> wrote:
>
> For some packages, there's no need to add the _SOURCE variable,
> since the name of the source file is the same as the name of the package
> (like python-engineio).
> Hence, we'll add it to the .mk file only if needed.
>
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>

It was a long requested feature. Thanks.

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

Yegor

> ---
>  utils/scanpypi | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/utils/scanpypi b/utils/scanpypi
> index 9335bedee4..a75d696222 100755
> --- a/utils/scanpypi
> +++ b/utils/scanpypi
> @@ -354,13 +354,14 @@ class BuildrootPackage():
>              version=self.version)
>          lines.append(version_line)
>
> -        targz = self.filename.replace(
> -            self.version,
> -            '$({name}_VERSION)'.format(name=self.mk_name))
> -        targz_line = '{name}_SOURCE = {filename}\n'.format(
> -            name=self.mk_name,
> -            filename=targz)
> -        lines.append(targz_line)
> +        if self.buildroot_name != self.real_name:
> +            targz = self.filename.replace(
> +                self.version,
> +                '$({name}_VERSION)'.format(name=self.mk_name))
> +            targz_line = '{name}_SOURCE = {filename}\n'.format(
> +                name=self.mk_name,
> +                filename=targz)
> +            lines.append(targz_line)
>
>          if self.filename not in self.url:
>              # Sometimes the filename is in the url, sometimes it's not
> --
> 2.19.1
>

[Buildroot] [PATCH 1/1] scanpypi: write _SOURCE only when needed

[Thomas Petazzoni]

Hello,

On Sat, 22 Dec 2018 20:15:32 +0200, Asaf Kahlon wrote:
> For some packages, there's no need to add the _SOURCE variable,
> since the name of the source file is the same as the name of the package
> (like python-engineio).
> Hence, we'll add it to the .mk file only if needed.
> 
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> ---
>  utils/scanpypi | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com