[Buildroot] [PATCH] rauc: target rauc needs unsquashfs at runtime

[Buildroot] [PATCH] rauc: target rauc needs unsquashfs at runtime

[Trent Piepho]

In order to provide info about a bundle file, e.g. running "rauc info
bundle.raucb", rauc needs to use the unsquashfs progam from the squashfs
package.

This was not documented until upstream commit 10c501c12752 ("docs:
integration: document need for 'unsquashfs' tool for 'rauc info'"), but
is already present in rauc.

Signed-off-by: Trent Piepho <tpiepho@impinj.com>
---
 package/rauc/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/rauc/Config.in b/package/rauc/Config.in
index 6433b827d3..456f8f382c 100644
--- a/package/rauc/Config.in
+++ b/package/rauc/Config.in
@@ -6,6 +6,7 @@ config BR2_PACKAGE_RAUC
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_DBUS # run-time dependency
+	select BR2_PACKAGE_SQUASHFS # run-time dependency
 	help
 	  RAUC is the Robust Auto-Update Controller developed by
 	  Pengutronix. It supports updating embedded Linux
-- 
2.14.4

[Buildroot] [PATCH] rauc: target rauc needs unsquashfs at runtime

[Thomas Petazzoni]

Hello,

On Mon, 17 Dec 2018 22:15:19 +0000, Trent Piepho wrote:
> In order to provide info about a bundle file, e.g. running "rauc info
> bundle.raucb", rauc needs to use the unsquashfs progam from the squashfs
> package.
> 
> This was not documented until upstream commit 10c501c12752 ("docs:
> integration: document need for 'unsquashfs' tool for 'rauc info'"), but
> is already present in rauc.
> 
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>
> ---
>  package/rauc/Config.in | 1 +
>  1 file changed, 1 insertion(+)

I am not familiar with rauc, so sorry for what is perhaps a silly
question: is squashfs needed in all cases, or just for a certain bundle
format, or certain use cases ?

I'm just trying to figure out if we really want this to be a mandatory
dependency, or rather not enforce it, and simply document that it might
be needed.

Thanks for your feedback,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] rauc: target rauc needs unsquashfs at runtime

[Trent Piepho]

On Tue, 2018-12-18 at 22:50 +0100, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon, 17 Dec 2018 22:15:19 +0000, Trent Piepho wrote:
> > In order to provide info about a bundle file, e.g. running "rauc info
> > bundle.raucb", rauc needs to use the unsquashfs progam from the squashfs
> > package.
> > 
> > This was not documented until upstream commit 10c501c12752 ("docs:
> > integration: document need for 'unsquashfs' tool for 'rauc info'"), but
> > is already present in rauc.
> > 
> > Signed-off-by: Trent Piepho <tpiepho@impinj.com>
> > ---
> >  package/rauc/Config.in | 1 +
> >  1 file changed, 1 insertion(+)
> 
> I am not familiar with rauc, so sorry for what is perhaps a silly
> question: is squashfs needed in all cases, or just for a certain bundle
> format, or certain use cases ?

The only bundle format they support uses squashfs.

To install a bundle on the target, rauc uses a loopback mount and the
kernel's squashfs support to get to the contents of the bundle.  But to
query a bundle file's metadata without installing it, it uses
unsquashfs.

So one could get by without unsquashfs if they were ok with certain
rauc features mysteriously not working.  There are no good error
messages when unsquashfs is not present.

Rauc doesn't have a feature to build without info support, so if one
doesn't have unsquashfs it really does build in a broken state.  You
can not use the broken parts, but that thinking could apply to just
about any runtime dependency.  It seems like pruning out non-optional
features is one of those things that shouldn't be a default.

[Buildroot] [PATCH] rauc: target rauc needs unsquashfs at runtime

[Thomas Petazzoni]

Hello,

On Mon, 17 Dec 2018 22:15:19 +0000, Trent Piepho wrote:
> In order to provide info about a bundle file, e.g. running "rauc info
> bundle.raucb", rauc needs to use the unsquashfs progam from the squashfs
> package.
> 
> This was not documented until upstream commit 10c501c12752 ("docs:
> integration: document need for 'unsquashfs' tool for 'rauc info'"), but
> is already present in rauc.
> 
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>
> ---
>  package/rauc/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] rauc: target rauc needs unsquashfs at runtime

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello,
 > On Mon, 17 Dec 2018 22:15:19 +0000, Trent Piepho wrote:
 >> In order to provide info about a bundle file, e.g. running "rauc info
 >> bundle.raucb", rauc needs to use the unsquashfs progam from the squashfs
 >> package.
 >> 
 >> This was not documented until upstream commit 10c501c12752 ("docs:
 >> integration: document need for 'unsquashfs' tool for 'rauc info'"), but
 >> is already present in rauc.
 >> 
 >> Signed-off-by: Trent Piepho <tpiepho@impinj.com>
 >> ---
 >> package/rauc/Config.in | 1 +
 >> 1 file changed, 1 insertion(+)

 > Applied to master, thanks.

Committed to 2018.02.x and 2018.11.x, thanks.

-- 
Bye, Peter Korsgaard