* [Buildroot] [PATCH 1/1] linux-firmware: add options to install more Mediatek firmwares.
@ 2019-01-04 15:49 Nicolas Cavallari
2019-01-04 16:14 ` Yann E. MORIN
2019-06-23 19:41 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Cavallari @ 2019-01-04 15:49 UTC (permalink / raw)
To: buildroot
Add option to install the MT7650 bluetooth firmware and the
MT76x2e wifi firmware.
Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
---
package/linux-firmware/Config.in | 10 ++++++++++
package/linux-firmware/linux-firmware.mk | 12 ++++++++++++
2 files changed, 22 insertions(+)
diff --git a/package/linux-firmware/Config.in b/package/linux-firmware/Config.in
index dcc8d4bade..3efb3d9050 100644
--- a/package/linux-firmware/Config.in
+++ b/package/linux-firmware/Config.in
@@ -59,6 +59,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_QUALCOMM_6174A_BT
help
Firmware files for QCA Rome 6174A bluetooth support.
+config BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_MT7650
+ bool "MediaTek MT7650"
+ help
+ Firmware files for MediaTek MT7650 bluetooth support
+
endmenu # Bluetooth
menu "WiFi firmware"
@@ -242,6 +247,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_MT7601U
help
MediaTek MT7601U
+config BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_MT76X2E
+ bool "MediaTek MT76x2e"
+ help
+ MediaTek MT76x2e
+
config BR2_PACKAGE_LINUX_FIRMWARE_QUALCOMM_6174
bool "Qualcomm Atheros 6174"
help
diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
index ee02c7a030..c238d9f01b 100644
--- a/package/linux-firmware/linux-firmware.mk
+++ b/package/linux-firmware/linux-firmware.mk
@@ -243,6 +243,18 @@ LINUX_FIRMWARE_FILES += mt7601u.bin
LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.ralink_a_mediatek_company_firmware
endif
+# MT7650
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_MT7650),y)
+LINUX_FIRMWARE_FILES += mt7650.bin
+LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.ralink_a_mediatek_company_firmware
+endif
+
+# MT76x2e
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_MT76X2E),y)
+LINUX_FIRMWARE_FILES += mt7662.bin mt7662_rom_patch.bin
+LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.ralink_a_mediatek_company_firmware
+endif
+
# qca6174
ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_QUALCOMM_6174),y)
LINUX_FIRMWARE_FILES += ath10k/QCA6174
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] linux-firmware: add options to install more Mediatek firmwares.
2019-01-04 15:49 [Buildroot] [PATCH 1/1] linux-firmware: add options to install more Mediatek firmwares Nicolas Cavallari
@ 2019-01-04 16:14 ` Yann E. MORIN
2019-01-05 14:09 ` Thomas Petazzoni
2019-06-23 19:41 ` Thomas Petazzoni
1 sibling, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2019-01-04 16:14 UTC (permalink / raw)
To: buildroot
Nicolas, All,
On 2019-01-04 16:49 +0100, Nicolas Cavallari spake thusly:
> Add option to install the MT7650 bluetooth firmware and the
> MT76x2e wifi firmware.
>
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
> ---
> package/linux-firmware/Config.in | 10 ++++++++++
> package/linux-firmware/linux-firmware.mk | 12 ++++++++++++
> 2 files changed, 22 insertions(+)
>
> diff --git a/package/linux-firmware/Config.in b/package/linux-firmware/Config.in
> index dcc8d4bade..3efb3d9050 100644
> --- a/package/linux-firmware/Config.in
> +++ b/package/linux-firmware/Config.in
> @@ -59,6 +59,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_QUALCOMM_6174A_BT
> help
> Firmware files for QCA Rome 6174A bluetooth support.
>
> +config BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_MT7650
> + bool "MediaTek MT7650"
> + help
> + Firmware files for MediaTek MT7650 bluetooth support
> +
> endmenu # Bluetooth
>
> menu "WiFi firmware"
> @@ -242,6 +247,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_MT7601U
> help
> MediaTek MT7601U
>
> +config BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_MT76X2E
> + bool "MediaTek MT76x2e"
> + help
> + MediaTek MT76x2e
We're trying to limit the number of options in each category, and given
there already is a wifi mediatek entry above, can we just make it install
all the mediatek wifi firmwares?
You'll need to:
- rename the option to BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_WIFI_MT7xxx;
note that I added 'WIfI' in the option name, because we can forsee
we'll have the same issue with BT firmwares, as they too are named
mt7*;
- add the old BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_MT7601U option to
Config.in.legacy, and select the new one;
- use the new option in linux-firmware.mk to install all the WiFi
firmware blobs.
Thanks! :-)
Regards,
Yann E. MORIN.
> config BR2_PACKAGE_LINUX_FIRMWARE_QUALCOMM_6174
> bool "Qualcomm Atheros 6174"
> help
> diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
> index ee02c7a030..c238d9f01b 100644
> --- a/package/linux-firmware/linux-firmware.mk
> +++ b/package/linux-firmware/linux-firmware.mk
> @@ -243,6 +243,18 @@ LINUX_FIRMWARE_FILES += mt7601u.bin
> LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.ralink_a_mediatek_company_firmware
> endif
>
> +# MT7650
> +ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_MT7650),y)
> +LINUX_FIRMWARE_FILES += mt7650.bin
> +LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.ralink_a_mediatek_company_firmware
> +endif
> +
> +# MT76x2e
> +ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_MT76X2E),y)
> +LINUX_FIRMWARE_FILES += mt7662.bin mt7662_rom_patch.bin
> +LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.ralink_a_mediatek_company_firmware
> +endif
> +
> # qca6174
> ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_QUALCOMM_6174),y)
> LINUX_FIRMWARE_FILES += ath10k/QCA6174
> --
> 2.20.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/1] linux-firmware: add options to install more Mediatek firmwares.
2019-01-04 16:14 ` Yann E. MORIN
@ 2019-01-05 14:09 ` Thomas Petazzoni
2019-01-05 21:39 ` Nicolas Cavallari
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-01-05 14:09 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 4 Jan 2019 17:14:04 +0100, Yann E. MORIN wrote:
> We're trying to limit the number of options in each category, and given
> there already is a wifi mediatek entry above, can we just make it install
> all the mediatek wifi firmwares?
I'm not sure I agree here. For other devices, we have a separate
option for each device. In addition, when you have a given WiFi device
in a system, you most likely only have this one, so the need for
installing one specific firmware is kind of the normal situationo.
> - rename the option to BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_WIFI_MT7xxx;
> note that I added 'WIfI' in the option name, because we can forsee
> we'll have the same issue with BT firmwares, as they too are named
> mt7*;
If you have a WiFi/BT combo chip, it's pretty likely that you will want
to install both the WiFi and BT firmwares, so having a single option
for both doesn't look that crazy.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] linux-firmware: add options to install more Mediatek firmwares.
2019-01-05 14:09 ` Thomas Petazzoni
@ 2019-01-05 21:39 ` Nicolas Cavallari
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Cavallari @ 2019-01-05 21:39 UTC (permalink / raw)
To: buildroot
On 05/01/2019 15:09, Thomas Petazzoni wrote:
> Hello,
>
> On Fri, 4 Jan 2019 17:14:04 +0100, Yann E. MORIN wrote:
>
>> We're trying to limit the number of options in each category, and given
>> there already is a wifi mediatek entry above, can we just make it install
>> all the mediatek wifi firmwares?
>
> I'm not sure I agree here.
(I probably should have waited before writing a patch doing exactly
that, hopefully i didn't tested it
I will just mention that "all the mediatek firmwares" also include more
files in linux-firmware's mediatek/ directory. But the situation there
is more complicated. the mt76/btmtk drivers are still under active
development, and they will stop using some firmware files.)
>> - rename the option to BR2_PACKAGE_LINUX_FIRMWARE_MEDIATEK_WIFI_MT7xxx;
>> note that I added 'WIfI' in the option name, because we can forsee
>> we'll have the same issue with BT firmwares, as they too are named
>> mt7*;
>
> If you have a WiFi/BT combo chip, it's pretty likely that you will want
> to install both the WiFi and BT firmwares, so having a single option
> for both doesn't look that crazy.
Well, currently the menuconfig for bluetooth and wifi are splitted.
And in this case, there is no firmware that is specific to a WiFi/BT
combo chip. The mt7662.bin file is used by both wifi and wifi/bt combos
and so is mt7650.bin for bt and wifi/bt.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] linux-firmware: add options to install more Mediatek firmwares.
2019-01-04 15:49 [Buildroot] [PATCH 1/1] linux-firmware: add options to install more Mediatek firmwares Nicolas Cavallari
2019-01-04 16:14 ` Yann E. MORIN
@ 2019-06-23 19:41 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2019-06-23 19:41 UTC (permalink / raw)
To: buildroot
On Fri, 4 Jan 2019 16:49:51 +0100
Nicolas Cavallari <nicolas.cavallari@green-communications.fr> wrote:
> Add option to install the MT7650 bluetooth firmware and the
> MT76x2e wifi firmware.
>
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
> ---
> package/linux-firmware/Config.in | 10 ++++++++++
> package/linux-firmware/linux-firmware.mk | 12 ++++++++++++
> 2 files changed, 22 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-23 19:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-04 15:49 [Buildroot] [PATCH 1/1] linux-firmware: add options to install more Mediatek firmwares Nicolas Cavallari
2019-01-04 16:14 ` Yann E. MORIN
2019-01-05 14:09 ` Thomas Petazzoni
2019-01-05 21:39 ` Nicolas Cavallari
2019-06-23 19:41 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox