Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/zbar: switch to linuxtv zbar fork
Date: Sun, 13 Jan 2019 14:35:04 +0100	[thread overview]
Message-ID: <20190113143504.0fd22fe4@windsurf.home> (raw)
In-Reply-To: <1547380110-7761-1-git-send-email-james.hilliard1@gmail.com>

Hello,

On Sun, 13 Jan 2019 19:48:30 +0800, james.hilliard1 at gmail.com wrote:
> From: James Hilliard <james.hilliard1@gmail.com>
> 
> The zbar upstream previously used has been abandoned since 2012.
> The linuxtv fork appears to be the most actively maintained fork.
> I've resynced patches that wouldn't apply and added a few minor bug fixes.

Please try to not use first person sentences in commit log. Also, it
would be good to explain why the current patch 0004 is removed.

> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  ...onf-by-reducing-the-warning-error-checkin.patch | 16 ++---
>  ...p-logical-not-operations-into-parentheses.patch | 80 ----------------------
>  ...eo-buffers-after-probing-and-request-them.patch | 51 ++++++++++++++
>  ...-ENOTTY-errors-when-calling-VIDIOC_S_CROP.patch | 26 +++++++

These patches are not just trivial build fixes. I'd like to see them be
submitted upstream. I suggest that you send them to Mauro + the
linux-media kernel mailing list in Cc, with some patch prefix such as
[PATCH zbar] so that it is clear to what project they apply.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-01-13 13:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-13 11:48 [Buildroot] [PATCH 1/1] package/zbar: switch to linuxtv zbar fork james.hilliard1 at gmail.com
2019-01-13 13:35 ` Thomas Petazzoni [this message]
2019-01-13 23:42   ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190113143504.0fd22fe4@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox