From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] boot/uboot: use HOSTCC_NOCCACHE as kconfig HOSTCC
Date: Sun, 13 Jan 2019 22:47:39 +0100 [thread overview]
Message-ID: <20190113214739.GL2428@scaer> (raw)
In-Reply-To: <20190110211500.14368-3-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2019-01-10 22:14 +0100, Thomas Petazzoni spake thusly:
> At kconfig time, dependencies are not built, and therefore host-ccache
> is not ready. Due to this, using $(HOSTCC) as the host compiler in
> KCONFIG_OPTS does not work: a "make uboot-menuconfig" invocation from
> a clean tree with ccache enabled fails.
>
> This commit fixes this by using $(HOSTCC_NOCCACHE). We cannot rely on
> the default value of HOSTCC passed by the kconfig-package
> infrastructure, because $(UBOOT_MAKE_OPTS) also contains a HOSTCC
> definition that would override the one passed by the kconfig-package
> infrastructure.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> boot/uboot/uboot.mk | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index cbdfee6ac3..6977bcc064 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -227,8 +227,9 @@ UBOOT_KCONFIG_EDITORS = menuconfig xconfig gconfig nconfig
> # (which is typically wchar) but link with
> # $(HOST_DIR)/lib/libncurses.so (which is not). We don't actually
> # need any host-package for kconfig, so remove the HOSTCC/HOSTLDFLAGS
> -# override again.
> -UBOOT_KCONFIG_OPTS = $(UBOOT_MAKE_OPTS) HOSTCC="$(HOSTCC)" HOSTLDFLAGS=""
> +# override again. In addition, host-ccache is not ready at kconfig
> +# time, so use HOSTCC_NOCCACHE.
> +UBOOT_KCONFIG_OPTS = $(UBOOT_MAKE_OPTS) HOSTCC="$(HOSTCC_NOCCACHE)" HOSTLDFLAGS=""
Since you're just switching over to the no-ccache variant:
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
However, I wonder if we would not be better off if we had written
something like;
UBOOT_KCONFIG_OPTS = $(filter-out HOSTCC=% HOSTLDFLAGS=%, $(UBOOT_MAKE_OPTS))
But this is another story. ;-)
Regards,
Yann E. MORIN.
> define UBOOT_HELP_CMDS
> @echo ' uboot-menuconfig - Run U-Boot menuconfig'
> @echo ' uboot-savedefconfig - Run U-Boot savedefconfig'
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-01-13 21:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 21:14 [Buildroot] [PATCH 0/3] Fix pkg-kconfig packages with ccache enabled Thomas Petazzoni
2019-01-10 21:14 ` [Buildroot] [PATCH 1/3] package/pkg-kconfig: pass HOSTCC during kconfig steps Thomas Petazzoni
2019-01-13 21:43 ` Yann E. MORIN
2019-01-16 22:39 ` Peter Korsgaard
2019-01-28 17:01 ` Peter Korsgaard
2019-01-10 21:14 ` [Buildroot] [PATCH 2/3] boot/uboot: use HOSTCC_NOCCACHE as kconfig HOSTCC Thomas Petazzoni
2019-01-13 21:47 ` Yann E. MORIN [this message]
2019-01-13 21:51 ` Yann E. MORIN
2019-01-24 16:12 ` Arnout Vandecappelle
2019-01-16 22:39 ` Peter Korsgaard
2019-01-28 17:01 ` Peter Korsgaard
2019-01-10 21:15 ` [Buildroot] [PATCH 3/3] linux: " Thomas Petazzoni
2019-01-13 21:50 ` Yann E. MORIN
2019-01-16 22:40 ` Peter Korsgaard
2019-01-28 17:01 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190113214739.GL2428@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox