Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/pkg-kconfig: pass HOSTCC during kconfig steps
Date: Mon, 28 Jan 2019 18:01:16 +0100	[thread overview]
Message-ID: <87sgxcemxv.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190110211500.14368-2-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Thu, 10 Jan 2019 22:14:58 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > The kconfig build logic uses the HOSTCC variable to find the host
 > compiler. It makes sense to explicitly pass a value to this variable,
 > pointing to the host compiler used by Buildroot.

 > During the kconfig step, host-ccache is not ready (host-ccache is only
 > a dependency to the configure step of packages), so we use
 > $(HOSTCC_NOCCACHE).

 > Packages currently using the kconfig-package fell into two categories:

 >  - Those not passing any HOSTCC value. For such packages, it was the
 >    default host compiler detected by the kconfig build logic that was
 >    used. ccache was therefore never used. With this commit, those
 >    packages will now be using the host compiler detected by
 >    Buildroot. Packages in this situation: at91bootstrap3, barebox,
 >    busybox, swupdate, uclibc, xvisor.

 >  - Those passing a HOSTCC value. Such packages were passing $(HOSTCC),
 >    which doesn't work as host-ccache will not be ready. This commit
 >    does not fix them, as they still override HOSTCC. It will be fixed
 >    in followup commits. Packages in this situation: uboot and
 >    linux. Note that linux was a bit special, because it has a
 >    KCONFIG_DEPENDENCIES on the toolchain package, so in fact
 >    host-ccache was ready.

 > So practically speaking, this commit does not fix anything, as the two
 > only problematic packages that use $(HOSTCC) are not fixed. However,
 > it makes things more correct by explicitly telling kconfig which
 > compiler to use.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed to 2018.11.x, thanks.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2019-01-28 17:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 21:14 [Buildroot] [PATCH 0/3] Fix pkg-kconfig packages with ccache enabled Thomas Petazzoni
2019-01-10 21:14 ` [Buildroot] [PATCH 1/3] package/pkg-kconfig: pass HOSTCC during kconfig steps Thomas Petazzoni
2019-01-13 21:43   ` Yann E. MORIN
2019-01-16 22:39   ` Peter Korsgaard
2019-01-28 17:01   ` Peter Korsgaard [this message]
2019-01-10 21:14 ` [Buildroot] [PATCH 2/3] boot/uboot: use HOSTCC_NOCCACHE as kconfig HOSTCC Thomas Petazzoni
2019-01-13 21:47   ` Yann E. MORIN
2019-01-13 21:51     ` Yann E. MORIN
2019-01-24 16:12       ` Arnout Vandecappelle
2019-01-16 22:39   ` Peter Korsgaard
2019-01-28 17:01   ` Peter Korsgaard
2019-01-10 21:15 ` [Buildroot] [PATCH 3/3] linux: " Thomas Petazzoni
2019-01-13 21:50   ` Yann E. MORIN
2019-01-16 22:40   ` Peter Korsgaard
2019-01-28 17:01   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgxcemxv.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox