Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] syslog-ng: fix builds with static libc
@ 2019-01-19  7:19 Chris Packham
  2019-01-19  7:19 ` [Buildroot] [PATCH 2/2] Revert "package/syslog-ng: depend on !BR2_STATIC_LIBS" Chris Packham
  2019-01-19  7:28 ` [Buildroot] [PATCH 1/2] syslog-ng: fix builds with static libc Chris Packham
  0 siblings, 2 replies; 4+ messages in thread
From: Chris Packham @ 2019-01-19  7:19 UTC (permalink / raw)
  To: buildroot

Bring in an upstream patch to fix builds for targets which lack dlfcn.h.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
 package/syslog-ng/syslog-ng.hash | 1 +
 package/syslog-ng/syslog-ng.mk   | 1 +
 2 files changed, 2 insertions(+)

diff --git a/package/syslog-ng/syslog-ng.hash b/package/syslog-ng/syslog-ng.hash
index 1f83e39ff0..69c94da02b 100644
--- a/package/syslog-ng/syslog-ng.hash
+++ b/package/syslog-ng/syslog-ng.hash
@@ -3,3 +3,4 @@ sha256 5cf931a9d7bead0e6d9a2c65eee8f6005a005878f59aa280f3c4294257ed5178  syslog-
 sha256 835219c8ca76156e6337236d1bcb8e617c0b1c2783b4a8bc478e18a86743d607  COPYING
 sha256 ce3324c9f22299cfc7c281e5a6ab40fbe9c2ea1a67cee87226cb8cd39db1e1d2  GPL.txt
 sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  LGPL.txt
+sha256 feb26f77921b42fa7e5468229d883c5fae0b349cd075013eec2cb071a677179b  d85121c0dc700cad4bd9735b0ee1dab9addf9dd7.patch
diff --git a/package/syslog-ng/syslog-ng.mk b/package/syslog-ng/syslog-ng.mk
index ecde9e8181..f96b97f30e 100644
--- a/package/syslog-ng/syslog-ng.mk
+++ b/package/syslog-ng/syslog-ng.mk
@@ -18,6 +18,7 @@ SYSLOG_NG_AUTORECONF = YES
 SYSLOG_NG_CONF_ENV = LIBS=-lrt
 SYSLOG_NG_CONF_OPTS = --disable-manpages --localstatedir=/var/run \
 	--disable-java --disable-java-modules --disable-mongodb
+SYSLOG_NG_PATCH = https://github.com/balabit/syslog-ng/commit/d85121c0dc700cad4bd9735b0ee1dab9addf9dd7.patch
 
 ifeq ($(BR2_PACKAGE_GEOIP),y)
 SYSLOG_NG_DEPENDENCIES += geoip
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] Revert "package/syslog-ng: depend on !BR2_STATIC_LIBS"
  2019-01-19  7:19 [Buildroot] [PATCH 1/2] syslog-ng: fix builds with static libc Chris Packham
@ 2019-01-19  7:19 ` Chris Packham
  2019-01-19  7:28 ` [Buildroot] [PATCH 1/2] syslog-ng: fix builds with static libc Chris Packham
  1 sibling, 0 replies; 4+ messages in thread
From: Chris Packham @ 2019-01-19  7:19 UTC (permalink / raw)
  To: buildroot

This reverts commit 44dbd2907c5995b0b0c56cb2274dc60415205dd8. Now that
upstream has different fix for the build issues with a static libc we
can re-enable syslog-ng on these systems.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
 package/syslog-ng/Config.in | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/package/syslog-ng/Config.in b/package/syslog-ng/Config.in
index 6407645974..fbc236221a 100644
--- a/package/syslog-ng/Config.in
+++ b/package/syslog-ng/Config.in
@@ -3,7 +3,6 @@ config BR2_PACKAGE_SYSLOG_NG
 	depends on BR2_USE_WCHAR # glib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # fork()
-	depends on !BR2_STATIC_LIBS # dlfcn.h
 	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	select BR2_PACKAGE_EVENTLOG
 	select BR2_PACKAGE_LIBGLIB2
@@ -16,8 +15,7 @@ config BR2_PACKAGE_SYSLOG_NG
 
 	  https://syslog-ng.org/
 
-comment "syslog-ng needs a toolchain w/ dynamic library, wchar, threads"
+comment "syslog-ng needs a toolchain w/ wchar, threads"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
-		BR2_STATIC_LIBS
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/2] syslog-ng: fix builds with static libc
  2019-01-19  7:19 [Buildroot] [PATCH 1/2] syslog-ng: fix builds with static libc Chris Packham
  2019-01-19  7:19 ` [Buildroot] [PATCH 2/2] Revert "package/syslog-ng: depend on !BR2_STATIC_LIBS" Chris Packham
@ 2019-01-19  7:28 ` Chris Packham
  2019-01-24 12:54   ` Carlos Santos
  1 sibling, 1 reply; 4+ messages in thread
From: Chris Packham @ 2019-01-19  7:28 UTC (permalink / raw)
  To: buildroot

On Sat, Jan 19, 2019 at 8:20 PM Chris Packham <judge.packham@gmail.com> wrote:
>
> Bring in an upstream patch to fix builds for targets which lack dlfcn.h.
>

Probably should have added

Fixes:
- http://autobuild.buildroot.net/results/c0bca852e053cd0e021205b3a949e750ae602333/

Let me know if you want me to send a v2.

> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
>  package/syslog-ng/syslog-ng.hash | 1 +
>  package/syslog-ng/syslog-ng.mk   | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/package/syslog-ng/syslog-ng.hash b/package/syslog-ng/syslog-ng.hash
> index 1f83e39ff0..69c94da02b 100644
> --- a/package/syslog-ng/syslog-ng.hash
> +++ b/package/syslog-ng/syslog-ng.hash
> @@ -3,3 +3,4 @@ sha256 5cf931a9d7bead0e6d9a2c65eee8f6005a005878f59aa280f3c4294257ed5178  syslog-
>  sha256 835219c8ca76156e6337236d1bcb8e617c0b1c2783b4a8bc478e18a86743d607  COPYING
>  sha256 ce3324c9f22299cfc7c281e5a6ab40fbe9c2ea1a67cee87226cb8cd39db1e1d2  GPL.txt
>  sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  LGPL.txt
> +sha256 feb26f77921b42fa7e5468229d883c5fae0b349cd075013eec2cb071a677179b  d85121c0dc700cad4bd9735b0ee1dab9addf9dd7.patch
> diff --git a/package/syslog-ng/syslog-ng.mk b/package/syslog-ng/syslog-ng.mk
> index ecde9e8181..f96b97f30e 100644
> --- a/package/syslog-ng/syslog-ng.mk
> +++ b/package/syslog-ng/syslog-ng.mk
> @@ -18,6 +18,7 @@ SYSLOG_NG_AUTORECONF = YES
>  SYSLOG_NG_CONF_ENV = LIBS=-lrt
>  SYSLOG_NG_CONF_OPTS = --disable-manpages --localstatedir=/var/run \
>         --disable-java --disable-java-modules --disable-mongodb
> +SYSLOG_NG_PATCH = https://github.com/balabit/syslog-ng/commit/d85121c0dc700cad4bd9735b0ee1dab9addf9dd7.patch
>
>  ifeq ($(BR2_PACKAGE_GEOIP),y)
>  SYSLOG_NG_DEPENDENCIES += geoip
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/2] syslog-ng: fix builds with static libc
  2019-01-19  7:28 ` [Buildroot] [PATCH 1/2] syslog-ng: fix builds with static libc Chris Packham
@ 2019-01-24 12:54   ` Carlos Santos
  0 siblings, 0 replies; 4+ messages in thread
From: Carlos Santos @ 2019-01-24 12:54 UTC (permalink / raw)
  To: buildroot

> From: "Chris Packham" <judge.packham@gmail.com>
> To: "buildroot" <buildroot@buildroot.org>
> Cc: "Carlos Santos" <casantos@datacom.com.br>
> Sent: S?bado, 19 de janeiro de 2019 5:28:16
> Subject: Re: [PATCH 1/2] syslog-ng: fix builds with static libc

> On Sat, Jan 19, 2019 at 8:20 PM Chris Packham <judge.packham@gmail.com> wrote:
>>
>> Bring in an upstream patch to fix builds for targets which lack dlfcn.h.
>>
> 
> Probably should have added
> 
> Fixes:
> -
> http://autobuild.buildroot.net/results/c0bca852e053cd0e021205b3a949e750ae602333/
> 
> Let me know if you want me to send a v2.

Yes, please. I also believe that all files should be updated in a single
patch, since the change in Config.in does not make sense without the other
ones.

-- 
Carlos Santos (Casantos) - DATACOM, P&D

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-24 12:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-19  7:19 [Buildroot] [PATCH 1/2] syslog-ng: fix builds with static libc Chris Packham
2019-01-19  7:19 ` [Buildroot] [PATCH 2/2] Revert "package/syslog-ng: depend on !BR2_STATIC_LIBS" Chris Packham
2019-01-19  7:28 ` [Buildroot] [PATCH 1/2] syslog-ng: fix builds with static libc Chris Packham
2019-01-24 12:54   ` Carlos Santos

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox