* [Buildroot] [PATCH 1/2] support/scripts/graph-build-time: add download times
@ 2019-01-30 20:11 Thomas De Schampheleire
2019-01-30 20:11 ` [Buildroot] [PATCH 2/2] support/scripts/graph-build-time: replace confusing colors Thomas De Schampheleire
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Thomas De Schampheleire @ 2019-01-30 20:11 UTC (permalink / raw)
To: buildroot
From: Mathias De Mare <mathias.de_mare@nokia.com>
Total build time also involves download. Getting a visibility on the impact
of that step can be important for users/admins, e.g. to evaluate different
methods of BR2_PRIMARY_SITE.
Colors used are some kind of purple (primary scheme) and light orange
(alternate scheme).
Signed-off-by: Mathias De Mar? <mathias.de_mare@nokia.com>
[ThomasDS: rebase and update colors to avoid confusion]
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
support/scripts/graph-build-time | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/support/scripts/graph-build-time b/support/scripts/graph-build-time
index 892e08bf07..2fdb6a476d 100755
--- a/support/scripts/graph-build-time
+++ b/support/scripts/graph-build-time
@@ -69,14 +69,14 @@ import matplotlib.font_manager as fm # noqa: E402
import csv # noqa: E402
import argparse # noqa: E402
-steps = ['extract', 'patch', 'configure', 'build',
+steps = ['download', 'extract', 'patch', 'configure', 'build',
'install-target', 'install-staging', 'install-images',
'install-host']
-default_colors = ['#e60004', '#009836', '#2e1d86', '#ffed00',
+default_colors = ['#8d02ff', '#e60004', '#009836', '#2e1d86', '#ffed00',
'#0068b5', '#f28e00', '#940084', '#97c000']
-alternate_colors = ['#00e0e0', '#3f7f7f', '#ff0000', '#00c000',
+alternate_colors = ['#ffbe0a', '#00e0e0', '#3f7f7f', '#ff0000', '#00c000',
'#0080ff', '#c000ff', '#00eeee', '#e0e000']
--
2.19.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 2/2] support/scripts/graph-build-time: replace confusing colors
2019-01-30 20:11 [Buildroot] [PATCH 1/2] support/scripts/graph-build-time: add download times Thomas De Schampheleire
@ 2019-01-30 20:11 ` Thomas De Schampheleire
2019-02-04 11:07 ` Matthew Weber
2019-02-04 10:56 ` [Buildroot] [PATCH 1/2] support/scripts/graph-build-time: add download times Matthew Weber
2019-02-04 14:24 ` Arnout Vandecappelle
2 siblings, 1 reply; 6+ messages in thread
From: Thomas De Schampheleire @ 2019-01-30 20:11 UTC (permalink / raw)
To: buildroot
From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
The color for 'extract' is very similar to the one for 'install-images'.
Both are cyan-like.
Replace the former by a pale blue to make all colors sufficiently distinct.
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
support/scripts/graph-build-time | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/support/scripts/graph-build-time b/support/scripts/graph-build-time
index 2fdb6a476d..ba3cdad85b 100755
--- a/support/scripts/graph-build-time
+++ b/support/scripts/graph-build-time
@@ -76,7 +76,7 @@ steps = ['download', 'extract', 'patch', 'configure', 'build',
default_colors = ['#8d02ff', '#e60004', '#009836', '#2e1d86', '#ffed00',
'#0068b5', '#f28e00', '#940084', '#97c000']
-alternate_colors = ['#ffbe0a', '#00e0e0', '#3f7f7f', '#ff0000', '#00c000',
+alternate_colors = ['#ffbe0a', '#96bdff', '#3f7f7f', '#ff0000', '#00c000',
'#0080ff', '#c000ff', '#00eeee', '#e0e000']
--
2.19.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 2/2] support/scripts/graph-build-time: replace confusing colors
2019-01-30 20:11 ` [Buildroot] [PATCH 2/2] support/scripts/graph-build-time: replace confusing colors Thomas De Schampheleire
@ 2019-02-04 11:07 ` Matthew Weber
2019-02-04 12:48 ` Thomas De Schampheleire
0 siblings, 1 reply; 6+ messages in thread
From: Matthew Weber @ 2019-02-04 11:07 UTC (permalink / raw)
To: buildroot
Thomas De,
On Wed, Jan 30, 2019 at 2:12 PM Thomas De Schampheleire
<patrickdepinguin@gmail.com> wrote:
>
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
>
> The color for 'extract' is very similar to the one for 'install-images'.
> Both are cyan-like.
>
> Replace the former by a pale blue to make all colors sufficiently distinct.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
A bit trickier to test and get a install images with enough time to
visually see it :-)
Tested-by: Matthew Weber <matthew.weber@rockwellcollins.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] support/scripts/graph-build-time: replace confusing colors
2019-02-04 11:07 ` Matthew Weber
@ 2019-02-04 12:48 ` Thomas De Schampheleire
0 siblings, 0 replies; 6+ messages in thread
From: Thomas De Schampheleire @ 2019-02-04 12:48 UTC (permalink / raw)
To: buildroot
El lun., 4 feb. 2019 a las 12:07, Matthew Weber
(<matthew.weber@collins.com>) escribi?:
>
> Thomas De,
>
> On Wed, Jan 30, 2019 at 2:12 PM Thomas De Schampheleire
> <patrickdepinguin@gmail.com> wrote:
> >
> > From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> >
> > The color for 'extract' is very similar to the one for 'install-images'.
> > Both are cyan-like.
> >
> > Replace the former by a pale blue to make all colors sufficiently distinct.
> >
> > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
>
> A bit trickier to test and get a install images with enough time to
> visually see it :-)
I spoofed the build-time.log file when testing :-)
/Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] support/scripts/graph-build-time: add download times
2019-01-30 20:11 [Buildroot] [PATCH 1/2] support/scripts/graph-build-time: add download times Thomas De Schampheleire
2019-01-30 20:11 ` [Buildroot] [PATCH 2/2] support/scripts/graph-build-time: replace confusing colors Thomas De Schampheleire
@ 2019-02-04 10:56 ` Matthew Weber
2019-02-04 14:24 ` Arnout Vandecappelle
2 siblings, 0 replies; 6+ messages in thread
From: Matthew Weber @ 2019-02-04 10:56 UTC (permalink / raw)
To: buildroot
Thomas De,
On Wed, Jan 30, 2019 at 2:12 PM Thomas De Schampheleire
<patrickdepinguin@gmail.com> wrote:
>
> From: Mathias De Mare <mathias.de_mare@nokia.com>
>
> Total build time also involves download. Getting a visibility on the impact
> of that step can be important for users/admins, e.g. to evaluate different
> methods of BR2_PRIMARY_SITE.
>
> Colors used are some kind of purple (primary scheme) and light orange
> (alternate scheme).
>
> Signed-off-by: Mathias De Mar? <mathias.de_mare@nokia.com>
> [ThomasDS: rebase and update colors to avoid confusion]
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Cool stat :-) This will be interesting to run and see what is not
hitting my caching server vs raw Internet.
Tested-by: Matthew Weber <matthew.weber@rockwellcollins.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] support/scripts/graph-build-time: add download times
2019-01-30 20:11 [Buildroot] [PATCH 1/2] support/scripts/graph-build-time: add download times Thomas De Schampheleire
2019-01-30 20:11 ` [Buildroot] [PATCH 2/2] support/scripts/graph-build-time: replace confusing colors Thomas De Schampheleire
2019-02-04 10:56 ` [Buildroot] [PATCH 1/2] support/scripts/graph-build-time: add download times Matthew Weber
@ 2019-02-04 14:24 ` Arnout Vandecappelle
2 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2019-02-04 14:24 UTC (permalink / raw)
To: buildroot
On 30/01/2019 21:11, Thomas De Schampheleire wrote:
> From: Mathias De Mare <mathias.de_mare@nokia.com>
>
> Total build time also involves download. Getting a visibility on the impact
> of that step can be important for users/admins, e.g. to evaluate different
> methods of BR2_PRIMARY_SITE.
>
> Colors used are some kind of purple (primary scheme) and light orange
> (alternate scheme).
>
> Signed-off-by: Mathias De Mar? <mathias.de_mare@nokia.com>
> [ThomasDS: rebase and update colors to avoid confusion]
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Both applied to master, thanks.
Regards,
Arnout
> ---
> support/scripts/graph-build-time | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/support/scripts/graph-build-time b/support/scripts/graph-build-time
> index 892e08bf07..2fdb6a476d 100755
> --- a/support/scripts/graph-build-time
> +++ b/support/scripts/graph-build-time
> @@ -69,14 +69,14 @@ import matplotlib.font_manager as fm # noqa: E402
> import csv # noqa: E402
> import argparse # noqa: E402
>
> -steps = ['extract', 'patch', 'configure', 'build',
> +steps = ['download', 'extract', 'patch', 'configure', 'build',
> 'install-target', 'install-staging', 'install-images',
> 'install-host']
>
> -default_colors = ['#e60004', '#009836', '#2e1d86', '#ffed00',
> +default_colors = ['#8d02ff', '#e60004', '#009836', '#2e1d86', '#ffed00',
> '#0068b5', '#f28e00', '#940084', '#97c000']
>
> -alternate_colors = ['#00e0e0', '#3f7f7f', '#ff0000', '#00c000',
> +alternate_colors = ['#ffbe0a', '#00e0e0', '#3f7f7f', '#ff0000', '#00c000',
> '#0080ff', '#c000ff', '#00eeee', '#e0e000']
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-04 14:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-30 20:11 [Buildroot] [PATCH 1/2] support/scripts/graph-build-time: add download times Thomas De Schampheleire
2019-01-30 20:11 ` [Buildroot] [PATCH 2/2] support/scripts/graph-build-time: replace confusing colors Thomas De Schampheleire
2019-02-04 11:07 ` Matthew Weber
2019-02-04 12:48 ` Thomas De Schampheleire
2019-02-04 10:56 ` [Buildroot] [PATCH 1/2] support/scripts/graph-build-time: add download times Matthew Weber
2019-02-04 14:24 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox