From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 17/17] package/liquid-dsp: drop support for fftw-double and fftw-long-double
Date: Tue, 5 Feb 2019 22:09:40 +0100 [thread overview]
Message-ID: <20190205220940.3dbda336@windsurf> (raw)
In-Reply-To: <1548078671-63318-17-git-send-email-gwenj@trabucayre.com>
Hello,
On Mon, 21 Jan 2019 14:51:11 +0100
Gwenhael Goavec-Merou <gwenj@trabucayre.com> wrote:
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> liquid-dsp has the following code:
> #if HAVE_FFTW3_H && !defined LIQUID_FFTOVERRIDE
> # include <fftw3.h>
> # define FFT_PLAN fftwf_plan
> # define FFT_CREATE_PLAN fftwf_plan_dft_1d
> # define FFT_DESTROY_PLAN fftwf_destroy_plan
> # define FFT_EXECUTE fftwf_execute
> # define FFT_DIR_FORWARD FFTW_FORWARD
> # define FFT_DIR_BACKWARD FFTW_BACKWARD
> # define FFT_METHOD FFTW_ESTIMATE
> #else
> # define FFT_PLAN fftplan
> # define FFT_CREATE_PLAN fft_create_plan
> # define FFT_DESTROY_PLAN fft_destroy_plan
> # define FFT_EXECUTE fft_execute
> # define FFT_DIR_FORWARD LIQUID_FFT_FORWARD
> # define FFT_DIR_BACKWARD LIQUID_FFT_BACKWARD
> # define FFT_METHOD 0
> #endif
>
> So, if it uses the external fftw library, it can only use the fftwf
> variant, i.e the fftw-single variant. Otherwise, it uses its internal
> FFT library.
>
> There is no way for liquid-dsp to use fftw-double or fftw-long-double.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> ---
> package/liquid-dsp/liquid-dsp.mk | 10 ----------
> 1 file changed, 10 deletions(-)
Applied to master, thanks. I have applied *before* all other patches,
because it's really a preparation fix that is useful independently from
the rest of the FFTW rework.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-02-05 21:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 13:50 [Buildroot] [PATCH v4 01/17] package/fftw: prepare for splitting into multiple packages Gwenhael Goavec-Merou
2019-01-21 13:50 ` [Buildroot] [PATCH v4 02/17] package/fftw: break fftw-single into a dedicated package Gwenhael Goavec-Merou
2019-01-21 13:50 ` [Buildroot] [PATCH v4 03/17] package/fftw: break fftw-long-double " Gwenhael Goavec-Merou
2019-01-21 13:50 ` [Buildroot] [PATCH v4 04/17] package/fftw: break fftw-quad " Gwenhael Goavec-Merou
2019-01-21 13:50 ` [Buildroot] [PATCH v4 05/17] package/fftw: break fftw-double " Gwenhael Goavec-Merou
2019-01-21 13:51 ` [Buildroot] [PATCH v4 06/17] package/alsa-utils: use the new fftw-single package Gwenhael Goavec-Merou
2019-01-21 13:51 ` [Buildroot] [PATCH v4 07/17] package/aubio: use the new fftw-double and fftw-single packages Gwenhael Goavec-Merou
2019-01-21 13:51 ` [Buildroot] [PATCH v4 08/17] package/gnuradio: use the new fftw-single package Gwenhael Goavec-Merou
2019-01-21 13:51 ` [Buildroot] [PATCH v4 09/17] package/gqrx: remove unneeded fftw dependency Gwenhael Goavec-Merou
2019-01-21 13:51 ` [Buildroot] [PATCH v4 10/17] package/hackrf: use the new fftw-single package Gwenhael Goavec-Merou
2019-01-21 13:51 ` [Buildroot] [PATCH v4 11/17] package/httping: use the new fftw-double package Gwenhael Goavec-Merou
2019-01-21 13:51 ` [Buildroot] [PATCH v4 12/17] package/imagemagick: " Gwenhael Goavec-Merou
2019-01-21 13:51 ` [Buildroot] [PATCH v4 13/17] package/libvips: " Gwenhael Goavec-Merou
2019-01-21 13:51 ` [Buildroot] [PATCH v4 14/17] package/pulseaudio: use the new fftw-single package Gwenhael Goavec-Merou
2019-01-21 13:51 ` [Buildroot] [PATCH v4 15/17] package/liquid-dsp: use the new fftw-{single, double, long-double} packages Gwenhael Goavec-Merou
2019-01-21 13:51 ` [Buildroot] [PATCH v4 16/17] package/fftw: remove as regular package Gwenhael Goavec-Merou
2019-01-21 13:51 ` [Buildroot] [PATCH v4 17/17] package/liquid-dsp: drop support for fftw-double and fftw-long-double Gwenhael Goavec-Merou
2019-02-05 21:09 ` Thomas Petazzoni [this message]
2019-02-06 5:40 ` Baruch Siach
2019-02-06 8:36 ` Thomas Petazzoni
2019-02-02 17:16 ` [Buildroot] [PATCH v4 16/17] package/fftw: remove as regular package Yann E. MORIN
2019-02-06 9:23 ` Thomas Petazzoni
2019-02-02 22:08 ` Yann E. MORIN
2019-02-02 16:54 ` [Buildroot] [PATCH v4 15/17] package/liquid-dsp: use the new fftw-{single, double, long-double} packages Yann E. MORIN
2019-02-02 16:45 ` [Buildroot] [PATCH v4 14/17] package/pulseaudio: use the new fftw-single package Yann E. MORIN
2019-02-02 16:44 ` [Buildroot] [PATCH v4 13/17] package/libvips: use the new fftw-double package Yann E. MORIN
2019-02-02 16:42 ` [Buildroot] [PATCH v4 12/17] package/imagemagick: " Yann E. MORIN
2019-02-02 16:41 ` [Buildroot] [PATCH v4 11/17] package/httping: " Yann E. MORIN
2019-02-02 16:40 ` [Buildroot] [PATCH v4 09/17] package/gqrx: remove unneeded fftw dependency Yann E. MORIN
2019-02-02 16:34 ` [Buildroot] [PATCH v4 08/17] package/gnuradio: use the new fftw-single package Yann E. MORIN
2019-02-02 14:52 ` [Buildroot] [PATCH v4 07/17] package/aubio: use the new fftw-double and fftw-single packages Yann E. MORIN
2019-02-02 14:38 ` [Buildroot] [PATCH v4 04/17] package/fftw: break fftw-quad into a dedicated package Yann E. MORIN
2019-02-06 9:16 ` [Buildroot] [PATCH v4 01/17] package/fftw: prepare for splitting into multiple packages Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205220940.3dbda336@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox