From: aduskett at gmail.com <aduskett@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v10 3/6] package/qemu: drop host kernel version check
Date: Wed, 6 Feb 2019 04:15:28 -0500 [thread overview]
Message-ID: <20190206091531.104591-3-aduskett@gmail.com> (raw)
In-Reply-To: <20190206091531.104591-1-aduskett@gmail.com>
From: Adam Duskett <Aduskett@gmail.com>
There is no clean way to check if a program will actually run using host-qemu,
making this check too restrictive.
Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
Changes v1 -> v10:
- Add this patch to the series.
package/qemu/qemu.mk | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 30cd5972ef..4ce8c129ea 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -226,28 +226,6 @@ ifneq ($(HOST_QEMU_HOST_SYSTEM_TYPE),Linux)
$(error "qemu-user can only be used on Linux hosts")
endif
-# kernel version as major*256 + minor
-HOST_QEMU_HOST_SYSTEM_VERSION = $(shell uname -r | awk -F. '{ print $$1 * 256 + $$2 }')
-HOST_QEMU_TARGET_SYSTEM_VERSION = $(shell echo $(BR2_TOOLCHAIN_HEADERS_AT_LEAST) | awk -F. '{ print $$1 * 256 + $$2 }')
-HOST_QEMU_COMPARE_VERSION = $(shell test $(HOST_QEMU_HOST_SYSTEM_VERSION) -ge $(HOST_QEMU_TARGET_SYSTEM_VERSION) && echo OK)
-
-#
-# The principle of qemu-user is that it emulates the instructions of
-# the target architecture when running the binary, and then when this
-# binary does a system call, it converts this system call into a
-# system call on the host machine. This mechanism makes an assumption:
-# that the target binary will not do system calls that do not exist on
-# the host. This basically requires that the target binary should be
-# built with kernel headers that are older or the same as the kernel
-# version running on the host machine.
-#
-
-ifeq ($(BR_BUILDING),y)
-ifneq ($(HOST_QEMU_COMPARE_VERSION),OK)
-$(error "Refusing to build qemu-user: target Linux version newer than host's.")
-endif
-endif # BR_BUILDING
-
else # BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE
HOST_QEMU_OPTS += --disable-linux-user
endif # BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE
--
2.20.1
next prev parent reply other threads:[~2019-02-06 9:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 9:15 [Buildroot] [PATCH v10 1/6] binutils: install libiberty for host build aduskett at gmail.com
2019-02-06 9:15 ` [Buildroot] [PATCH v10 2/6] prelink-cross: new package aduskett at gmail.com
2019-03-17 9:43 ` Thomas Petazzoni
2019-02-06 9:15 ` aduskett at gmail.com [this message]
2019-02-06 9:15 ` [Buildroot] [PATCH v10 4/6] gobject-introspection: " aduskett at gmail.com
2019-02-06 9:15 ` [Buildroot] [PATCH v10 5/6] package/pkg-autotools.mk: Add PKG_GIR_EXTRA_LIBS_PATH variable aduskett at gmail.com
2019-03-17 8:57 ` Yann E. MORIN
2019-03-17 9:23 ` Yann E. MORIN
2019-02-06 9:15 ` [Buildroot] [PATCH v10 6/6] gstreamer1 packages: add support for introspection aduskett at gmail.com
2019-03-17 11:38 ` Yann E. MORIN
2019-03-17 9:42 ` [Buildroot] [PATCH v10 1/6] binutils: install libiberty for host build Thomas Petazzoni
2019-03-18 4:50 ` James Hilliard
2019-03-18 22:03 ` Yann E. MORIN
2019-03-19 18:08 ` Arnout Vandecappelle
2019-03-19 20:48 ` Yann E. MORIN
2019-03-19 21:17 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206091531.104591-3-aduskett@gmail.com \
--to=aduskett@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox