From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v10 5/6] package/pkg-autotools.mk: Add PKG_GIR_EXTRA_LIBS_PATH variable
Date: Sun, 17 Mar 2019 09:57:32 +0100 [thread overview]
Message-ID: <20190317085732.GA4361@scaer> (raw)
In-Reply-To: <20190206091531.104591-5-aduskett@gmail.com>
Adam, All,
On 2019-02-06 04:15 -0500, aduskett at gmail.com spake thusly:
> From: Adam Duskett <Aduskett@gmail.com>
>
> Some packages require passing an extra libs path to gobject-introspection
> in order to compile their respective typelib files. This allows users to
> specify a PKG_GIR_EXTRA_LIBS_PATH variable in the respective packages mk file
> that will then be passed on to the g-ir-scanner, allowing those directory paths
> to be indexed.
>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
> Changes v1 -> v10:
> - Add this patch to the series.
>
> package/pkg-autotools.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
> index 45de99356f..06021f95c1 100644
> --- a/package/pkg-autotools.mk
> +++ b/package/pkg-autotools.mk
> @@ -162,6 +162,7 @@ endif
>
> $(2)_CONF_ENV ?=
> $(2)_CONF_OPTS ?=
> +$(2)_GIR_EXTRA_LIBS_PATH ?=
> $(2)_MAKE_ENV ?=
> $(2)_MAKE_OPTS ?=
> $(2)_INSTALL_OPTS ?= install
> @@ -239,6 +240,8 @@ endef
> endif
> endif
>
> +export GIR_EXTRA_LIBS_PATH=$$($$(PKG)_GIR_EXTRA_LIBS_PATH)
How can this even work?
The value of GIR_EXTRA_LIBS_PATH will be that of the last package
parsed, and this is robably not what you really intended.
If a package needs to pass extra environment variables, there is already
this (at least for most of our package infras, I believe):
FOO_CONF_ENV
FOO_MAKE_ENV
... which packages can set to add environment variables.
Regards,
Yann E. MORIN.
> $(2)_POST_PATCH_HOOKS += UPDATE_CONFIG_HOOK
>
> ifeq ($$($(2)_AUTORECONF),YES)
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-03-17 8:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 9:15 [Buildroot] [PATCH v10 1/6] binutils: install libiberty for host build aduskett at gmail.com
2019-02-06 9:15 ` [Buildroot] [PATCH v10 2/6] prelink-cross: new package aduskett at gmail.com
2019-03-17 9:43 ` Thomas Petazzoni
2019-02-06 9:15 ` [Buildroot] [PATCH v10 3/6] package/qemu: drop host kernel version check aduskett at gmail.com
2019-02-06 9:15 ` [Buildroot] [PATCH v10 4/6] gobject-introspection: new package aduskett at gmail.com
2019-02-06 9:15 ` [Buildroot] [PATCH v10 5/6] package/pkg-autotools.mk: Add PKG_GIR_EXTRA_LIBS_PATH variable aduskett at gmail.com
2019-03-17 8:57 ` Yann E. MORIN [this message]
2019-03-17 9:23 ` Yann E. MORIN
2019-02-06 9:15 ` [Buildroot] [PATCH v10 6/6] gstreamer1 packages: add support for introspection aduskett at gmail.com
2019-03-17 11:38 ` Yann E. MORIN
2019-03-17 9:42 ` [Buildroot] [PATCH v10 1/6] binutils: install libiberty for host build Thomas Petazzoni
2019-03-18 4:50 ` James Hilliard
2019-03-18 22:03 ` Yann E. MORIN
2019-03-19 18:08 ` Arnout Vandecappelle
2019-03-19 20:48 ` Yann E. MORIN
2019-03-19 21:17 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190317085732.GA4361@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox