* [Buildroot] [PATCH v1] package/qwt: needs qt5base gui support @ 2019-02-15 20:25 Peter Seiderer 2019-02-15 20:43 ` Thomas Petazzoni 0 siblings, 1 reply; 5+ messages in thread From: Peter Seiderer @ 2019-02-15 20:25 UTC (permalink / raw) To: buildroot Fixes the following qt5base configure error ([1]): ERROR: Feature 'widgets' was enabled, but the pre-condition 'features.gui' failed. [1] http://autobuild.buildroot.net/results/c771c2d5aac3e21f908e5a118f3755dbc9301a47 Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- package/qwt/Config.in | 1 + 1 file changed, 1 insertion(+) diff --git a/package/qwt/Config.in b/package/qwt/Config.in index f4132c8638..2e9cec19d7 100644 --- a/package/qwt/Config.in +++ b/package/qwt/Config.in @@ -2,6 +2,7 @@ config BR2_PACKAGE_QWT bool "qwt" depends on BR2_PACKAGE_QT5 select BR2_PACKAGE_QT5BASE + select BR2_PACKAGE_QT5BASE_GUI select BR2_PACKAGE_QT5BASE_WIDGETS # printsupport select BR2_PACKAGE_QT5BASE_CONCURRENT help -- 2.20.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v1] package/qwt: needs qt5base gui support 2019-02-15 20:25 [Buildroot] [PATCH v1] package/qwt: needs qt5base gui support Peter Seiderer @ 2019-02-15 20:43 ` Thomas Petazzoni 2019-02-15 20:58 ` Peter Seiderer 0 siblings, 1 reply; 5+ messages in thread From: Thomas Petazzoni @ 2019-02-15 20:43 UTC (permalink / raw) To: buildroot Hello Peter, On Fri, 15 Feb 2019 21:25:04 +0100 Peter Seiderer <ps.report@gmx.net> wrote: > Fixes the following qt5base configure error ([1]): > > ERROR: Feature 'widgets' was enabled, but the pre-condition 'features.gui' failed. > > [1] http://autobuild.buildroot.net/results/c771c2d5aac3e21f908e5a118f3755dbc9301a47 > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > --- > package/qwt/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/qwt/Config.in b/package/qwt/Config.in > index f4132c8638..2e9cec19d7 100644 > --- a/package/qwt/Config.in > +++ b/package/qwt/Config.in > @@ -2,6 +2,7 @@ config BR2_PACKAGE_QWT > bool "qwt" > depends on BR2_PACKAGE_QT5 > select BR2_PACKAGE_QT5BASE > + select BR2_PACKAGE_QT5BASE_GUI Hm, the build error happens in qt5base, and to me reads as "if you have widgets support enabled in qt5base, you must have gui support enabled in qt5base". If that is what is happening, then what you want to do is have BR2_PACKAGE_QT5BASE_WIDGETS sleect BR2_PACKAGE_QT5BASE_GUI, and not touch qwt. Indeed, to me, it seems like any other package that uses qt5 widgets without selecting qt5 gui would fall into the same build failure. Also, any idea why this is popping up only now ? Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v1] package/qwt: needs qt5base gui support 2019-02-15 20:43 ` Thomas Petazzoni @ 2019-02-15 20:58 ` Peter Seiderer 2019-02-15 21:40 ` Thomas Petazzoni 0 siblings, 1 reply; 5+ messages in thread From: Peter Seiderer @ 2019-02-15 20:58 UTC (permalink / raw) To: buildroot Hello Thomas, On Fri, 15 Feb 2019 21:43:43 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > Hello Peter, > > On Fri, 15 Feb 2019 21:25:04 +0100 > Peter Seiderer <ps.report@gmx.net> wrote: > > > Fixes the following qt5base configure error ([1]): > > > > ERROR: Feature 'widgets' was enabled, but the pre-condition 'features.gui' failed. > > > > [1] http://autobuild.buildroot.net/results/c771c2d5aac3e21f908e5a118f3755dbc9301a47 > > > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > > --- > > package/qwt/Config.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/package/qwt/Config.in b/package/qwt/Config.in > > index f4132c8638..2e9cec19d7 100644 > > --- a/package/qwt/Config.in > > +++ b/package/qwt/Config.in > > @@ -2,6 +2,7 @@ config BR2_PACKAGE_QWT > > bool "qwt" > > depends on BR2_PACKAGE_QT5 > > select BR2_PACKAGE_QT5BASE > > + select BR2_PACKAGE_QT5BASE_GUI > > Hm, the build error happens in qt5base, and to me reads as "if you have > widgets support enabled in qt5base, you must have gui support enabled > in qt5base". If that is what is happening, then what you want to do is > have BR2_PACKAGE_QT5BASE_WIDGETS sleect BR2_PACKAGE_QT5BASE_GUI, and > not touch qwt. Because until now qwt is the only package selecting widgets without gui (most packages directly, pulseview via qt5svg and qt5cinex via qt5base eglfs)...and from qt5base/Config.in: if BR2_PACKAGE_QT5BASE_GUI config BR2_PACKAGE_QT5BASE_WIDGETS bool "widgets module" [...] endif > > Indeed, to me, it seems like any other package that uses qt5 widgets > without selecting qt5 gui would fall into the same build failure. > > Also, any idea why this is popping up only now ? No, did not search the autobuild database, but maybe since 'package/qwt: remove qt4 support'? Regards, Peter > > Thomas ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v1] package/qwt: needs qt5base gui support 2019-02-15 20:58 ` Peter Seiderer @ 2019-02-15 21:40 ` Thomas Petazzoni 2019-02-22 11:44 ` Peter Korsgaard 0 siblings, 1 reply; 5+ messages in thread From: Thomas Petazzoni @ 2019-02-15 21:40 UTC (permalink / raw) To: buildroot Hello, On Fri, 15 Feb 2019 21:58:59 +0100 Peter Seiderer <ps.report@gmx.net> wrote: > Because until now qwt is the only package selecting widgets without gui > (most packages directly, pulseview via qt5svg and qt5cinex via qt5base > eglfs)...and from qt5base/Config.in: > > if BR2_PACKAGE_QT5BASE_GUI > > config BR2_PACKAGE_QT5BASE_WIDGETS > bool "widgets module" > [...] > endif Ah, so there is already a "depends on" between widgets and gui in qt5base, which is good. So it's indeed qwt that is bogus: it should not select QT5BASE_WIDGETS without selecting QT5BASE_GUI (or depending on it). So your patch is good, I'll apply. > > Indeed, to me, it seems like any other package that uses qt5 widgets > > without selecting qt5 gui would fall into the same build failure. > > > > Also, any idea why this is popping up only now ? > > No, did not search the autobuild database, but maybe since 'package/qwt: remove qt4 support'? It's indeed a bug from that patch! Look carefully at the diff of 3e99c8418af904b14b01455d68c84d7b5afd261f: config BR2_PACKAGE_QWT bool "qwt" - depends on BR2_PACKAGE_QT || BR2_PACKAGE_QT5 - select BR2_PACKAGE_QT_GUI_MODULE if BR2_PACKAGE_QT - select BR2_PACKAGE_QT5BASE_GUI if BR2_PACKAGE_QT5 - select BR2_PACKAGE_QT5BASE_WIDGETS if BR2_PACKAGE_QT5 # printsupport - select BR2_PACKAGE_QT5BASE_CONCURRENT if BR2_PACKAGE_QT5 + depends on BR2_PACKAGE_QT5 + select BR2_PACKAGE_QT5BASE + select BR2_PACKAGE_QT5BASE_WIDGETS # printsupport + select BR2_PACKAGE_QT5BASE_CONCURRENT See how the line: - select BR2_PACKAGE_QT5BASE_GUI if BR2_PACKAGE_QT5 gets removed ? So I'll apply your patch after adjusting the commit log. Thanks! Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v1] package/qwt: needs qt5base gui support 2019-02-15 21:40 ` Thomas Petazzoni @ 2019-02-22 11:44 ` Peter Korsgaard 0 siblings, 0 replies; 5+ messages in thread From: Peter Korsgaard @ 2019-02-22 11:44 UTC (permalink / raw) To: buildroot >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes: Hi, > It's indeed a bug from that patch! Look carefully at the diff of > 3e99c8418af904b14b01455d68c84d7b5afd261f: > config BR2_PACKAGE_QWT > bool "qwt" > - depends on BR2_PACKAGE_QT || BR2_PACKAGE_QT5 > - select BR2_PACKAGE_QT_GUI_MODULE if BR2_PACKAGE_QT > - select BR2_PACKAGE_QT5BASE_GUI if BR2_PACKAGE_QT5 > - select BR2_PACKAGE_QT5BASE_WIDGETS if BR2_PACKAGE_QT5 # printsupport > - select BR2_PACKAGE_QT5BASE_CONCURRENT if BR2_PACKAGE_QT5 > + depends on BR2_PACKAGE_QT5 > + select BR2_PACKAGE_QT5BASE > + select BR2_PACKAGE_QT5BASE_WIDGETS # printsupport > + select BR2_PACKAGE_QT5BASE_CONCURRENT > See how the line: > - select BR2_PACKAGE_QT5BASE_GUI if BR2_PACKAGE_QT5 > gets removed ? > So I'll apply your patch after adjusting the commit log. Thanks! Yes, sorry about that. Thanks Peter! -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-22 11:44 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-02-15 20:25 [Buildroot] [PATCH v1] package/qwt: needs qt5base gui support Peter Seiderer 2019-02-15 20:43 ` Thomas Petazzoni 2019-02-15 20:58 ` Peter Seiderer 2019-02-15 21:40 ` Thomas Petazzoni 2019-02-22 11:44 ` Peter Korsgaard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox