[Buildroot] [PATCH 1/1] package/stm32flash: bump to version 0.5

[Buildroot] [PATCH 1/1] package/stm32flash: bump to version 0.5

[Steinhilber, Markus]

Bump to latest official version.

Signed-off-by: Markus Steinhilber <markus.steinhilber@erbe-med.com>
---
 package/stm32flash/stm32flash.hash | 2 ++
 package/stm32flash/stm32flash.mk   | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)  create mode 100644 package/stm32flash/stm32flash.hash

diff --git a/package/stm32flash/stm32flash.hash b/package/stm32flash/stm32flash.hash
new file mode 100644
index 0000000000..dc97c10972
--- /dev/null
+++ b/package/stm32flash/stm32flash.hash
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 73afcbd317ca3eb080c14b6ed1451e5a74a3bbae8f8fb5fe24ea496333f03ead
+stm32flash-1f934ae86babdeea47afdfae1d856d5fd5da6c53.tar.gz
diff --git a/package/stm32flash/stm32flash.mk b/package/stm32flash/stm32flash.mk
index c41fc76d01..9bb05ab730 100644
--- a/package/stm32flash/stm32flash.mk
+++ b/package/stm32flash/stm32flash.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################

-STM32FLASH_VERSION = 4ac0566f188f39eace0223d966d349cd2f2c5895
+STM32FLASH_VERSION = 1f934ae86babdeea47afdfae1d856d5fd5da6c53
 STM32FLASH_SITE = git://git.code.sf.net/p/stm32flash/code
 STM32FLASH_LICENSE = GPL-2.0+
 STM32FLASH_LICENSE_FILES = gpl-2.0.txt
--
2.11.0

________________________________

Erbe Elektromedizin GmbH Firmensitz: 72072 Tuebingen Geschaeftsfuehrer: Christian O. Erbe, Reiner Thede Registergericht: Stuttgart HRB 380137

[Buildroot] [PATCH 1/1] package/stm32flash: bump to version 0.5

[Thomas Petazzoni]

Hello Markus,

Thanks for your contribution! I have applied your patch to our next
branch, but I have a few comments, see below.

On Mon, 18 Feb 2019 14:01:53 +0000
"Steinhilber, Markus" <Markus.Steinhilber@erbe-med.com> wrote:

> Bump to latest official version.
> 
> Signed-off-by: Markus Steinhilber <markus.steinhilber@erbe-med.com>

Your From: doesn't match your Signed-off-by: line. Your From is:

	LastName, FirstName <email>

While your SoB is:

	FirstName LastName <email>

We have some checks that verify that both are consistent, so I fixed up
the author name of your commit. Indeed, we have a preference for the:

	FirstName LastName <email>

formatting.

> diff --git a/package/stm32flash/stm32flash.hash b/package/stm32flash/stm32flash.hash
> new file mode 100644
> index 0000000000..dc97c10972
> --- /dev/null
> +++ b/package/stm32flash/stm32flash.hash
> @@ -0,0 +1,2 @@
> +# Locally computed:
> +sha256 73afcbd317ca3eb080c14b6ed1451e5a74a3bbae8f8fb5fe24ea496333f03ead
> +stm32flash-1f934ae86babdeea47afdfae1d856d5fd5da6c53.tar.gz

This line was wrapped. I suspect you haven't sent this patch using "git
send-email", and due to this, it was line-wrapped by your e-mail
client. Using "git send-email" would avoid such issues.

A possible follow-up improvement to this package would be to add the
hash of the gpl-2.0.txt license file to the .hash file.

Thanks again for your contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] git send-email with Outlook / NTLM ?

[Thomas Petazzoni]

Hello,

I've re-added the Buildroot mailing list in Cc, please keep the list
Cc'ed for this discussion.

On Tue, 19 Feb 2019 09:01:43 +0000
"Steinhilber, Markus" <Markus.Steinhilber@erbe-med.com> wrote:

> The mismatch and also the line wrapping was most likely happening
> because I needed to send the mail with Outlook. Our SMTP server only
> allows NTLM auth and I couldn't get git-email-send to work with it
> (The git-email-send-ntlm project is also not working for me). I don't
> think I can change the From: within outlook. But I could change the
> Signed-off-by: to match it if this is better. If you know any way to
> use git-email-send with NTLM please let me know.

I am in the lucky situation that I don't have to use an Outlook e-mail
server, so I have no idea if git send-email can work with NTLM. Perhaps
other people in the list will know ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] git send-email with Outlook / NTLM ?

[Thomas De Schampheleire]

Hello,

El mar., 19 feb. 2019 a las 10:15, Thomas Petazzoni
(<thomas.petazzoni@bootlin.com>) escribi?:
>
> Hello,
>
> I've re-added the Buildroot mailing list in Cc, please keep the list
> Cc'ed for this discussion.
>
> On Tue, 19 Feb 2019 09:01:43 +0000
> "Steinhilber, Markus" <Markus.Steinhilber@erbe-med.com> wrote:
>
> > The mismatch and also the line wrapping was most likely happening
> > because I needed to send the mail with Outlook. Our SMTP server only
> > allows NTLM auth and I couldn't get git-email-send to work with it
> > (The git-email-send-ntlm project is also not working for me). I don't
> > think I can change the From: within outlook. But I could change the
> > Signed-off-by: to match it if this is better. If you know any way to
> > use git-email-send with NTLM please let me know.
>
> I am in the lucky situation that I don't have to use an Outlook e-mail
> server, so I have no idea if git send-email can work with NTLM. Perhaps
> other people in the list will know ?

First question is: do you really need to use your company's SMTP
server for sending to the Buildroot mailing list. You might be better
off using e.g. gmail SMTP.

You probably have a proxy server that you need to route through, but
it is not impossible.

Previously I used socat to set up a tunnel through the proxy, to gmail smtp.

remotehost=smtp.gmail.com
remoteport=587
localport=10587
proxy=your.proxy.com # or IP address
proxyport=8080
socat TCP4-LISTEN:$localport,reuseaddr,fork
PROXY:$proxy:$remotehost:$remoteport,proxyport=$proxyport,resolve


In your gitconfig, you would then specify 'localhost' and port 10587
as smtp server.

For some reason, this no longer works for me, with error:
STARTTLS failed! hostname verification failed at
/usr/libexec/git-core/git-send-email line 1503.



But git-send-email also allows to specify an external program to send
email. For example, use '/usr/bin/msmtp' as 'smtpserver'. Additional
options can be specified as 'smtpserveroption'.
In my case, I can also use a socks proxy. In .msmtprc I have:


account gmail
host smtp.gmail.com
port 587
tls on
tls_trust_file /etc/ssl/certs/ca-certificates.crt
logfile /home/user/msmtp.log
proxy_host your-socks-proxy
auth on
from user at gmail.com
user user at gmail.com
password your-app-password-for-gmail

and then in .gitconfig

[sendemail]
  smtpserver = /usr/bin/msmtp
  smtpserveroption = -agmail



If gmail is not an option,  you might be able to configure msmtp to
autenticate using NTLM to your company SMTP. The internet suggests
that msmtp supports NTLM via GNU SASL, which in turn uses libntlm.
See:
https://marlam.de/msmtp/
http://josefsson.org/libgsasl/


Best regards,
Thomas

[Buildroot] [PATCH 1/1] package/stm32flash: bump to version 0.5

[Peter Korsgaard]

>>>>> "Steinhilber," == Steinhilber, Markus <Markus.Steinhilber@erbe-med.com> writes:

 > Bump to latest official version.
 > Signed-off-by: Markus Steinhilber <markus.steinhilber@erbe-med.com>
 > ---
 >  package/stm32flash/stm32flash.hash | 2 ++
 >  package/stm32flash/stm32flash.mk   | 2 +-
 >  2 files changed, 3 insertions(+), 1 deletion(-)  create mode 100644 package/stm32flash/stm32flash.hash

 > diff --git a/package/stm32flash/stm32flash.hash b/package/stm32flash/stm32flash.hash
 > new file mode 100644
 > index 0000000000..dc97c10972
 > --- /dev/null
 > +++ b/package/stm32flash/stm32flash.hash
 > @@ -0,0 +1,2 @@
 > +# Locally computed:
 > +sha256 73afcbd317ca3eb080c14b6ed1451e5a74a3bbae8f8fb5fe24ea496333f03ead
 > +stm32flash-1f934ae86babdeea47afdfae1d856d5fd5da6c53.tar.gz
 > diff --git a/package/stm32flash/stm32flash.mk b/package/stm32flash/stm32flash.mk
 > index c41fc76d01..9bb05ab730 100644
 > --- a/package/stm32flash/stm32flash.mk
 > +++ b/package/stm32flash/stm32flash.mk
 > @@ -4,7 +4,7 @@
 >  #
 >  ################################################################################

 > -STM32FLASH_VERSION = 4ac0566f188f39eace0223d966d349cd2f2c5895
 > +STM32FLASH_VERSION = 1f934ae86babdeea47afdfae1d856d5fd5da6c53

If this is latest official version, why isn't this a git tag?

Looking at git, this corresponds to the v0.5 tag.

-- 
Bye, Peter Korsgaard