[Buildroot] [PATCH] package/flatbuffers: do not install to target

[Buildroot] [PATCH] package/flatbuffers: do not install to target

[Michaël Blanc]

Since flatbuffers does not have a shared library and flatc is only useful
for compiling schemas of other projects, there is no point in installing
flatbuffers in the target directory.

Signed-off-by: Micha?l Blanc <mika.blanc@gmail.com>
---
 package/flatbuffers/flatbuffers.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/flatbuffers/flatbuffers.mk b/package/flatbuffers/flatbuffers.mk
index 69054885ea..32186788c5 100644
--- a/package/flatbuffers/flatbuffers.mk
+++ b/package/flatbuffers/flatbuffers.mk
@@ -9,6 +9,7 @@ FLATBUFFERS_SITE = $(call github,google,flatbuffers,$(FLATBUFFERS_VERSION))
 FLATBUFFERS_LICENSE = Apache-2.0
 FLATBUFFERS_LICENSE_FILES = LICENSE.txt
 FLATBUFFERS_INSTALL_STAGING = YES
+FLATBUFFERS_INSTALL_TARGET = NO
 
 FLATBUFFERS_CONF_OPTS += \
 	-DCMAKE_CXX_FLAGS="-std=c++11" \
-- 
2.20.1

[Buildroot] [PATCH] package/flatbuffers: do not install to target

[Thomas Petazzoni]

Hello,

On Mon, 25 Feb 2019 01:16:11 +0100
Micha?l Blanc <mika.blanc@gmail.com> wrote:

> Since flatbuffers does not have a shared library and flatc is only useful
> for compiling schemas of other projects, there is no point in installing
> flatbuffers in the target directory.
> 
> Signed-off-by: Micha?l Blanc <mika.blanc@gmail.com>

I see a shared library on the target:

??? usr
    ??? bin
    ??? ??? flatc
    ??? lib
    ??? ??? libflatbuffers.so -> libflatbuffers.so.1
    ??? ??? libflatbuffers.so.1 -> libflatbuffers.so.1.9.0
    ??? ??? libflatbuffers.so.1.9.0

so it doesn't quite match with what your commit log says. Are you sure
you were not building with BR2_STATIC_LIBS=y ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] package/flatbuffers: do not install to target

[Mika Blanc]

Le lun. 25 f?vr. 2019 ? 22:11, Thomas Petazzoni <
thomas.petazzoni@bootlin.com> a ?crit :

> I see a shared library on the target:
>
> ??? usr
>     ??? bin
>     ?   ??? flatc
>     ??? lib
>     ?   ??? libflatbuffers.so -> libflatbuffers.so.1
>     ?   ??? libflatbuffers.so.1 -> libflatbuffers.so.1.9.0
>     ?   ??? libflatbuffers.so.1.9.0
>
> so it doesn't quite match with what your commit log says. Are you sure
> you were not building with BR2_STATIC_LIBS=y ?
>
I'm actually building with the default behavior, so shared libs only by
default. I was mistaken in my commit message, I didn't check for the
presence of a shared library. Flatbuffers is not supposed to be used with
dynamic linking, despite it being possible. Maybe the patch should be
dropped then.

Regards.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190226/8989e24c/attachment.html>