* [Buildroot] [PATCH 1/1] package/gst-plugins-bad: remove apexsink support
@ 2019-03-05 19:20 Fabrice Fontaine
2019-03-05 20:22 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Fabrice Fontaine @ 2019-03-05 19:20 UTC (permalink / raw)
To: buildroot
apexsink does not build with OpenSSL 1.1.x so remove this option
Fixes:
- http://autobuild.buildroot.org/results/a29e8a8509190fc4b3c419dae2301cf72a601f62
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Config.in.legacy | 8 ++++++++
package/gstreamer/gst-plugins-bad/Config.in | 4 ----
package/gstreamer/gst-plugins-bad/gst-plugins-bad.mk | 8 +-------
3 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/Config.in.legacy b/Config.in.legacy
index 25b48fba82..93e50f3f60 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -144,6 +144,14 @@ endif
###############################################################################
+comment "Legacy options removed in 2019.05"
+
+config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_APEXSINK
+ bool "gst-plugins-bad apexsink option removed"
+ select BR2_LEGACY
+ help
+ The gst-plugins-bad apexsink option was removed.
+
comment "Legacy options removed in 2019.02"
config BR2_PACKAGE_QT
diff --git a/package/gstreamer/gst-plugins-bad/Config.in b/package/gstreamer/gst-plugins-bad/Config.in
index f45981f6c8..971668b710 100644
--- a/package/gstreamer/gst-plugins-bad/Config.in
+++ b/package/gstreamer/gst-plugins-bad/Config.in
@@ -242,10 +242,6 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_Y4M
comment "plugins with external dependencies (there may be more available)"
-config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_APEXSINK
- bool "apexsink"
- select BR2_PACKAGE_OPENSSL
-
config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_BZ2
bool "bz2"
select BR2_PACKAGE_BZIP2
diff --git a/package/gstreamer/gst-plugins-bad/gst-plugins-bad.mk b/package/gstreamer/gst-plugins-bad/gst-plugins-bad.mk
index 856ff9665d..a98eac4235 100644
--- a/package/gstreamer/gst-plugins-bad/gst-plugins-bad.mk
+++ b/package/gstreamer/gst-plugins-bad/gst-plugins-bad.mk
@@ -12,6 +12,7 @@ GST_PLUGINS_BAD_LICENSE = LGPL-2.1+, GPL-2.0+
GST_PLUGINS_BAD_LICENSE_FILES = COPYING.LIB COPYING
GST_PLUGINS_BAD_CONF_OPTS = \
+ --disable-apexsink \
--disable-examples \
--disable-spandsp
@@ -472,13 +473,6 @@ GST_PLUGINS_BAD_CONF_OPTS += --disable-y4m
endif
# plugins with deps
-ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_APEXSINK),y)
-GST_PLUGINS_BAD_CONF_OPTS += --enable-apexsink
-GST_PLUGINS_BAD_DEPENDENCIES += openssl
-else
-GST_PLUGINS_BAD_CONF_OPTS += --disable-apexsink
-endif
-
ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_BZ2),y)
GST_PLUGINS_BAD_CONF_OPTS += --enable-bz2
GST_PLUGINS_BAD_DEPENDENCIES += bzip2
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/gst-plugins-bad: remove apexsink support
2019-03-05 19:20 [Buildroot] [PATCH 1/1] package/gst-plugins-bad: remove apexsink support Fabrice Fontaine
@ 2019-03-05 20:22 ` Thomas Petazzoni
2019-03-05 21:06 ` Fabrice Fontaine
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2019-03-05 20:22 UTC (permalink / raw)
To: buildroot
Hello Fabrice,
On Tue, 5 Mar 2019 20:20:32 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> apexsink does not build with OpenSSL 1.1.x so remove this option
Just curious: was this build issue fixed in newer version of GStreamer ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/gst-plugins-bad: remove apexsink support
2019-03-05 20:22 ` Thomas Petazzoni
@ 2019-03-05 21:06 ` Fabrice Fontaine
2019-03-05 21:54 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Fabrice Fontaine @ 2019-03-05 21:06 UTC (permalink / raw)
To: buildroot
Hello Thomas,
Le mar. 5 mars 2019 ? 21:22, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> Hello Fabrice,
>
> On Tue, 5 Mar 2019 20:20:32 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > apexsink does not build with OpenSSL 1.1.x so remove this option
>
> Just curious: was this build issue fixed in newer version of GStreamer ?
There is no more apexsink option in gstreamer1 (since version 1.12).
However, the hls option which also depends on openssl has been updated
to support openssl 1.1.x
(https://github.com/GStreamer/gst-plugins-bad/commit/e796a7cb974a361bd4463a71aed4e1256cfe2df6)
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/gst-plugins-bad: remove apexsink support
2019-03-05 21:06 ` Fabrice Fontaine
@ 2019-03-05 21:54 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2019-03-05 21:54 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 5 Mar 2019 22:06:24 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > > apexsink does not build with OpenSSL 1.1.x so remove this option
> >
> > Just curious: was this build issue fixed in newer version of GStreamer ?
> There is no more apexsink option in gstreamer1 (since version 1.12).
OK, so this is another reason to drop apexsink support. I guess it
should be mentioned in the commit log.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-05 21:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-05 19:20 [Buildroot] [PATCH 1/1] package/gst-plugins-bad: remove apexsink support Fabrice Fontaine
2019-03-05 20:22 ` Thomas Petazzoni
2019-03-05 21:06 ` Fabrice Fontaine
2019-03-05 21:54 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox