Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/mender: Fix service file.
@ 2019-03-06 15:49 aduskett at gmail.com
  2019-03-07  8:26 ` Angelo Compagnucci
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: aduskett at gmail.com @ 2019-03-06 15:49 UTC (permalink / raw)
  To: buildroot

From: Adam Duskett <Aduskett@gmail.com>

There was a missing double quotes that would prevent the service from starting.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 package/mender/mender.service | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/mender/mender.service b/package/mender/mender.service
index 8b60a4f1aa..2a5f476ee5 100644
--- a/package/mender/mender.service
+++ b/package/mender/mender.service
@@ -12,7 +12,7 @@ if [ -L /var/lib/mender \
     if rm -f /var/lib/mender >/dev/null 2>&1; then \
         mkdir -p /var/lib/mender; \
     else \
-        echo "No persistent location to store mender data. Data will be lost\
+        echo "No persistent location to store mender data. Data will be lost" \
         echo "at reboot. Are you sure this is what you want to do?"; \
         mkdir -p "$(readlink /var/lib/mender)"; \
     fi; \
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/mender: Fix service file.
  2019-03-06 15:49 [Buildroot] [PATCH 1/1] package/mender: Fix service file aduskett at gmail.com
@ 2019-03-07  8:26 ` Angelo Compagnucci
  2019-03-07 20:47 ` Thomas Petazzoni
  2019-03-19 19:48 ` Peter Korsgaard
  2 siblings, 0 replies; 5+ messages in thread
From: Angelo Compagnucci @ 2019-03-07  8:26 UTC (permalink / raw)
  To: buildroot

On Wed, Mar 6, 2019 at 4:50 PM <aduskett@gmail.com> wrote:
>
> From: Adam Duskett <Aduskett@gmail.com>
>
> There was a missing double quotes that would prevent the service from starting.
>
> Signed-off-by: Adam Duskett <Aduskett at gmail.com
Tested-by: Angelo Compagnucci <angelo@amarulasolutions.com>
Acked-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
>  package/mender/mender.service | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/mender/mender.service b/package/mender/mender.service
> index 8b60a4f1aa..2a5f476ee5 100644
> --- a/package/mender/mender.service
> +++ b/package/mender/mender.service
> @@ -12,7 +12,7 @@ if [ -L /var/lib/mender \
>      if rm -f /var/lib/mender >/dev/null 2>&1; then \
>          mkdir -p /var/lib/mender; \
>      else \
> -        echo "No persistent location to store mender data. Data will be lost\
> +        echo "No persistent location to store mender data. Data will be lost" \
>          echo "at reboot. Are you sure this is what you want to do?"; \
>          mkdir -p "$(readlink /var/lib/mender)"; \
>      fi; \
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/mender: Fix service file.
  2019-03-06 15:49 [Buildroot] [PATCH 1/1] package/mender: Fix service file aduskett at gmail.com
  2019-03-07  8:26 ` Angelo Compagnucci
@ 2019-03-07 20:47 ` Thomas Petazzoni
  2019-03-07 21:11   ` Yann E. MORIN
  2019-03-19 19:48 ` Peter Korsgaard
  2 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-03-07 20:47 UTC (permalink / raw)
  To: buildroot

On Wed,  6 Mar 2019 10:49:53 -0500
aduskett at gmail.com wrote:

> From: Adam Duskett <Aduskett@gmail.com>
> 
> There was a missing double quotes that would prevent the service from starting.
> 
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
>  package/mender/mender.service | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/mender: Fix service file.
  2019-03-07 20:47 ` Thomas Petazzoni
@ 2019-03-07 21:11   ` Yann E. MORIN
  0 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2019-03-07 21:11 UTC (permalink / raw)
  To: buildroot

Peter,

This one is candidate for backporting to 2019.02.x

Regards,
Yann E. MORIN.

On 2019-03-07 21:47 +0100, Thomas Petazzoni spake thusly:
> On Wed,  6 Mar 2019 10:49:53 -0500
> aduskett at gmail.com wrote:
> 
> > From: Adam Duskett <Aduskett@gmail.com>
> > 
> > There was a missing double quotes that would prevent the service from starting.
> > 
> > Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> > ---
> >  package/mender/mender.service | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied to master, thanks.
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/mender: Fix service file.
  2019-03-06 15:49 [Buildroot] [PATCH 1/1] package/mender: Fix service file aduskett at gmail.com
  2019-03-07  8:26 ` Angelo Compagnucci
  2019-03-07 20:47 ` Thomas Petazzoni
@ 2019-03-19 19:48 ` Peter Korsgaard
  2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2019-03-19 19:48 UTC (permalink / raw)
  To: buildroot

>>>>> "aduskett" == aduskett  <aduskett@gmail.com> writes:

 > From: Adam Duskett <Aduskett@gmail.com>
 > There was a missing double quotes that would prevent the service from starting.

 > Signed-off-by: Adam Duskett <Aduskett@gmail.com>

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-03-19 19:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-06 15:49 [Buildroot] [PATCH 1/1] package/mender: Fix service file aduskett at gmail.com
2019-03-07  8:26 ` Angelo Compagnucci
2019-03-07 20:47 ` Thomas Petazzoni
2019-03-07 21:11   ` Yann E. MORIN
2019-03-19 19:48 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox