Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/flashrom: disable on arc, nios and or1k
@ 2019-03-07 21:34 Fabrice Fontaine
  2019-03-07 21:36 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2019-03-07 21:34 UTC (permalink / raw)
  To: buildroot

Fixes:
 - http://autobuild.buildroot.org/results/22c72369cd5b7a8200bb03564bdc342ed026ccac
 - http://autobuild.buildroot.org/results/ef6869bc40382145fad1079b79107275c4973494
 - http://autobuild.buildroot.org/results/09d857102c469ede1db0bff8aa0dcd82a4001eaf

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/flashrom/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/flashrom/Config.in b/package/flashrom/Config.in
index cf1f53c1a3..b99fc2a960 100644
--- a/package/flashrom/Config.in
+++ b/package/flashrom/Config.in
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_FLASHROM
 	bool "flashrom"
-	depends on !BR2_microblaze && !BR2_xtensa # platform.h
+	# platform.h
+	depends on !(BR2_arc || BR2_microblaze || BR2_nios || \
+		BR2_or1k || BR2_xtensa)
 	help
 	  flashrom is a utility for identifying, reading, writing,
 	  verifying and erasing flash chips. It is designed to flash
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/flashrom: disable on arc, nios and or1k
  2019-03-07 21:34 [Buildroot] [PATCH 1/1] package/flashrom: disable on arc, nios and or1k Fabrice Fontaine
@ 2019-03-07 21:36 ` Thomas Petazzoni
  2019-03-07 21:41   ` Fabrice Fontaine
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2019-03-07 21:36 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu,  7 Mar 2019 22:34:31 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fixes:
>  - http://autobuild.buildroot.org/results/22c72369cd5b7a8200bb03564bdc342ed026ccac
>  - http://autobuild.buildroot.org/results/ef6869bc40382145fad1079b79107275c4973494
>  - http://autobuild.buildroot.org/results/09d857102c469ede1db0bff8aa0dcd82a4001eaf
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Should we turn this around, and use:

config BR2_PACKAGE_FLASHROM_ARCH_SUPPORTS
	bool
	default y if ...
	default y if ...

etc. ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/flashrom: disable on arc, nios and or1k
  2019-03-07 21:36 ` Thomas Petazzoni
@ 2019-03-07 21:41   ` Fabrice Fontaine
  0 siblings, 0 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2019-03-07 21:41 UTC (permalink / raw)
  To: buildroot

Dear Thomas,
Le jeu. 7 mars 2019 ? 22:36, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> Hello,
>
> On Thu,  7 Mar 2019 22:34:31 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Fixes:
> >  - http://autobuild.buildroot.org/results/22c72369cd5b7a8200bb03564bdc342ed026ccac
> >  - http://autobuild.buildroot.org/results/ef6869bc40382145fad1079b79107275c4973494
> >  - http://autobuild.buildroot.org/results/09d857102c469ede1db0bff8aa0dcd82a4001eaf
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> Should we turn this around, and use:
>
> config BR2_PACKAGE_FLASHROM_ARCH_SUPPORTS
>         bool
>         default y if ...
>         default y if ...
>
> etc. ?
OK, I'll send a v2.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-07 21:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-07 21:34 [Buildroot] [PATCH 1/1] package/flashrom: disable on arc, nios and or1k Fabrice Fontaine
2019-03-07 21:36 ` Thomas Petazzoni
2019-03-07 21:41   ` Fabrice Fontaine

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox