Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] docs/manual: add note about spurious errors duing make printvars
Date: Tue, 12 Mar 2019 18:36:02 +0100	[thread overview]
Message-ID: <20190312173602.GE25009@scaer> (raw)
In-Reply-To: <99874541-4ce3-4cb8-b7ce-a0d3d7496357@mind.be>

Arnout, All,

On 2019-03-12 13:33 +0100, Arnout Vandecappelle spake thusly:
> On 12/03/2019 11:57, Martin Kepplinger wrote:
> > Add a note about errors we currently have, as discussed in
> > http://lists.busybox.net/pipermail/buildroot/2019-March/244212.html
> > 
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> > ---
> >  docs/manual/make-tips.txt | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/docs/manual/make-tips.txt b/docs/manual/make-tips.txt
> > index ea1d825bef..475de4ffa7 100644
> > --- a/docs/manual/make-tips.txt
> > +++ b/docs/manual/make-tips.txt
> > @@ -131,3 +131,13 @@ The output of quoted variables can be reused in shell scripts, for example:
> >   $ echo $BUSYBOX_DEPENDENCIES
> >   skeleton toolchain
> >  ----
> > +
> > +Note that when using +make printvars+ you might see spurious errors like
> > +the following. Please help reviewing our Makefile macros and variables
> > +in order to fix this:
> 
>  I thought the conclusion of that thread is that there is no way to fix it?

Yes, that was my impresion as well. We can document that here may be
spurious error messages, but fixing them is not wanted (because it makes
the code more complex).

> The
> only reasonable way is to filter out macros from the .VARS. E.g. defining
> PRINTVARS_FILTER and for each macro definition, append to that list.
> 
>  However, I'm not even convinced that we really want to do that. It is adding
> significant complexity for little gain.

Agreed.

>  Instead, I'm more inclined to remove the possibility of running printvars
> without explicit VARS=. If you really want, you can still get all variables with
> VARS=%.

Yes, that sounds like a good idea, indeed. +1

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2019-03-12 17:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 10:57 [Buildroot] [PATCH] docs/manual: add note about spurious errors duing make printvars Martin Kepplinger
2019-03-12 12:33 ` Arnout Vandecappelle
2019-03-12 13:14   ` yann.morin at orange.com
2019-03-12 13:53     ` Arnout Vandecappelle
2019-03-12 14:04       ` yann.morin at orange.com
2019-03-12 17:36   ` Yann E. MORIN [this message]
2019-03-12 17:55     ` [Buildroot] [PATCH 1/2] printvars: don't print anything when VARS is not set Arnout Vandecappelle
2019-03-12 17:55       ` [Buildroot] [PATCH 2/2] docs/manual: document new behaviour of 'make printvars' Arnout Vandecappelle
2019-03-12 18:44         ` Yann E. MORIN
2019-03-12 18:42       ` [Buildroot] [PATCH 1/2] printvars: don't print anything when VARS is not set Yann E. MORIN
2019-03-12 21:01       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190312173602.GE25009@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox