From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] printvars: don't print anything when VARS is not set
Date: Tue, 12 Mar 2019 22:01:04 +0100 [thread overview]
Message-ID: <20190312220104.7acc0f67@windsurf> (raw)
In-Reply-To: <20190312175535.18152-1-arnout@mind.be>
On Tue, 12 Mar 2019 18:55:34 +0100
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> wrote:
> Using 'make printvars' for printing all variables is not very useful.
> E.g. all macros will output some bogus value. In addition, the same can
> be achieved with 'make -p'.
>
> We can simply remove the condition on $(VARS). If VARS is not set, the
> filter expression will be empty which matches nothing, so nothing is
> printed.
>
> Note that the old behaviour can still be achieved with:
> make printvars VARS=%
>
> Update the 'make help' text to match the new behaviour.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Both applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-03-12 21:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 10:57 [Buildroot] [PATCH] docs/manual: add note about spurious errors duing make printvars Martin Kepplinger
2019-03-12 12:33 ` Arnout Vandecappelle
2019-03-12 13:14 ` yann.morin at orange.com
2019-03-12 13:53 ` Arnout Vandecappelle
2019-03-12 14:04 ` yann.morin at orange.com
2019-03-12 17:36 ` Yann E. MORIN
2019-03-12 17:55 ` [Buildroot] [PATCH 1/2] printvars: don't print anything when VARS is not set Arnout Vandecappelle
2019-03-12 17:55 ` [Buildroot] [PATCH 2/2] docs/manual: document new behaviour of 'make printvars' Arnout Vandecappelle
2019-03-12 18:44 ` Yann E. MORIN
2019-03-12 18:42 ` [Buildroot] [PATCH 1/2] printvars: don't print anything when VARS is not set Yann E. MORIN
2019-03-12 21:01 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312220104.7acc0f67@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox