[Buildroot] [PATCH 1/1] package/wpewebkit: fix host gcc >= 4.8 check

[Buildroot] [PATCH 1/1] package/wpewebkit: fix host gcc >= 4.8 check

[james.hilliard1 at gmail.com]

From: James Hilliard <james.hilliard1@gmail.com>

We need host gcc >= 4.8 not host gcc < 4.8.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/wpewebkit/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
index 64e81a95f9..04ebe5452b 100644
--- a/package/wpewebkit/Config.in
+++ b/package/wpewebkit/Config.in
@@ -33,7 +33,7 @@ comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gc
 	depends on !BR2_BINFMT_FLAT
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
 		|| !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
-		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || BR2_HOST_GCC_AT_LEAST_4_8
+		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_HOST_GCC_AT_LEAST_4_8
 
 comment "wpewebkit needs an OpenGL ES w/ EGL backend"
 	depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
-- 
2.17.1

[Buildroot] [PATCH 1/1] package/wpewebkit: fix host gcc >= 4.8 check

[François Perrad]

Le dim. 10 mars 2019 ? 04:14, <james.hilliard1@gmail.com> a ?crit :

> From: James Hilliard <james.hilliard1@gmail.com>
>
> We need host gcc >= 4.8 not host gcc < 4.8.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>

Acked-by: Francois Perrad <francois.perrad@gadz.org>

---
>  package/wpewebkit/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
> index 64e81a95f9..04ebe5452b 100644
> --- a/package/wpewebkit/Config.in
> +++ b/package/wpewebkit/Config.in
> @@ -33,7 +33,7 @@ comment "wpewebkit needs a toolchain w/ C++, wchar,
> threads, dynamic library, gc
>         depends on !BR2_BINFMT_FLAT
>         depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
>                 || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
> -               || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 ||
> BR2_HOST_GCC_AT_LEAST_4_8
> +               || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 ||
> !BR2_HOST_GCC_AT_LEAST_4_8
>
>  comment "wpewebkit needs an OpenGL ES w/ EGL backend"
>         depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
> --
> 2.17.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190310/506e8824/attachment.html>

[Buildroot] [PATCH 1/1] package/wpewebkit: fix host gcc >= 4.8 check

[Adrian Perez de Castro]

On Sun, 10 Mar 2019 11:14:07 +0800, james.hilliard1 at gmail.com wrote:
> From: James Hilliard <james.hilliard1@gmail.com>
> 
> We need host gcc >= 4.8 not host gcc < 4.8.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
>  package/wpewebkit/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
> index 64e81a95f9..04ebe5452b 100644
> --- a/package/wpewebkit/Config.in
> +++ b/package/wpewebkit/Config.in
> @@ -33,7 +33,7 @@ comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gc
>  	depends on !BR2_BINFMT_FLAT
>  	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
>  		|| !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
> -		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || BR2_HOST_GCC_AT_LEAST_4_8
> +		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_HOST_GCC_AT_LEAST_4_8
>  
>  comment "wpewebkit needs an OpenGL ES w/ EGL backend"
>  	depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
> -- 
> 2.17.1
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190310/a0301e4e/attachment.asc>

[Buildroot] [PATCH 1/1] package/wpewebkit: fix host gcc >= 4.8 check

[Thomas Petazzoni]

On Sun, 10 Mar 2019 11:14:07 +0800
james.hilliard1 at gmail.com wrote:

> From: James Hilliard <james.hilliard1@gmail.com>
> 
> We need host gcc >= 4.8 not host gcc < 4.8.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/wpewebkit/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com