* [Buildroot] [git commit] package/qt5/qt5webengine: fix comment on GL dependencies
@ 2019-03-13 16:50 Thomas Petazzoni
2019-03-13 19:07 ` Peter Seiderer
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2019-03-13 16:50 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=6fb4c14ecb1e8f001449830b65ec2a4606b87682
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
qt5declarative can be built/used without opengl support so fix the
dependency comment in qt5webengine.
Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/qt5/qt5webengine/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/qt5/qt5webengine/Config.in b/package/qt5/qt5webengine/Config.in
index 744d659567..bfc0a02c12 100644
--- a/package/qt5/qt5webengine/Config.in
+++ b/package/qt5/qt5webengine/Config.in
@@ -34,7 +34,7 @@ config BR2_PACKAGE_QT5WEBENGINE
depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 || BR2_PACKAGE_QT5_VERSION_5_6 # libnss
depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2, libvpx, qt5base-dbus
depends on BR2_USE_WCHAR # libglib2
- depends on BR2_PACKAGE_QT5_GL_AVAILABLE # qt5declarative, qt5base-eglfs
+ depends on BR2_PACKAGE_QT5_GL_AVAILABLE # qt5base-eglfs
depends on BR2_PACKAGE_HAS_LIBEGL # qt5base-eglfs
depends on BR2_PACKAGE_HAS_UDEV
# v8 (a chromium 3rd-party) compiles its internal host-tools with the
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [git commit] package/qt5/qt5webengine: fix comment on GL dependencies
2019-03-13 16:50 [Buildroot] [git commit] package/qt5/qt5webengine: fix comment on GL dependencies Thomas Petazzoni
@ 2019-03-13 19:07 ` Peter Seiderer
2019-03-14 7:52 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Peter Seiderer @ 2019-03-13 19:07 UTC (permalink / raw)
To: buildroot
Hello Martin, Thomas,
On Wed, 13 Mar 2019 17:50:39 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> commit: https://git.buildroot.net/buildroot/commit/?id=6fb4c14ecb1e8f001449830b65ec2a4606b87682
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> qt5declarative can be built/used without opengl support so fix the
> dependency comment in qt5webengine.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/qt5/qt5webengine/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/qt5/qt5webengine/Config.in b/package/qt5/qt5webengine/Config.in
> index 744d659567..bfc0a02c12 100644
> --- a/package/qt5/qt5webengine/Config.in
> +++ b/package/qt5/qt5webengine/Config.in
> @@ -34,7 +34,7 @@ config BR2_PACKAGE_QT5WEBENGINE
> depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 || BR2_PACKAGE_QT5_VERSION_5_6 # libnss
> depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2, libvpx, qt5base-dbus
> depends on BR2_USE_WCHAR # libglib2
> - depends on BR2_PACKAGE_QT5_GL_AVAILABLE # qt5declarative, qt5base-eglfs
> + depends on BR2_PACKAGE_QT5_GL_AVAILABLE # qt5base-eglfs
This comment change is only valid for BR2_PACKAGE_QT5_VERSION_LATEST/Qt5.12.x as
qt5webengine selects BR2_PACKAGE_QT5DECLARATIVE_QUICK and qt5declarative/Config.in
states:
config BR2_PACKAGE_QT5DECLARATIVE_QUICK
bool "quick module"
depends on BR2_PACKAGE_QT5_GL_AVAILABLE || BR2_PACKAGE_QT5_VERSION_LATEST
Regards,
Peter
> depends on BR2_PACKAGE_HAS_LIBEGL # qt5base-eglfs
> depends on BR2_PACKAGE_HAS_UDEV
> # v8 (a chromium 3rd-party) compiles its internal host-tools with the
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread* [Buildroot] [git commit] package/qt5/qt5webengine: fix comment on GL dependencies
2019-03-13 19:07 ` Peter Seiderer
@ 2019-03-14 7:52 ` Thomas Petazzoni
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-03-14 7:52 UTC (permalink / raw)
To: buildroot
On Wed, 13 Mar 2019 20:07:25 +0100
Peter Seiderer <ps.report@gmx.net> wrote:
> This comment change is only valid for BR2_PACKAGE_QT5_VERSION_LATEST/Qt5.12.x as
> qt5webengine selects BR2_PACKAGE_QT5DECLARATIVE_QUICK and qt5declarative/Config.in
> states:
>
> config BR2_PACKAGE_QT5DECLARATIVE_QUICK
> bool "quick module"
> depends on BR2_PACKAGE_QT5_GL_AVAILABLE || BR2_PACKAGE_QT5_VERSION_LATEST
Aah, yes, indeed. I had missed that qt5webengine not only selects
QT5DECLARATIVE, but also QT5DECLARATIVE_QUICK. So I think we should
simply revert the change.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-14 7:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-13 16:50 [Buildroot] [git commit] package/qt5/qt5webengine: fix comment on GL dependencies Thomas Petazzoni
2019-03-13 19:07 ` Peter Seiderer
2019-03-14 7:52 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox