* [Buildroot] [PATCH] package/musl: remove rcrt1.o from target installation
@ 2019-03-06 16:33 Norbert Lange
2019-03-06 16:48 ` Thomas Petazzoni
2019-03-14 22:13 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Norbert Lange @ 2019-03-06 16:33 UTC (permalink / raw)
To: buildroot
From: Norbert Lange <nolange79@gmail.com>
Signed-off-by: Norbert Lange <norbert.lange@andritz.com>
---
package/musl/musl.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/musl/musl.mk b/package/musl/musl.mk
index 90c753926e..ff807c0cba 100644
--- a/package/musl/musl.mk
+++ b/package/musl/musl.mk
@@ -58,7 +58,7 @@ endef
define MUSL_INSTALL_TARGET_CMDS
$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
DESTDIR=$(TARGET_DIR) install-libs
- $(RM) $(addprefix $(TARGET_DIR)/lib/,crt1.o crtn.o crti.o Scrt1.o)
+ $(RM) $(addprefix $(TARGET_DIR)/lib/,crt1.o crtn.o crti.o rcrt1.o Scrt1.o)
endef
$(eval $(generic-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/musl: remove rcrt1.o from target installation
2019-03-06 16:33 [Buildroot] [PATCH] package/musl: remove rcrt1.o from target installation Norbert Lange
@ 2019-03-06 16:48 ` Thomas Petazzoni
2019-03-06 17:09 ` Norbert Lange
2019-03-14 22:13 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2019-03-06 16:48 UTC (permalink / raw)
To: buildroot
Hello Norbert,
Thanks for your patch!
On Wed, 6 Mar 2019 17:33:16 +0100
Norbert Lange <nolange79@gmail.com> wrote:
> From: Norbert Lange <nolange79@gmail.com>
>
> Signed-off-by: Norbert Lange <norbert.lange@andritz.com>
Could you give some more details ?
In fact, your patch does not remove rcrt1.o from target installation:
it ensures that the target installation does *NOT* remove it from
TARGET_DIR.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/musl: remove rcrt1.o from target installation
2019-03-06 16:48 ` Thomas Petazzoni
@ 2019-03-06 17:09 ` Norbert Lange
2019-03-06 21:54 ` Thomas Petazzoni
2019-03-25 21:13 ` Peter Korsgaard
0 siblings, 2 replies; 6+ messages in thread
From: Norbert Lange @ 2019-03-06 17:09 UTC (permalink / raw)
To: buildroot
>
> Could you give some more details ?
rcrt1.o is a new startup for "static-pie" apps, and only needed for building,
should not end up in the target filesystem
>
> In fact, your patch does not remove rcrt1.o from target installation:
> it ensures that the target installation does *NOT* remove it from
> TARGET_DIR.
One of us is eligible for a legasthenic fund, either its you or I am
a really badly affected cause I still cant find a fault in the patch.
Norbert
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/musl: remove rcrt1.o from target installation
2019-03-06 17:09 ` Norbert Lange
@ 2019-03-06 21:54 ` Thomas Petazzoni
2019-03-25 21:13 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2019-03-06 21:54 UTC (permalink / raw)
To: buildroot
Hello Norbert,
On Wed, 6 Mar 2019 18:09:19 +0100
Norbert Lange <nolange79@gmail.com> wrote:
> > Could you give some more details ?
>
>
> rcrt1.o is a new startup for "static-pie" apps, and only needed for building,
> should not end up in the target filesystem
OK.
> > In fact, your patch does not remove rcrt1.o from target installation:
> > it ensures that the target installation does *NOT* remove it from
> > TARGET_DIR.
>
> One of us is eligible for a legasthenic fund, either its you or I am
> a really badly affected cause I still cant find a fault in the patch.
It was me :-) The patch looks good!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/musl: remove rcrt1.o from target installation
2019-03-06 16:33 [Buildroot] [PATCH] package/musl: remove rcrt1.o from target installation Norbert Lange
2019-03-06 16:48 ` Thomas Petazzoni
@ 2019-03-14 22:13 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2019-03-14 22:13 UTC (permalink / raw)
To: buildroot
On Wed, 6 Mar 2019 17:33:16 +0100
Norbert Lange <nolange79@gmail.com> wrote:
> From: Norbert Lange <nolange79@gmail.com>
>
> Signed-off-by: Norbert Lange <norbert.lange@andritz.com>
> ---
> package/musl/musl.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/musl: remove rcrt1.o from target installation
2019-03-06 17:09 ` Norbert Lange
2019-03-06 21:54 ` Thomas Petazzoni
@ 2019-03-25 21:13 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2019-03-25 21:13 UTC (permalink / raw)
To: buildroot
>>>>> "Norbert" == Norbert Lange <nolange79@gmail.com> writes:
>>
>> Could you give some more details ?
> rcrt1.o is a new startup for "static-pie" apps, and only needed for building,
> should not end up in the target filesystem
Committed to 2019.02.x after adding this description, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-25 21:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-06 16:33 [Buildroot] [PATCH] package/musl: remove rcrt1.o from target installation Norbert Lange
2019-03-06 16:48 ` Thomas Petazzoni
2019-03-06 17:09 ` Norbert Lange
2019-03-06 21:54 ` Thomas Petazzoni
2019-03-25 21:13 ` Peter Korsgaard
2019-03-14 22:13 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox