Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/gst1-libav: fix syntax error
@ 2019-03-29 14:55 Fabrice Fontaine
  2019-03-29 14:55 ` [Buildroot] [PATCH 2/2] package/gst1-libav: fix powerpc build Fabrice Fontaine
  2019-03-29 16:06 ` [Buildroot] [PATCH 1/2] package/gst1-libav: fix syntax error Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2019-03-29 14:55 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/gstreamer1/gst1-libav/gst1-libav.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/gstreamer1/gst1-libav/gst1-libav.mk b/package/gstreamer1/gst1-libav/gst1-libav.mk
index 8450c34a07..97e069a35f 100644
--- a/package/gstreamer1/gst1-libav/gst1-libav.mk
+++ b/package/gstreamer1/gst1-libav/gst1-libav.mk
@@ -83,7 +83,7 @@ else
 GST1_LIBAV_CONF_EXTRA_OPTS += --disable-vfp
 endif
 
-ifeq ($(BR2_POWERPC_CPU_HASH_ALTIVEC),y)
+ifeq ($(BR2_POWERPC_CPU_HAS_ALTIVEC),y)
 GST1_LIBAV_CONF_EXTRA_OPTS += --enable-altivec
 else
 GST1_LIBAV_CONF_EXTRA_OPTS += --disable-altivec
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 2/2] package/gst1-libav: fix powerpc build
  2019-03-29 14:55 [Buildroot] [PATCH 1/2] package/gst1-libav: fix syntax error Fabrice Fontaine
@ 2019-03-29 14:55 ` Fabrice Fontaine
  2019-03-29 16:06 ` [Buildroot] [PATCH 1/2] package/gst1-libav: fix syntax error Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2019-03-29 14:55 UTC (permalink / raw)
  To: buildroot

AS "hack" is also needed for powerpc builds otherwise build fails on:
AS	libavcodec/ppc/fft_altivec.o
/home/buildroot/autobuild/run/instance-2/output/host/bin/powerpc64-linux-as: invalid option -- '_'

This error is raised because CPPFLAGS are (wrongly) passed to AS

Fixes:
 - http://autobuild.buildroot.org/results/6710e72452fe70788d75191b8b735f90beff9361
 - http://autobuild.buildroot.org/results/a1f22975d4a4a6cfc553a450da464a431702800f
 - http://autobuild.buildroot.org/results/be2d161443c5ab24979e6b9389eb21a53d4b4066

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/gstreamer1/gst1-libav/gst1-libav.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/gstreamer1/gst1-libav/gst1-libav.mk b/package/gstreamer1/gst1-libav/gst1-libav.mk
index 97e069a35f..254ab719ae 100644
--- a/package/gstreamer1/gst1-libav/gst1-libav.mk
+++ b/package/gstreamer1/gst1-libav/gst1-libav.mk
@@ -15,8 +15,8 @@ GST1_LIBAV_LICENSE = GPL-2.0+
 GST1_LIBAV_LICENSE_FILES = COPYING
 GST1_LIBAV_CONF_EXTRA_OPTS = --cross-prefix=$(TARGET_CROSS) --target-os=linux
 
-# fixes arm build: https://bugzilla.gnome.org/show_bug.cgi?id=694416
-ifeq ($(BR2_arm)$(BR2_armeb)$(BR2_aarch64)$(BR2_aarch64_be),y)
+# fixes arm/powerpc build: https://bugzilla.gnome.org/show_bug.cgi?id=694416
+ifeq ($(BR2_arm)$(BR2_armeb)$(BR2_aarch64)$(BR2_aarch64_be)$(BR2_powerpc)$(BR2_powerpc64)$(BR2_powerpc64le),y)
 GST1_LIBAV_CONF_ENV = AS="$(TARGET_CROSS)gcc"
 endif
 
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/2] package/gst1-libav: fix syntax error
  2019-03-29 14:55 [Buildroot] [PATCH 1/2] package/gst1-libav: fix syntax error Fabrice Fontaine
  2019-03-29 14:55 ` [Buildroot] [PATCH 2/2] package/gst1-libav: fix powerpc build Fabrice Fontaine
@ 2019-03-29 16:06 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-03-29 16:06 UTC (permalink / raw)
  To: buildroot

On Fri, 29 Mar 2019 15:55:46 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/gstreamer1/gst1-libav/gst1-libav.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Both applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-29 16:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-29 14:55 [Buildroot] [PATCH 1/2] package/gst1-libav: fix syntax error Fabrice Fontaine
2019-03-29 14:55 ` [Buildroot] [PATCH 2/2] package/gst1-libav: fix powerpc build Fabrice Fontaine
2019-03-29 16:06 ` [Buildroot] [PATCH 1/2] package/gst1-libav: fix syntax error Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox