Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/netsniff-ng: Fix build caused by extra 'install' target
@ 2019-04-02 14:23 Vadim Kochan
  2019-04-02 18:18 ` Peter Korsgaard
  2019-04-03  7:17 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Vadim Kochan @ 2019-04-02 14:23 UTC (permalink / raw)
  To: buildroot

From: Vadim Kochan <vadim4j@gmail.com>

After commit:

	b0f98d5 package/netsniff-ng: allow to build with uclibc but w/o mausezahn

the different build and install targets are specified depending if
masuezahn tool is able to be selected or not. It works for the build
case but for the install the old 'install' target was not removed from
the make invocation and it still forces to install the mausezahn, so fix
it by remove this target.

Fixes:
	http://autobuild.buildroot.net/results/cc44ed737799c9ac73628c82b86bd526b1c43310/
	http://autobuild.buildroot.net/results/72d0753532720604d51c05663af7fbfe37434339/

Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
 package/netsniff-ng/netsniff-ng.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/netsniff-ng/netsniff-ng.mk b/package/netsniff-ng/netsniff-ng.mk
index 8dd06b6..415e86d 100644
--- a/package/netsniff-ng/netsniff-ng.mk
+++ b/package/netsniff-ng/netsniff-ng.mk
@@ -54,7 +54,7 @@ endef
 
 define NETSNIFF_NG_INSTALL_TARGET_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
-		PREFIX=$(TARGET_DIR)/usr ETCDIR=$(TARGET_DIR)/etc install \
+		PREFIX=$(TARGET_DIR)/usr ETCDIR=$(TARGET_DIR)/etc \
 			-C $(@D) $(NETSNIFF_NG_INSTALL_MAKE_TARGET)
 endef
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/netsniff-ng: Fix build caused by extra 'install' target
  2019-04-02 14:23 [Buildroot] [PATCH 1/1] package/netsniff-ng: Fix build caused by extra 'install' target Vadim Kochan
@ 2019-04-02 18:18 ` Peter Korsgaard
  2019-04-03  7:17 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-04-02 18:18 UTC (permalink / raw)
  To: buildroot

>>>>> "Vadim" == Vadim Kochan <vadim4j@gmail.com> writes:

 > From: Vadim Kochan <vadim4j@gmail.com>
 > After commit:

 > 	b0f98d5 package/netsniff-ng: allow to build with uclibc but w/o mausezahn

 > the different build and install targets are specified depending if
 > masuezahn tool is able to be selected or not. It works for the build
 > case but for the install the old 'install' target was not removed from
 > the make invocation and it still forces to install the mausezahn, so fix
 > it by remove this target.

 > Fixes:
 > 	http://autobuild.buildroot.net/results/cc44ed737799c9ac73628c82b86bd526b1c43310/
 > 	http://autobuild.buildroot.net/results/72d0753532720604d51c05663af7fbfe37434339/

 > Signed-off-by: Vadim Kochan <vadim4j@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/netsniff-ng: Fix build caused by extra 'install' target
  2019-04-02 14:23 [Buildroot] [PATCH 1/1] package/netsniff-ng: Fix build caused by extra 'install' target Vadim Kochan
  2019-04-02 18:18 ` Peter Korsgaard
@ 2019-04-03  7:17 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-04-03  7:17 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue,  2 Apr 2019 17:23:58 +0300
Vadim Kochan <vadim4j@gmail.com> wrote:

> From: Vadim Kochan <vadim4j@gmail.com>
> 
> After commit:
> 
> 	b0f98d5 package/netsniff-ng: allow to build with uclibc but w/o mausezahn
> 
> the different build and install targets are specified depending if
> masuezahn tool is able to be selected or not. It works for the build
> case but for the install the old 'install' target was not removed from
> the make invocation and it still forces to install the mausezahn, so fix
> it by remove this target.
> 
> Fixes:
> 	http://autobuild.buildroot.net/results/cc44ed737799c9ac73628c82b86bd526b1c43310/
> 	http://autobuild.buildroot.net/results/72d0753532720604d51c05663af7fbfe37434339/
> 
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>

Gah, indeed. Thanks for fixing my mess :-/

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-03  7:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-02 14:23 [Buildroot] [PATCH 1/1] package/netsniff-ng: Fix build caused by extra 'install' target Vadim Kochan
2019-04-02 18:18 ` Peter Korsgaard
2019-04-03  7:17 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox