Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/binutils: fix build error due to architecture name is incomplete
@ 2019-04-18  9:46 Nylon Chen
  2019-04-20 14:16 ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Nylon Chen @ 2019-04-18  9:46 UTC (permalink / raw)
  To: buildroot

Fixes
  http://autobuild.buildroot.net/results/128/12803a705586e82fdfb49013da2eb3b9879ccd45/

Signed-off-by: Che-Wei Chuang <cnoize@andestech.com>
Signed-off-by: Greentime Hu <greentime@andestech.com>
Signed-off-by: Nylon Chen <nylon7@andestech.com>
---
 Makefile                   | 1 +
 arch/Config.in.nds32       | 2 +-
 package/binutils/Config.in | 4 ++--
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 522c0b0606..86e444da98 100644
--- a/Makefile
+++ b/Makefile
@@ -439,6 +439,7 @@ KERNEL_ARCH := $(shell echo "$(ARCH)" | sed -e "s/-.*//" \
 	-e s/arceb/arc/ \
 	-e s/arm.*/arm/ -e s/sa110/arm/ \
 	-e s/aarch64.*/arm64/ \
+	-e s/nds32.*/nds32/ \
 	-e s/or1k/openrisc/ \
 	-e s/parisc64/parisc/ \
 	-e s/powerpc64.*/powerpc/ \
diff --git a/arch/Config.in.nds32 b/arch/Config.in.nds32
index 9c5db20e6f..f268883662 100644
--- a/arch/Config.in.nds32
+++ b/arch/Config.in.nds32
@@ -1,5 +1,5 @@
 config BR2_ARCH
-	default "nds32"
+	default "nds32le"
 
 config BR2_GCC_TARGET_ARCH
 	default "v3"
diff --git a/package/binutils/Config.in b/package/binutils/Config.in
index 2bf7929ac8..e17a8ec65a 100644
--- a/package/binutils/Config.in
+++ b/package/binutils/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_BINUTILS
 	bool "binutils"
-	depends on !BR2_nios2 && !BR2_nds32
+	depends on !BR2_nios2
 	depends on BR2_USE_WCHAR
 	help
 	  Install binutils on the target
@@ -21,5 +21,5 @@ config BR2_PACKAGE_BINUTILS_TARGET
 endif
 
 comment "binutils needs a toolchain w/ wchar"
-	depends on !BR2_nios2 && !BR2_nds32
+	depends on !BR2_nios2
 	depends on !BR2_USE_WCHAR
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/binutils: fix build error due to architecture name is incomplete
  2019-04-18  9:46 [Buildroot] [PATCH 1/1] package/binutils: fix build error due to architecture name is incomplete Nylon Chen
@ 2019-04-20 14:16 ` Thomas Petazzoni
       [not found]   ` <CAGKtFauRjyM83yyhyB5GC8_W_8PfhxaWgUhK9OLvecxfOH0R+g@mail.gmail.com>
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-04-20 14:16 UTC (permalink / raw)
  To: buildroot

On Thu, 18 Apr 2019 17:46:55 +0800
Nylon Chen <nylon7@andestech.com> wrote:

> Fixes
>   http://autobuild.buildroot.net/results/128/12803a705586e82fdfb49013da2eb3b9879ccd45/
> 
> Signed-off-by: Che-Wei Chuang <cnoize@andestech.com>
> Signed-off-by: Greentime Hu <greentime@andestech.com>
> Signed-off-by: Nylon Chen <nylon7@andestech.com>
> ---
>  Makefile                   | 1 +
>  arch/Config.in.nds32       | 2 +-
>  package/binutils/Config.in | 4 ++--
>  3 files changed, 4 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/binutils: fix build error due to architecture name is incomplete
       [not found]   ` <CAGKtFauRjyM83yyhyB5GC8_W_8PfhxaWgUhK9OLvecxfOH0R+g@mail.gmail.com>
@ 2019-04-20 14:56     ` Thomas Petazzoni
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2019-04-20 14:56 UTC (permalink / raw)
  To: buildroot

Hello,

On Sat, 20 Apr 2019 22:33:26 +0800
??? <nylon7717@gmail.com> wrote:

> Sorry I make a mistake, this patch has an error, our architecture name is
> nds32 not nds32le.

Well, the architecture can be named nds32, but its tuple can be nds32le.

At least, gnuconfig supports nds32le and nds32be:

$ grep nds32 support/gnuconfig/*
support/gnuconfig/config.sub:	| nds32 | nds32le | nds32be \
support/gnuconfig/config.sub:	| nds32-* | nds32le-* | nds32be-* \

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/binutils: fix build error due to architecture name is incomplete
@ 2019-04-24 10:44 Nylon Chen
  2019-04-24 17:38 ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Nylon Chen @ 2019-04-24 10:44 UTC (permalink / raw)
  To: buildroot

Fixes
  http://autobuild.buildroot.net/results/128/12803a705586e82fdfb49013da2eb3b9879ccd45/

Signed-off-by: Che-Wei Chuang <cnoize@andestech.com>
Signed-off-by: Greentime Hu <greentime@andestech.com>
Signed-off-by: Nylon Chen <nylon7@andestech.com>
---
 Makefile                   | 1 +
 arch/Config.in.nds32       | 2 +-
 package/binutils/Config.in | 4 ++--
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 522c0b0606..86e444da98 100644
--- a/Makefile
+++ b/Makefile
@@ -439,6 +439,7 @@ KERNEL_ARCH := $(shell echo "$(ARCH)" | sed -e "s/-.*//" \
 	-e s/arceb/arc/ \
 	-e s/arm.*/arm/ -e s/sa110/arm/ \
 	-e s/aarch64.*/arm64/ \
+	-e s/nds32.*/nds32/ \
 	-e s/or1k/openrisc/ \
 	-e s/parisc64/parisc/ \
 	-e s/powerpc64.*/powerpc/ \
diff --git a/arch/Config.in.nds32 b/arch/Config.in.nds32
index 9c5db20e6f..f268883662 100644
--- a/arch/Config.in.nds32
+++ b/arch/Config.in.nds32
@@ -1,5 +1,5 @@
 config BR2_ARCH
-	default "nds32"
+	default "nds32le"
 
 config BR2_GCC_TARGET_ARCH
 	default "v3"
diff --git a/package/binutils/Config.in b/package/binutils/Config.in
index 2bf7929ac8..e17a8ec65a 100644
--- a/package/binutils/Config.in
+++ b/package/binutils/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_BINUTILS
 	bool "binutils"
-	depends on !BR2_nios2 && !BR2_nds32
+	depends on !BR2_nios2
 	depends on BR2_USE_WCHAR
 	help
 	  Install binutils on the target
@@ -21,5 +21,5 @@ config BR2_PACKAGE_BINUTILS_TARGET
 endif
 
 comment "binutils needs a toolchain w/ wchar"
-	depends on !BR2_nios2 && !BR2_nds32
+	depends on !BR2_nios2
 	depends on !BR2_USE_WCHAR
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/binutils: fix build error due to architecture name is incomplete
  2019-04-24 10:44 Nylon Chen
@ 2019-04-24 17:38 ` Thomas Petazzoni
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2019-04-24 17:38 UTC (permalink / raw)
  To: buildroot

On Wed, 24 Apr 2019 18:44:01 +0800
Nylon Chen <nylon7@andestech.com> wrote:

> Fixes
>   http://autobuild.buildroot.net/results/128/12803a705586e82fdfb49013da2eb3b9879ccd45/
> 
> Signed-off-by: Che-Wei Chuang <cnoize@andestech.com>
> Signed-off-by: Greentime Hu <greentime@andestech.com>
> Signed-off-by: Nylon Chen <nylon7@andestech.com>

Thanks, but the exact same patch was already merged:

  https://git.buildroot.org/buildroot/commit/arch?id=b58a6bf774baf56c3a73a838acb8a5472594ce82

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-04-24 17:38 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-18  9:46 [Buildroot] [PATCH 1/1] package/binutils: fix build error due to architecture name is incomplete Nylon Chen
2019-04-20 14:16 ` Thomas Petazzoni
     [not found]   ` <CAGKtFauRjyM83yyhyB5GC8_W_8PfhxaWgUhK9OLvecxfOH0R+g@mail.gmail.com>
2019-04-20 14:56     ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2019-04-24 10:44 Nylon Chen
2019-04-24 17:38 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox