[Buildroot] [PATCH] network-manager: don't require an external DHCP client

[Buildroot] [PATCH] network-manager: don't require an external DHCP client

[Trent Piepho]

NetworkManager now has an internal DHCP client.  Therefor, there is no
need to select either the DHCPCD or DHCP_CLIENT package to get DHCP.

Remove the forced select of one of those packages.

The internal DHCP client has become NetworkManager's preferred DHCP
client, so it seems reasonable that it effectively becomes the default,
unless DHCPCD or DHCP_CLIENT are intentionally enabled.

Signed-off-by: Trent Piepho <tpiepho@impinj.com>
---
 package/network-manager/Config.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/network-manager/Config.in b/package/network-manager/Config.in
index ca508185f0..2d854fe003 100644
--- a/package/network-manager/Config.in
+++ b/package/network-manager/Config.in
@@ -7,7 +7,6 @@ config BR2_PACKAGE_NETWORK_MANAGER
 	# Tested with 3.2, but may even work with earlier versions
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2
 	depends on BR2_TOOLCHAIN_USES_GLIBC # CLOCK_BOOTTIME, IPTOS_CLASS_*
-	select BR2_PACKAGE_DHCPCD if !BR2_PACKAGE_DHCP_CLIENT
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_DBUS_GLIB
 	select BR2_PACKAGE_GNUTLS
-- 
2.14.5

[Buildroot] [PATCH] network-manager: don't require an external DHCP client

[Thomas Petazzoni]

On Thu, 25 Apr 2019 00:10:46 +0000
Trent Piepho <tpiepho@impinj.com> wrote:

> NetworkManager now has an internal DHCP client.  Therefor, there is no
> need to select either the DHCPCD or DHCP_CLIENT package to get DHCP.
> 
> Remove the forced select of one of those packages.
> 
> The internal DHCP client has become NetworkManager's preferred DHCP
> client, so it seems reasonable that it effectively becomes the default,
> unless DHCPCD or DHCP_CLIENT are intentionally enabled.
> 
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>
> ---
>  package/network-manager/Config.in | 1 -
>  1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com