* [Buildroot] [PATCH v2 1/3] package/murata-wireless-cyw-fmac-fw: new package
2019-05-07 8:32 [Buildroot] [PATCH v2 0/3] murata-wireless firmware packages Marcin Niestroj
@ 2019-05-07 8:32 ` Marcin Niestroj
2019-05-07 23:10 ` Arnout Vandecappelle
2019-05-07 8:32 ` [Buildroot] [PATCH v2 2/3] package/murata-wireless-cyw-fmac-nvram: " Marcin Niestroj
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Marcin Niestroj @ 2019-05-07 8:32 UTC (permalink / raw)
To: buildroot
Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
---
Changes v1 -> v2:
- add myself to DEVELOPERS.
DEVELOPERS | 1 +
package/Config.in | 1 +
package/murata-wireless/Config.in | 5 +
.../murata-wireless-cyw-fmac-fw/Config.in | 91 +++++++++++++++++++
.../murata-wireless-cyw-fmac-fw.hash | 3 +
.../murata-wireless-cyw-fmac-fw.mk | 80 ++++++++++++++++
package/murata-wireless/murata-wireless.mk | 9 ++
7 files changed, 190 insertions(+)
create mode 100644 package/murata-wireless/Config.in
create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in
create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash
create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk
create mode 100644 package/murata-wireless/murata-wireless.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 5bfc4561c0..9a8027663f 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1386,6 +1386,7 @@ F: package/easydbus/
F: package/lua-flu/
F: package/lua-stdlib/
F: package/luaossl/
+F: package/murata-wireless/
F: package/rs485conf/
F: package/turbolua/
diff --git a/package/Config.in b/package/Config.in
index f592e74a99..2133ab9100 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -382,6 +382,7 @@ menu "Firmware"
source "package/armbian-firmware/Config.in"
source "package/b43-firmware/Config.in"
source "package/linux-firmware/Config.in"
+ source "package/murata-wireless/Config.in"
source "package/rpi-bt-firmware/Config.in"
source "package/rpi-firmware/Config.in"
source "package/rpi-wifi-firmware/Config.in"
diff --git a/package/murata-wireless/Config.in b/package/murata-wireless/Config.in
new file mode 100644
index 0000000000..93fcb15e46
--- /dev/null
+++ b/package/murata-wireless/Config.in
@@ -0,0 +1,5 @@
+menu "murata-wireless"
+
+source "package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in"
+
+endmenu
diff --git a/package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in b/package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in
new file mode 100644
index 0000000000..d4dde56912
--- /dev/null
+++ b/package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in
@@ -0,0 +1,91 @@
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW
+ bool "cyw-fmac-fw"
+ help
+ Murata Wireless FMAC WiFi firmware.
+
+ https://github.com/murata-wireless/cyw-fmac-fw
+
+if BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43012
+ bool "CYW43012 (1LV)"
+ help
+ Murata Wireless FMAC WiFi CYW43012 (1LV) module firmware.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43340
+ bool "CYW43340/CYW43341 (1BW)"
+ help
+ Murata Wireless FMAC WiFi CYW43340/CYW43341 (1BW) module
+ firmware.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43362
+ bool "CYW43362 (SN8000)"
+ help
+ Murata Wireless FMAC WiFi CYW43362 (SN8000) module
+ firmware.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW4339
+ bool "CYW4339 (1CK/ZP)"
+ help
+ Murata Wireless FMAC WiFi CYW4339 (1CK/ZP) module
+ firmware.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430
+ bool "CYW43430/CYW4343W/CYW43364 (1DX/1FX/1LN)"
+ help
+ Murata Wireless FMAC WiFi CYW43430/CYW4343W/CYW43364
+ (1DX/1FX/1LN) module firmware.
+
+choice
+ prompt "CYW43430/CYW4343W/CYW43364 module" if BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1DX
+ bool "1DX"
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1FX
+ bool "1FX"
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1LN
+ bool "1LN"
+
+endchoice
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43455
+ bool "CYW43455 (1HK/1LC/1MW)"
+ help
+ Murata Wireless FMAC WiFi CYW43455 (1HK/1LC/1MW) module
+ firmware.
+
+choice
+ prompt "CYW43455 module" if BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43455
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43455_1HK
+ bool "1HK"
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43455_1LC
+ bool "1LC"
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43455_1MW
+ bool "1MW"
+
+endchoice
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW4354
+ bool "CYW4354 (1BB)"
+ help
+ Murata Wireless FMAC WiFi CYW4354 (1BB) module
+ firmware.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW4356
+ bool "CYW4356 (1CX)"
+ help
+ Murata Wireless FMAC WiFi CYW4356 (1CX) module
+ firmware.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW4359
+ bool "CYW4359 (1FD)"
+ help
+ Murata Wireless FMAC WiFi CYW4359 (1FD) module
+ firmware.
+
+endif
diff --git a/package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash b/package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash
new file mode 100644
index 0000000000..42ec54e2fa
--- /dev/null
+++ b/package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256 c3ecf357786d6db6f3283c0ea36ec067b1728f801fd8871694aed1502a82e9bc murata-wireless-cyw-fmac-fw-8d87950bfad28c65926695b7357bd8995b60016a.tar.gz
+sha256 3a892759b73e8b459f1a750954b316118b0061fd9d1868d11fa258c104ee7e0c LICENCE.cypress
diff --git a/package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk b/package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk
new file mode 100644
index 0000000000..9f6355e340
--- /dev/null
+++ b/package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk
@@ -0,0 +1,80 @@
+################################################################################
+#
+# murata-wireless-cyw-fmac-fw
+#
+################################################################################
+
+MURATA_WIRELESS_CYW_FMAC_FW_VERSION = 8d87950bfad28c65926695b7357bd8995b60016a
+MURATA_WIRELESS_CYW_FMAC_FW_SITE = $(call github,murata-wireless,cyw-fmac-fw,$(MURATA_WIRELESS_CYW_FMAC_FW_VERSION))
+MURATA_WIRELESS_CYW_FMAC_FW_LICENSE = PROPRIETARY
+MURATA_WIRELESS_CYW_FMAC_FW_LICENSE_FILES = LICENCE.cypress
+MURATA_WIRELESS_CYW_FMAC_FW_REDISTRIBUTE = NO
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43012),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43012-sdio.bin
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43012-sdio.1LV.clm_blob
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43340),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43340-sdio.bin
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43362),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43362-sdio.bin
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW4339),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac4339-sdio.bin
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43430-sdio.bin
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1DX),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43430-sdio.1DX.clm_blob
+endif
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1FX),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43430-sdio.1FX.clm_blob
+endif
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1LN),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43430-sdio.1LN.clm_blob
+endif
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43455),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43455-sdio.bin
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43455_1HK),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43455-sdio.1HK.clm_blob
+endif
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43455_1LC),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43455-sdio.1LC.clm_blob
+endif
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43455_1MW),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43455-sdio.1MW.clm_blob
+endif
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW4354),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac4354-sdio.bin
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac4354-sdio.1BB.clm_blob
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW4356),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac4356-pcie.bin
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac4356-pcie.1CX.clm_blob
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW4359),y)
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac4359-pcie.bin
+MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac4359-pcie.1FD.clm_blob
+endif
+
+ifneq ($(MURATA_WIRELESS_CYW_FMAC_FW_FILES),)
+define MURATA_WIRELESS_CYW_FMAC_FW_INSTALL_TARGET_CMDS
+ mkdir -p $(TARGET_DIR)/lib/firmware/brcm
+ $(foreach f,$(MURATA_WIRELESS_CYW_FMAC_FW_FILES), \
+ $(INSTALL) -m 0644 $(@D)/$(f) \
+ $(TARGET_DIR)/lib/firmware/brcm/$(call murata-wireless-strip-model,$(f))$(sep))
+endef
+endif
+
+$(eval $(generic-package))
diff --git a/package/murata-wireless/murata-wireless.mk b/package/murata-wireless/murata-wireless.mk
new file mode 100644
index 0000000000..e5434f09f0
--- /dev/null
+++ b/package/murata-wireless/murata-wireless.mk
@@ -0,0 +1,9 @@
+################################################################################
+#
+# murata-wireless
+#
+################################################################################
+
+murata-wireless-strip-model = $(shell echo -n $(1) | sed 's/\..*\./\./')
+
+include $(sort $(wildcard package/murata-wireless/*/*.mk))
--
2.21.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH v2 1/3] package/murata-wireless-cyw-fmac-fw: new package
2019-05-07 8:32 ` [Buildroot] [PATCH v2 1/3] package/murata-wireless-cyw-fmac-fw: new package Marcin Niestroj
@ 2019-05-07 23:10 ` Arnout Vandecappelle
2019-05-09 7:44 ` Marcin Niestrój
0 siblings, 1 reply; 10+ messages in thread
From: Arnout Vandecappelle @ 2019-05-07 23:10 UTC (permalink / raw)
To: buildroot
On 07/05/2019 10:32, Marcin Niestroj wrote:
> +config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW4339
> + bool "CYW4339 (1CK/ZP)"
> + help
> + Murata Wireless FMAC WiFi CYW4339 (1CK/ZP) module
> + firmware.
> +
> +config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430
> + bool "CYW43430/CYW4343W/CYW43364 (1DX/1FX/1LN)"
> + help
> + Murata Wireless FMAC WiFi CYW43430/CYW4343W/CYW43364
> + (1DX/1FX/1LN) module firmware.
> +
> +choice
> + prompt "CYW43430/CYW4343W/CYW43364 module" if BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430
> +
> +config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1DX
> + bool "1DX"
> +
> +config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1FX
> + bool "1FX"
> +
> +config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1LN
> + bool "1LN"
> +
> +endchoice
I don't understand this. Why is it possible to install firmware for CYW4339 and
CYW43430 1DX at the same time, but not for CYW43430 IDX and CYW43430 1FX?
In other words, why a choice and not just separate options like for the rest?
So I think what you want is that the
BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430 option becomes a blind option
and moves out of the choice, and that it gets selected by
BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1DX etc.
> +ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43340),y)
> +MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43340-sdio.bin
> +endif
In most of this type of many-simple-options situations, we use something like
MURATA_WIRELESS_CYW_FMAC_FW_FILES_$(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43340)
+= brcmfmac43340-sdio.bin
By the way, I think the package name is way too long. With Yann's idea to merge
the three, I think we could name it e.g. murata-cyw-fw.
Regards,
Arnout
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/3] package/murata-wireless-cyw-fmac-fw: new package
2019-05-07 23:10 ` Arnout Vandecappelle
@ 2019-05-09 7:44 ` Marcin Niestrój
0 siblings, 0 replies; 10+ messages in thread
From: Marcin Niestrój @ 2019-05-09 7:44 UTC (permalink / raw)
To: buildroot
Hi Arnout,
Arnout Vandecappelle <arnout@mind.be> writes:
> On 07/05/2019 10:32, Marcin Niestroj wrote:
>> +config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW4339
>> + bool "CYW4339 (1CK/ZP)"
>> + help
>> + Murata Wireless FMAC WiFi CYW4339 (1CK/ZP) module
>> + firmware.
>> +
>> +config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430
>> + bool "CYW43430/CYW4343W/CYW43364 (1DX/1FX/1LN)"
>> + help
>> + Murata Wireless FMAC WiFi CYW43430/CYW4343W/CYW43364
>> + (1DX/1FX/1LN) module firmware.
>> +
>> +choice
>> + prompt "CYW43430/CYW4343W/CYW43364 module" if BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430
>> +
>> +config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1DX
>> + bool "1DX"
>> +
>> +config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1FX
>> + bool "1FX"
>> +
>> +config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1LN
>> + bool "1LN"
>> +
>> +endchoice
>
> I don't understand this. Why is it possible to install firmware for CYW4339 and
> CYW43430 1DX at the same time, but not for CYW43430 IDX and CYW43430 1FX?
This is because 'brcmfmac43430-sdio.1DX.clm_blob' is renamed during
installation step into 'brcmfmac43430-sdio.clm_blob' (using
murata-cyw-fw-strip-model helper). The latter is the firmware name
expected by Linux kernel.
>
> In other words, why a choice and not just separate options like for the rest?
>
> So I think what you want is that the
> BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430 option becomes a blind option
> and moves out of the choice, and that it gets selected by
> BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43430_1DX etc.
It would be nice to do it that way. However different modules based on
the same chip have conflicting names under /lib/firmware/brcm/
directory.
>
>
>> +ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43340),y)
>> +MURATA_WIRELESS_CYW_FMAC_FW_FILES += brcmfmac43340-sdio.bin
>> +endif
>
> In most of this type of many-simple-options situations, we use something like
>
> MURATA_WIRELESS_CYW_FMAC_FW_FILES_$(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_FW_CYW43340)
> += brcmfmac43340-sdio.bin
Thanks for hint!
>
> By the way, I think the package name is way too long. With Yann's idea to merge
> the three, I think we could name it e.g. murata-cyw-fw.
Okay, will use proposed name.
>
> Regards,
> Arnout
--
Marcin Niestr?j
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 2/3] package/murata-wireless-cyw-fmac-nvram: new package
2019-05-07 8:32 [Buildroot] [PATCH v2 0/3] murata-wireless firmware packages Marcin Niestroj
2019-05-07 8:32 ` [Buildroot] [PATCH v2 1/3] package/murata-wireless-cyw-fmac-fw: new package Marcin Niestroj
@ 2019-05-07 8:32 ` Marcin Niestroj
2019-05-07 8:32 ` [Buildroot] [PATCH v2 3/3] package/murata-wireless-cyw-bt-patch: " Marcin Niestroj
2019-05-07 15:41 ` [Buildroot] [PATCH v2 0/3] murata-wireless firmware packages Yann E. MORIN
3 siblings, 0 replies; 10+ messages in thread
From: Marcin Niestroj @ 2019-05-07 8:32 UTC (permalink / raw)
To: buildroot
Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
---
Changes v1 -> v2: none
package/murata-wireless/Config.in | 1 +
.../murata-wireless-cyw-fmac-nvram/Config.in | 91 +++++++++++++++++++
.../murata-wireless-cyw-fmac-nvram.hash | 3 +
.../murata-wireless-cyw-fmac-nvram.mk | 75 +++++++++++++++
4 files changed, 170 insertions(+)
create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in
create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash
create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk
diff --git a/package/murata-wireless/Config.in b/package/murata-wireless/Config.in
index 93fcb15e46..9d2ae8b29a 100644
--- a/package/murata-wireless/Config.in
+++ b/package/murata-wireless/Config.in
@@ -1,5 +1,6 @@
menu "murata-wireless"
source "package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in"
+source "package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in"
endmenu
diff --git a/package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in b/package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in
new file mode 100644
index 0000000000..1e115f189c
--- /dev/null
+++ b/package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in
@@ -0,0 +1,91 @@
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM
+ bool "cyw-fmac-nvram"
+ help
+ Murata Wireless FMAC WiFi nvram.
+
+ https://github.com/murata-wireless/cyw-fmac-nvram
+
+if BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43012
+ bool "CYW43012 (1LV)"
+ help
+ Murata Wireless FMAC WiFi CYW43012 (1LV) module nvram.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43340
+ bool "CYW43340/CYW43341 (1BW)"
+ help
+ Murata Wireless FMAC WiFi CYW43340/CYW43341 (1BW) module
+ nvram.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43362
+ bool "CYW43362 (SN8000)"
+ help
+ Murata Wireless FMAC WiFi CYW43362 (SN8000) module nvram.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW4339
+ bool "CYW4339 (1CK/ZP)"
+ help
+ Murata Wireless FMAC WiFi CYW4339 (1CK/ZP) module nvram.
+
+choice
+ prompt "CYW4339 module" if BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW4339
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW4339_1CK
+ bool "1CK"
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW4339_ZP
+ bool "ZP"
+
+endchoice
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43430
+ bool "CYW43430/CYW4343W/CYW43364 (1DX/1FX/1LN)"
+ help
+ Murata Wireless FMAC WiFi CYW43430/CYW4343W/CYW43364
+ (1DX/1FX/1LN) module nvram.
+
+choice
+ prompt "CYW43430/CYW4343W/CYW43364 module" if BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43430
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43430_1DX
+ bool "1DX"
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43430_1FX
+ bool "1FX"
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43430_1LN
+ bool "1LN"
+
+endchoice
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43455
+ bool "CYW43455 (1HK/1LC/1MW)"
+ help
+ Murata Wireless FMAC WiFi CYW43455 (1HK/1LC/1MW) module nvram.
+
+choice
+ prompt "CYW43455 module" if BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43455
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43455_1HK
+ bool "1HK"
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43455_1LC
+ bool "1LC"
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43455_1MW
+ bool "1MW"
+
+endchoice
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW4354
+ bool "CYW4354 (1BB)"
+ help
+ Murata Wireless FMAC WiFi CYW4354 (1BB) module nvram.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW4356
+ bool "CYW4356 (1CX)"
+ help
+ Murata Wireless FMAC WiFi CYW4356 (1CX) module nvram.
+
+endif
diff --git a/package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash b/package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash
new file mode 100644
index 0000000000..2759180241
--- /dev/null
+++ b/package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256 03c140ae04f9c2036678262d6457b9c4b4a9ebb523c5e681af6d57b97c11da37 murata-wireless-cyw-fmac-nvram-d27f1bf105fa1e5b828e355793b88d4b66188411.tar.gz
+sha256 3a892759b73e8b459f1a750954b316118b0061fd9d1868d11fa258c104ee7e0c LICENCE.cypress
diff --git a/package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk b/package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk
new file mode 100644
index 0000000000..81413415e3
--- /dev/null
+++ b/package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk
@@ -0,0 +1,75 @@
+################################################################################
+#
+# murata-wireless-cyw-fmac-nvram
+#
+################################################################################
+
+MURATA_WIRELESS_CYW_FMAC_NVRAM_VERSION = d27f1bf105fa1e5b828e355793b88d4b66188411
+MURATA_WIRELESS_CYW_FMAC_NVRAM_SITE = $(call github,murata-wireless,cyw-fmac-nvram,$(MURATA_WIRELESS_CYW_FMAC_NVRAM_VERSION))
+MURATA_WIRELESS_CYW_FMAC_NVRAM_LICENSE = PROPRIETARY
+MURATA_WIRELESS_CYW_FMAC_NVRAM_LICENSE_FILES = LICENCE.cypress
+MURATA_WIRELESS_CYW_FMAC_NVRAM_REDISTRIBUTE = NO
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43012),y)
+MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES += brcmfmac43012-sdio.1LV.txt
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43340),y)
+MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES += brcmfmac43340-sdio.1BW.txt
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43362),y)
+MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES += brcmfmac43362-sdio.SN8000.txt
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW4339),y)
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW4339_1CK),y)
+MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES += brcmfmac4339-sdio.1CK.txt
+endif
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW4339_ZP),y)
+MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES += brcmfmac4339-sdio.ZP.txt
+endif
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43430),y)
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43430_1DX),y)
+MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES += brcmfmac43430-sdio.1DX.txt
+endif
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43430_1FX),y)
+MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES += brcmfmac43430-sdio.1FX.txt
+endif
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43430_1LN),y)
+MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES += brcmfmac43430-sdio.1LN.txt
+endif
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43455),y)
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43455_1HK),y)
+MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES += brcmfmac43455-sdio.1HK.txt
+endif
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43455_1LC),y)
+MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES += brcmfmac43455-sdio.1LC.txt
+endif
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW43455_1MW),y)
+MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES += brcmfmac43455-sdio.1MW.txt
+endif
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW4354),y)
+MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES += brcmfmac4354-sdio.1BB.txt
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FMAC_NVRAM_CYW4356),y)
+MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES += brcmfmac4356-pcie.1CX.txt
+endif
+
+ifneq ($(MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES),)
+define MURATA_WIRELESS_CYW_FMAC_NVRAM_INSTALL_TARGET_CMDS
+ mkdir -p $(TARGET_DIR)/lib/firmware/brcm
+ $(foreach f,$(MURATA_WIRELESS_CYW_FMAC_NVRAM_FILES), \
+ $(INSTALL) -m 0644 $(@D)/$(f) \
+ $(TARGET_DIR)/lib/firmware/brcm/$(call murata-wireless-strip-model,$(f))$(sep))
+endef
+endif
+
+$(eval $(generic-package))
--
2.21.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 3/3] package/murata-wireless-cyw-bt-patch: new package
2019-05-07 8:32 [Buildroot] [PATCH v2 0/3] murata-wireless firmware packages Marcin Niestroj
2019-05-07 8:32 ` [Buildroot] [PATCH v2 1/3] package/murata-wireless-cyw-fmac-fw: new package Marcin Niestroj
2019-05-07 8:32 ` [Buildroot] [PATCH v2 2/3] package/murata-wireless-cyw-fmac-nvram: " Marcin Niestroj
@ 2019-05-07 8:32 ` Marcin Niestroj
2019-05-07 15:41 ` [Buildroot] [PATCH v2 0/3] murata-wireless firmware packages Yann E. MORIN
3 siblings, 0 replies; 10+ messages in thread
From: Marcin Niestroj @ 2019-05-07 8:32 UTC (permalink / raw)
To: buildroot
Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
---
Changes v1 -> v2:
- fix mkdir directory path before installing firmware.
package/murata-wireless/Config.in | 1 +
.../murata-wireless-cyw-bt-patch/Config.in | 47 +++++++++++++++++
.../murata-wireless-cyw-bt-patch.hash | 3 ++
.../murata-wireless-cyw-bt-patch.mk | 50 +++++++++++++++++++
4 files changed, 101 insertions(+)
create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in
create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash
create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk
diff --git a/package/murata-wireless/Config.in b/package/murata-wireless/Config.in
index 9d2ae8b29a..3f26e2f803 100644
--- a/package/murata-wireless/Config.in
+++ b/package/murata-wireless/Config.in
@@ -1,5 +1,6 @@
menu "murata-wireless"
+source "package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in"
source "package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in"
source "package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in"
diff --git a/package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in b/package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in
new file mode 100644
index 0000000000..61a519e20b
--- /dev/null
+++ b/package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in
@@ -0,0 +1,47 @@
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH
+ bool "cyw-bt-patch"
+ help
+ Murata Wireless Bluetooth HCD patch.
+
+ https://github.com/murata-wireless/cyw-bt-patch
+
+if BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW43012
+ bool "CYW43012 (1LV)"
+ help
+ Murata Wireless Bluetooth CYW43012 (1LV) module HCD patch.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW43340
+ bool "CYW43340/CYW43341 (1BW)"
+ help
+ Murata Wireless Bluetooth CYW43340/CYW43341 (1BW) module
+ HCD patch.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW4339
+ bool "CYW4339 (1CK/ZP)"
+ help
+ Murata Wireless Bluetooth CYW4339 (1CK/ZP) module
+ HCD patch.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW43430
+ bool "CYW43430/CYW4343W/CYW43364 (1DX)"
+ help
+ Murata Wireless Bluetooth CYW43430 (1DX) module HCD patch.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW43455
+ bool "CYW43455 (1MW)"
+ help
+ Murata Wireless Bluetooth CYW43455 (1MW) module HCD patch.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW4354
+ bool "CYW4354 (1BB)"
+ help
+ Murata Wireless Bluetooth CYW4354 (1BB) module HCD patch.
+
+config BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW4356
+ bool "CYW4356 (1CX)"
+ help
+ Murata Wireless Bluetooth CYW4356 (1CX) module HCD patch.
+
+endif
diff --git a/package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash b/package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash
new file mode 100644
index 0000000000..9b9f8db4d1
--- /dev/null
+++ b/package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256 8f23ebb9a262112b62ace1e1bedcdeb00523d9a45e8d48a829d4ca35db4f0280 murata-wireless-cyw-bt-patch-748462f0b02ec4aeb500bedd60780ac51c37be31.tar.gz
+sha256 3a892759b73e8b459f1a750954b316118b0061fd9d1868d11fa258c104ee7e0c LICENCE.cypress
diff --git a/package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk b/package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk
new file mode 100644
index 0000000000..abd143fd24
--- /dev/null
+++ b/package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk
@@ -0,0 +1,50 @@
+################################################################################
+#
+# murata-wireless-cyw-bt-patch
+#
+################################################################################
+
+MURATA_WIRELESS_CYW_BT_PATCH_VERSION = 748462f0b02ec4aeb500bedd60780ac51c37be31
+MURATA_WIRELESS_CYW_BT_PATCH_SITE = $(call github,murata-wireless,cyw-bt-patch,$(MURATA_WIRELESS_CYW_BT_PATCH_VERSION))
+MURATA_WIRELESS_CYW_BT_PATCH_LICENSE = PROPRIETARY
+MURATA_WIRELESS_CYW_BT_PATCH_LICENSE_FILES = LICENCE.cypress
+MURATA_WIRELESS_CYW_BT_PATCH_REDISTRIBUTE = NO
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW43012),y)
+MURATA_WIRELESS_CYW_BT_PATCH_FILES += CYW43012C0.1LV.hcd
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW43340),y)
+MURATA_WIRELESS_CYW_BT_PATCH_FILES += CYW43341B0.1BW.hcd
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW4339),y)
+MURATA_WIRELESS_CYW_BT_PATCH_FILES += CYW4335C0.ZP.hcd
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW43430),y)
+MURATA_WIRELESS_CYW_BT_PATCH_FILES += CYW43430A1.1DX.hcd
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW43455),y)
+MURATA_WIRELESS_CYW_BT_PATCH_FILES += CYW4345C0.1MW.hcd
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW4354),y)
+MURATA_WIRELESS_CYW_BT_PATCH_FILES += CYW4350C0.1BB.hcd
+endif
+
+ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_BT_PATCH_CYW4356),y)
+MURATA_WIRELESS_CYW_BT_PATCH_FILES += CYW4354A2.1CX.hcd
+endif
+
+ifneq ($(MURATA_WIRELESS_CYW_BT_PATCH_FILES),)
+define MURATA_WIRELESS_CYW_BT_PATCH_INSTALL_TARGET_CMDS
+ mkdir -p $(TARGET_DIR)/lib/firmware/brcm
+ $(foreach f,$(MURATA_WIRELESS_CYW_BT_PATCH_FILES), \
+ $(INSTALL) -m 0644 $(@D)/$(f) \
+ $(TARGET_DIR)/lib/firmware/brcm/$(call murata-wireless-strip-model,$(patsubst CYW%,BCM%,$(f)))$(sep))
+endef
+endif
+
+$(eval $(generic-package))
--
2.21.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 0/3] murata-wireless firmware packages
2019-05-07 8:32 [Buildroot] [PATCH v2 0/3] murata-wireless firmware packages Marcin Niestroj
` (2 preceding siblings ...)
2019-05-07 8:32 ` [Buildroot] [PATCH v2 3/3] package/murata-wireless-cyw-bt-patch: " Marcin Niestroj
@ 2019-05-07 15:41 ` Yann E. MORIN
2019-05-07 23:02 ` Arnout Vandecappelle
2019-05-09 7:52 ` Marcin Niestrój
3 siblings, 2 replies; 10+ messages in thread
From: Yann E. MORIN @ 2019-05-07 15:41 UTC (permalink / raw)
To: buildroot
Marcin, All,
On 2019-05-07 10:32 +0200, Marcin Niestroj spake thusly:
> This set adds 3 firmware packages for muRata wireless modules (WiFi + BLE).
> I've put all three packages into single murata-wireless directory and Kconfig
> submenu, as they relate to the same hardware and there are plenty of options
> to choose from. Not sure whether this is the correct approach, so looking
> forward to get feedback on this.
I wonder why we would actually need three packages.
As far as I can see from a cursory look, they are all very tightly
coupled; they even have the same choice about the actual variant to use.
So, I would like we look at making that a single package, which
downloads multiple tarballs, something like:
MURATA_WIRELESS_CYW_FW_VERSION = 8d87950bfad28c65926695b7357bd8995b60016a
MURATA_WIRELESS_CYW_FW_VERSION_NVRAM = d27f1bf105fa1e5b828e355793b88d4b66188411
MURATA_WIRELESS_CYW_FW_VERSION_PATCH = 748462f0b02ec4aeb500bedd60780ac51c37be31
MURATA_WIRELESS_CYW_FW_SITE = $(call github,murata-wireless,cyw-fmac-fw,$(MURATA_WIRELESS_CYW_FW_VERSION)
MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS = \
$(call github,murata-wireless,cyw-fmac-nvram,$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM)/cyw-bt-nvram-$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM).tar.gz \
$(call github,murata-wireless,cyw-fmac-patch,$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH)/cyw-bt-patch-$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH).tar.gz
define MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
$(foreach tar, $(notdir $(MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS)), \
$(call suitable-extractor,$(tar)) $(MURATA_WIRELESS_CYW_FW_DL_DIR)/$(tar) | \
$(TAR) --strip-components=1 -C $(@D) $(TAR_OPTIONS) -$(sep) \
)
endef
MURATA_WIRELESS_CYW_FW_POST_EXTRACT_HOOKS += MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
And a similar hook for the installation step (which I leave up to you as
an exercise ;-) ).
Regards,
Yann E. MORIN.
> Marcin Niestroj (3):
> package/murata-wireless-cyw-fmac-fw: new package
> package/murata-wireless-cyw-fmac-nvram: new package
> package/murata-wireless-cyw-bt-patch: new package
>
> DEVELOPERS | 1 +
> package/Config.in | 1 +
> package/murata-wireless/Config.in | 7 ++
> .../murata-wireless-cyw-bt-patch/Config.in | 47 ++++++++++
> .../murata-wireless-cyw-bt-patch.hash | 3 +
> .../murata-wireless-cyw-bt-patch.mk | 50 ++++++++++
> .../murata-wireless-cyw-fmac-fw/Config.in | 91 +++++++++++++++++++
> .../murata-wireless-cyw-fmac-fw.hash | 3 +
> .../murata-wireless-cyw-fmac-fw.mk | 80 ++++++++++++++++
> .../murata-wireless-cyw-fmac-nvram/Config.in | 91 +++++++++++++++++++
> .../murata-wireless-cyw-fmac-nvram.hash | 3 +
> .../murata-wireless-cyw-fmac-nvram.mk | 75 +++++++++++++++
> package/murata-wireless/murata-wireless.mk | 9 ++
> 13 files changed, 461 insertions(+)
> create mode 100644 package/murata-wireless/Config.in
> create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in
> create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash
> create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk
> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in
> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash
> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk
> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in
> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash
> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk
> create mode 100644 package/murata-wireless/murata-wireless.mk
>
> --
> 2.21.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 10+ messages in thread* [Buildroot] [PATCH v2 0/3] murata-wireless firmware packages
2019-05-07 15:41 ` [Buildroot] [PATCH v2 0/3] murata-wireless firmware packages Yann E. MORIN
@ 2019-05-07 23:02 ` Arnout Vandecappelle
2019-05-09 7:52 ` Marcin Niestrój
1 sibling, 0 replies; 10+ messages in thread
From: Arnout Vandecappelle @ 2019-05-07 23:02 UTC (permalink / raw)
To: buildroot
On 07/05/2019 17:41, Yann E. MORIN wrote:
> Marcin, All,
>
> On 2019-05-07 10:32 +0200, Marcin Niestroj spake thusly:
>> This set adds 3 firmware packages for muRata wireless modules (WiFi + BLE).
>> I've put all three packages into single murata-wireless directory and Kconfig
>> submenu, as they relate to the same hardware and there are plenty of options
>> to choose from. Not sure whether this is the correct approach, so looking
>> forward to get feedback on this.
>
> I wonder why we would actually need three packages.
>
> As far as I can see from a cursory look, they are all very tightly
> coupled; they even have the same choice about the actual variant to use.
Indeed, I guess you always need all three of them, so this seems to make sense.
Regards,
Arnout
>
> So, I would like we look at making that a single package, which
> downloads multiple tarballs, something like:
>
> MURATA_WIRELESS_CYW_FW_VERSION = 8d87950bfad28c65926695b7357bd8995b60016a
> MURATA_WIRELESS_CYW_FW_VERSION_NVRAM = d27f1bf105fa1e5b828e355793b88d4b66188411
> MURATA_WIRELESS_CYW_FW_VERSION_PATCH = 748462f0b02ec4aeb500bedd60780ac51c37be31
>
> MURATA_WIRELESS_CYW_FW_SITE = $(call github,murata-wireless,cyw-fmac-fw,$(MURATA_WIRELESS_CYW_FW_VERSION)
> MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS = \
> $(call github,murata-wireless,cyw-fmac-nvram,$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM)/cyw-bt-nvram-$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM).tar.gz \
> $(call github,murata-wireless,cyw-fmac-patch,$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH)/cyw-bt-patch-$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH).tar.gz
>
> define MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
> $(foreach tar, $(notdir $(MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS)), \
> $(call suitable-extractor,$(tar)) $(MURATA_WIRELESS_CYW_FW_DL_DIR)/$(tar) | \
> $(TAR) --strip-components=1 -C $(@D) $(TAR_OPTIONS) -$(sep) \
> )
> endef
> MURATA_WIRELESS_CYW_FW_POST_EXTRACT_HOOKS += MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
>
> And a similar hook for the installation step (which I leave up to you as
> an exercise ;-) ).
>
> Regards,
> Yann E. MORIN.
>
>> Marcin Niestroj (3):
>> package/murata-wireless-cyw-fmac-fw: new package
>> package/murata-wireless-cyw-fmac-nvram: new package
>> package/murata-wireless-cyw-bt-patch: new package
>>
>> DEVELOPERS | 1 +
>> package/Config.in | 1 +
>> package/murata-wireless/Config.in | 7 ++
>> .../murata-wireless-cyw-bt-patch/Config.in | 47 ++++++++++
>> .../murata-wireless-cyw-bt-patch.hash | 3 +
>> .../murata-wireless-cyw-bt-patch.mk | 50 ++++++++++
>> .../murata-wireless-cyw-fmac-fw/Config.in | 91 +++++++++++++++++++
>> .../murata-wireless-cyw-fmac-fw.hash | 3 +
>> .../murata-wireless-cyw-fmac-fw.mk | 80 ++++++++++++++++
>> .../murata-wireless-cyw-fmac-nvram/Config.in | 91 +++++++++++++++++++
>> .../murata-wireless-cyw-fmac-nvram.hash | 3 +
>> .../murata-wireless-cyw-fmac-nvram.mk | 75 +++++++++++++++
>> package/murata-wireless/murata-wireless.mk | 9 ++
>> 13 files changed, 461 insertions(+)
>> create mode 100644 package/murata-wireless/Config.in
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk
>> create mode 100644 package/murata-wireless/murata-wireless.mk
>>
>> --
>> 2.21.0
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 0/3] murata-wireless firmware packages
2019-05-07 15:41 ` [Buildroot] [PATCH v2 0/3] murata-wireless firmware packages Yann E. MORIN
2019-05-07 23:02 ` Arnout Vandecappelle
@ 2019-05-09 7:52 ` Marcin Niestrój
2019-05-09 18:10 ` Yann E. MORIN
1 sibling, 1 reply; 10+ messages in thread
From: Marcin Niestrój @ 2019-05-09 7:52 UTC (permalink / raw)
To: buildroot
Hi Yann,
Yann E. MORIN <yann.morin.1998@free.fr> writes:
> Marcin, All,
>
> On 2019-05-07 10:32 +0200, Marcin Niestroj spake thusly:
>> This set adds 3 firmware packages for muRata wireless modules (WiFi + BLE).
>> I've put all three packages into single murata-wireless directory and Kconfig
>> submenu, as they relate to the same hardware and there are plenty of options
>> to choose from. Not sure whether this is the correct approach, so looking
>> forward to get feedback on this.
>
> I wonder why we would actually need three packages.
>
> As far as I can see from a cursory look, they are all very tightly
> coupled; they even have the same choice about the actual variant to use.
>
> So, I would like we look at making that a single package, which
> downloads multiple tarballs, something like:
>
> MURATA_WIRELESS_CYW_FW_VERSION = 8d87950bfad28c65926695b7357bd8995b60016a
> MURATA_WIRELESS_CYW_FW_VERSION_NVRAM = d27f1bf105fa1e5b828e355793b88d4b66188411
> MURATA_WIRELESS_CYW_FW_VERSION_PATCH = 748462f0b02ec4aeb500bedd60780ac51c37be31
>
> MURATA_WIRELESS_CYW_FW_SITE = $(call github,murata-wireless,cyw-fmac-fw,$(MURATA_WIRELESS_CYW_FW_VERSION)
> MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS = \
> $(call github,murata-wireless,cyw-fmac-nvram,$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM)/cyw-bt-nvram-$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM).tar.gz \
> $(call github,murata-wireless,cyw-fmac-patch,$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH)/cyw-bt-patch-$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH).tar.gz
>
> define MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
> $(foreach tar, $(notdir $(MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS)), \
> $(call suitable-extractor,$(tar)) $(MURATA_WIRELESS_CYW_FW_DL_DIR)/$(tar) | \
> $(TAR) --strip-components=1 -C $(@D) $(TAR_OPTIONS) -$(sep) \
> )
> endef
> MURATA_WIRELESS_CYW_FW_POST_EXTRACT_HOOKS += MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
>
> And a similar hook for the installation step (which I leave up to you as
> an exercise ;-) ).
Thanks for review and tips on how to use single package here. The only
downside that I see is that all three packages will be downloaded, even
if (in some cases) one or two are required only. However overall code
will be much simpler, so it is a good idea anyway.
>
> Regards,
> Yann E. MORIN.
>
>> Marcin Niestroj (3):
>> package/murata-wireless-cyw-fmac-fw: new package
>> package/murata-wireless-cyw-fmac-nvram: new package
>> package/murata-wireless-cyw-bt-patch: new package
>>
>> DEVELOPERS | 1 +
>> package/Config.in | 1 +
>> package/murata-wireless/Config.in | 7 ++
>> .../murata-wireless-cyw-bt-patch/Config.in | 47 ++++++++++
>> .../murata-wireless-cyw-bt-patch.hash | 3 +
>> .../murata-wireless-cyw-bt-patch.mk | 50 ++++++++++
>> .../murata-wireless-cyw-fmac-fw/Config.in | 91 +++++++++++++++++++
>> .../murata-wireless-cyw-fmac-fw.hash | 3 +
>> .../murata-wireless-cyw-fmac-fw.mk | 80 ++++++++++++++++
>> .../murata-wireless-cyw-fmac-nvram/Config.in | 91 +++++++++++++++++++
>> .../murata-wireless-cyw-fmac-nvram.hash | 3 +
>> .../murata-wireless-cyw-fmac-nvram.mk | 75 +++++++++++++++
>> package/murata-wireless/murata-wireless.mk | 9 ++
>> 13 files changed, 461 insertions(+)
>> create mode 100644 package/murata-wireless/Config.in
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash
>> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk
>> create mode 100644 package/murata-wireless/murata-wireless.mk
>>
>> --
>> 2.21.0
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
--
Marcin Niestr?j
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 0/3] murata-wireless firmware packages
2019-05-09 7:52 ` Marcin Niestrój
@ 2019-05-09 18:10 ` Yann E. MORIN
0 siblings, 0 replies; 10+ messages in thread
From: Yann E. MORIN @ 2019-05-09 18:10 UTC (permalink / raw)
To: buildroot
Marcin, All,
On 2019-05-09 09:52 +0200, Marcin Niestr?j spake thusly:
> Yann E. MORIN <yann.morin.1998@free.fr> writes:
> > On 2019-05-07 10:32 +0200, Marcin Niestroj spake thusly:
> >> This set adds 3 firmware packages for muRata wireless modules (WiFi + BLE).
> >> I've put all three packages into single murata-wireless directory and Kconfig
> >> submenu, as they relate to the same hardware and there are plenty of options
> >> to choose from. Not sure whether this is the correct approach, so looking
> >> forward to get feedback on this.
> >
> > I wonder why we would actually need three packages.
> >
> > As far as I can see from a cursory look, they are all very tightly
> > coupled; they even have the same choice about the actual variant to use.
> >
> > So, I would like we look at making that a single package, which
> > downloads multiple tarballs, something like:
> >
> > MURATA_WIRELESS_CYW_FW_VERSION = 8d87950bfad28c65926695b7357bd8995b60016a
> > MURATA_WIRELESS_CYW_FW_VERSION_NVRAM = d27f1bf105fa1e5b828e355793b88d4b66188411
> > MURATA_WIRELESS_CYW_FW_VERSION_PATCH = 748462f0b02ec4aeb500bedd60780ac51c37be31
> >
> > MURATA_WIRELESS_CYW_FW_SITE = $(call github,murata-wireless,cyw-fmac-fw,$(MURATA_WIRELESS_CYW_FW_VERSION)
> > MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS = \
> > $(call github,murata-wireless,cyw-fmac-nvram,$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM)/cyw-bt-nvram-$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM).tar.gz \
> > $(call github,murata-wireless,cyw-fmac-patch,$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH)/cyw-bt-patch-$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH).tar.gz
> >
> > define MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
> > $(foreach tar, $(notdir $(MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS)), \
> > $(call suitable-extractor,$(tar)) $(MURATA_WIRELESS_CYW_FW_DL_DIR)/$(tar) | \
> > $(TAR) --strip-components=1 -C $(@D) $(TAR_OPTIONS) -$(sep) \
> > )
> > endef
> > MURATA_WIRELESS_CYW_FW_POST_EXTRACT_HOOKS += MURATA_WIRELESS_CYW_FW_EXTRACT_NVRAM_PATCH
> >
> > And a similar hook for the installation step (which I leave up to you as
> > an exercise ;-) ).
>
> Thanks for review and tips on how to use single package here. The only
> downside that I see is that all three packages will be downloaded, even
> if (in some cases) one or two are required only. However overall code
> will be much simpler, so it is a good idea anyway.
Well, you can always do the extra dowenload dance conditionally:
ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_NEEDS_NVRAM),y)
MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS += \
(call github,murata-wireless,cyw-fmac-nvram,$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM)/cyw-bt-nvram-$(MURATA_WIRELESS_CYW_FW_VERSION_NVRAM).tar.gz \
endif
ifeq ($(BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_NEEDS_PATCH),y)
MURATA_WIRELESS_CYW_FW_EXTRA_DOWNLOADS += \
$(call github,murata-wireless,cyw-fmac-patch,$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH)/cyw-bt-patch-$(MURATA_WIRELESS_CYW_FW_VERSION_PATCH).tar.gz
endif
And in Config.in:
config BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_NEEDS_NVRAM
bool
config BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_NEEDS_PATCH
bool
choice
bool "Variant to use"
config BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_FOO
bool "foo"
select BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_NEEDS_PATCH
config BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_BAR
bool "bar"
select BR2_PACKAGE_MURATA_WIRELESS_CYW_FW_NEEDS_NVRAM
endchoice
You get the idea...
Regards,
Yann E. MORIN.
> > Regards,
> > Yann E. MORIN.
> >
> >> Marcin Niestroj (3):
> >> package/murata-wireless-cyw-fmac-fw: new package
> >> package/murata-wireless-cyw-fmac-nvram: new package
> >> package/murata-wireless-cyw-bt-patch: new package
> >>
> >> DEVELOPERS | 1 +
> >> package/Config.in | 1 +
> >> package/murata-wireless/Config.in | 7 ++
> >> .../murata-wireless-cyw-bt-patch/Config.in | 47 ++++++++++
> >> .../murata-wireless-cyw-bt-patch.hash | 3 +
> >> .../murata-wireless-cyw-bt-patch.mk | 50 ++++++++++
> >> .../murata-wireless-cyw-fmac-fw/Config.in | 91 +++++++++++++++++++
> >> .../murata-wireless-cyw-fmac-fw.hash | 3 +
> >> .../murata-wireless-cyw-fmac-fw.mk | 80 ++++++++++++++++
> >> .../murata-wireless-cyw-fmac-nvram/Config.in | 91 +++++++++++++++++++
> >> .../murata-wireless-cyw-fmac-nvram.hash | 3 +
> >> .../murata-wireless-cyw-fmac-nvram.mk | 75 +++++++++++++++
> >> package/murata-wireless/murata-wireless.mk | 9 ++
> >> 13 files changed, 461 insertions(+)
> >> create mode 100644 package/murata-wireless/Config.in
> >> create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/Config.in
> >> create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.hash
> >> create mode 100644 package/murata-wireless/murata-wireless-cyw-bt-patch/murata-wireless-cyw-bt-patch.mk
> >> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/Config.in
> >> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.hash
> >> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-fw/murata-wireless-cyw-fmac-fw.mk
> >> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/Config.in
> >> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.hash
> >> create mode 100644 package/murata-wireless/murata-wireless-cyw-fmac-nvram/murata-wireless-cyw-fmac-nvram.mk
> >> create mode 100644 package/murata-wireless/murata-wireless.mk
> >>
> >> --
> >> 2.21.0
> >>
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot at busybox.net
> >> http://lists.busybox.net/mailman/listinfo/buildroot
>
>
> --
> Marcin Niestr?j
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 10+ messages in thread