[Buildroot] [RFC PATCH 1/1] iputils: Bump to version s20190324

[Buildroot] [RFC PATCH 1/1] iputils: Bump to version s20190324

[Petr Vorel]

Upstream changed build system to Meson.
Removed patch included in this release.

Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
Hi,

I'm trying to update iputils for Buildroot to newest version s20190324,
which changed build system to Meson. I cannot figure out which compiler
option is missing / wrong, or which dependency is missing or which
buildroot config is missing wrong. Any tip / idea?

Kind regards,
Petr

>>> iputils s20190324 Configuring
rm -rf /opt/buildroot/output/build/iputils-s20190324//build
mkdir -p /opt/buildroot/output/build/iputils-s20190324//build
sed -e "s%@TARGET_CROSS@%/opt/buildroot/output/host/bin/arm-linux-%g" -e "s%@TARGET_ARCH@%arm%g" -e "s%@TARGET_CPU@%arm926ej-s%g" -e "s%@TARGET_ENDIAN@%"little"%g" -e "s%@TARGET_CFLAGS@%`printf '"%s", ' -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os  `%g" -e "s%@TARGET_LDFLAGS@%%g" -e "s%@TARGET_CXXFLAGS@%`printf '"%s", ' -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os  `%g" -e "s%@HOST_DIR@%/opt/buildroot/output/host%g" package/meson/cross-compilation.conf.in > /opt/buildroot/output/build/iputils-s20190324//build/cross-compilation.conf
The Meson build system
Version: 0.50.1
Source dir: /opt/buildroot/output/build/iputils-s20190324
Build dir: /opt/buildroot/output/build/iputils-s20190324/build
Build type: cross build
Project name: iputils
Project version: s20190324
Native C compiler: ccache cc (gcc 8.3.1 "cc (SUSE Linux) 8.3.1 20190226 [gcc-8-branch revision 269204]")

[Buildroot] [RFC PATCH 1/1] iputils: Bump to version s20190324

[Thomas Petazzoni]

Hello Petr,

On Mon,  6 May 2019 01:29:23 +0200
Petr Vorel <petr.vorel@gmail.com> wrote:

> I'm trying to update iputils for Buildroot to newest version s20190324,
> which changed build system to Meson. I cannot figure out which compiler
> option is missing / wrong, or which dependency is missing or which
> buildroot config is missing wrong. Any tip / idea?

ping6_common.c lacks:

#include <stddef.h>

once added, it builds fine. The installation then fails because:

define IPUTILS_INSTALL_TARGET_CMDS
        $(INSTALL) -D -m 755 $(@D)/arping      $(TARGET_DIR)/sbin/arping
        $(INSTALL) -D -m 755 $(@D)/clockdiff   $(TARGET_DIR)/bin/clockdiff
        $(INSTALL) -D -m 755 $(@D)/ping        $(TARGET_DIR)/bin/ping
        $(INSTALL) -D -m 755 $(@D)/rarpd       $(TARGET_DIR)/sbin/rarpd
        $(INSTALL) -D -m 755 $(@D)/rdisc       $(TARGET_DIR)/sbin/rdisc
        $(INSTALL) -D -m 755 $(@D)/tftpd       $(TARGET_DIR)/usr/sbin/in.tftpd
        $(INSTALL) -D -m 755 $(@D)/tracepath   $(TARGET_DIR)/bin/tracepath
        $(INSTALL) -D -m 755 $(@D)/traceroute6 $(TARGET_DIR)/bin/traceroute6
endef

is no longer correct, as binaries are now produced in $(@D)/build/. But
probably we could use the standard installation procedure of the meson
build system instead of having custom install commands ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [RFC PATCH 1/1] iputils: Bump to version s20190324

[Petr Vorel]

Hi Thomas, Sami,

> > ping6_common.c lacks:

> > #include <stddef.h>

> > once added, it builds fine.

> Hello,

> The include is fixed in upstream commit:
> https://github.com/iputils/iputils/commit/f65b38b9317e1298cfc5877b0eed7c7badbe597a

Thanks a lot both for info!

> Maybe it would make sense to do next release sometime soon that takes care of
> couple issues there were in s20190324, ref:

> * 25b552e (HEAD -> master, origin/master) build-sys/doc: make xsltproc required
> * 784a67c build-sys: make setcap-setuid.sh respect ${DESTDIR}
> * d45a8c8 build-sys: allow disabling setcap-setuid.sh at install
> * c3c04a9 ping: fix use-after-free
> * f65b38b ping6_common.c: include stddef.h
> * 13c24bc arping: fix packets count
> * f06ca70 build-sys: make rdisc.service a regular unit
> * 0cd6217 tracepath: fix warning: '/*' within block comment [-Wcomment]
> * c503834 doc: Use namespace correctly
> * c9aca1b tracepath: fix musl build, again
> * 991916b (tag: s20190324) release: iputils-s20190324
+1


> >The installation then fails because:

> > define IPUTILS_INSTALL_TARGET_CMDS
> >         $(INSTALL) -D -m 755 $(@D)/arping      $(TARGET_DIR)/sbin/arping
> >         $(INSTALL) -D -m 755 $(@D)/clockdiff   $(TARGET_DIR)/bin/clockdiff
> >         $(INSTALL) -D -m 755 $(@D)/ping        $(TARGET_DIR)/bin/ping
> >         $(INSTALL) -D -m 755 $(@D)/rarpd       $(TARGET_DIR)/sbin/rarpd
> >         $(INSTALL) -D -m 755 $(@D)/rdisc       $(TARGET_DIR)/sbin/rdisc
> >         $(INSTALL) -D -m 755 $(@D)/tftpd       $(TARGET_DIR)/usr/sbin/in.tftpd
> >         $(INSTALL) -D -m 755 $(@D)/tracepath   $(TARGET_DIR)/bin/tracepath
> >         $(INSTALL) -D -m 755 $(@D)/traceroute6 $(TARGET_DIR)/bin/traceroute6
> > endef

> > is no longer correct, as binaries are now produced in $(@D)/build/. But
> > probably we could use the standard installation procedure of the meson
> > build system instead of having custom install commands ?

> +1. Just let the build system do it's job.
I'll do. I didn't realise this was needed just for previous custom build system.

Kind regards,
Petr