From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/2] Some more netsurf fixes
Date: Thu, 9 May 2019 22:28:06 +0200 [thread overview]
Message-ID: <20190509202808.6741-1-thomas.petazzoni@bootlin.com> (raw)
Hello,
On my machine, netsurf does not even build due to commit
6da049f8ae61b956d135526722ce58fc2f67626a. My PATCH 1/2 fixes that, but
it still remains fragile as CFLAGS/LDFLAGS are used for both building
target objects and host tools. For example, with my PATCH 1/2 applied,
if BR2_STATIC_LIBS is enabled, -static is passed in LDFLAGS, and
netsurf fails to build on my machine with "-lc not found" because it
passes -static when building host tools, and I don't have a static
glibc installed on my machine.
PATCH 2/2 disable static linking for netsurf, which was anyway failing
to build for months in the autobuilders.
To be honest, the netsurf build system is broken beyond repair, and is
a royal pain to work with. Since nobody has acted to fix those build
issues for the past months, if my patches are not sufficient (and as I
said, they *are* fragile), I will propose to simply remove the netsurf
package.
Best regards,
Thomas
Thomas Petazzoni (2):
package/netsurf: change how CFLAGS/LDFLAGS are passed
package/netsurf: do not allow on static linking configurations
package/netsurf/Config.in | 5 +++++
package/netsurf/netsurf.mk | 9 +++++++--
2 files changed, 12 insertions(+), 2 deletions(-)
--
2.21.0
next reply other threads:[~2019-05-09 20:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 20:28 Thomas Petazzoni [this message]
2019-05-09 20:28 ` [Buildroot] [PATCH 1/2] package/netsurf: change how CFLAGS/LDFLAGS are passed Thomas Petazzoni
2019-05-09 20:52 ` Thomas Petazzoni
2019-05-14 21:12 ` Peter Korsgaard
2019-06-05 21:01 ` Peter Korsgaard
2019-05-09 20:28 ` [Buildroot] [PATCH 2/2] package/netsurf: do not allow on static linking configurations Thomas Petazzoni
2019-05-14 21:13 ` Peter Korsgaard
2019-06-05 21:01 ` Peter Korsgaard
2019-05-26 11:42 ` [Buildroot] [PATCH 0/2] Some more netsurf fixes Arnout Vandecappelle
2019-05-26 21:15 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509202808.6741-1-thomas.petazzoni@bootlin.com \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox